From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D04E24545E; Fri, 14 Jun 2024 17:31:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3FA540B95; Fri, 14 Jun 2024 17:31:27 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2072.outbound.protection.outlook.com [40.107.95.72]) by mails.dpdk.org (Postfix) with ESMTP id 17EE8402D0 for ; Fri, 14 Jun 2024 17:31:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jD3v7FdzGBnerWVxHUn4/rnyW2CZW1UyUYDEATU5yGYcLfe6L4O+CIrl/S7lKnFxKSQHuHxL29MFi3UfqtgQCQWw2Soo84G+c7xLOdnUg43Avhj6hc3dc5ejyzQ44awI9EkQd52gCfHHyFl3fDWaqpiVQ+VSWMTCmI4GilnMv9cfr4j7uViQUelmxEwET3zzQS9W2ErwRCdv7vaQHdnASw/vR7sbgC4iIIH8uFPS1T0mAYLooVB/pS5VnWPzK7u16gBtsxrYRw8hjQ1ZTRYo8aL7wLsoweZ64moi2vtwbPU8qpFb/cmV2rMTbVwKdtt5H4uxYdxn0x1h9CbbJRND7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=irRmGcEk4vooL51W2kELW0NPGmPfAh3vfkvCdpeJRYs=; b=H5bfFBiyxJIEi7b3DmulrsASp4x8szD8zQ+WLTxB/9uqPDy3Hl2oH1i8yWaN7LVRXybBSQnZut7VZPpb3/D9WM4PHSGLQhWEpeTxueW4ZPpSVyiDO7tXk13Y8N0cExAW5njq98nwBq3UlBXZWVf2FOsiGuS35xn2t9VVuwpf3Vjj7ItxN1TqCYpZS1dxf5P4u7GvUvV0jGcFxaPZrS2BR+VEEot6Nvf9vnSq9eoxbIZqB8oBA4op4E3IspkAOntJAcQCOKgBoCu3DbaiChdmsAt1h6Ooxbjfd3+XB4jWB1mGfEEyTxdCOR85knt8pz5jDGkUXSEG1uCW49g5mn3xcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=irRmGcEk4vooL51W2kELW0NPGmPfAh3vfkvCdpeJRYs=; b=4y2IWelEM+ocfjLjFCZD4WGNluKqjiTNjy57ONT+/qzdB6z/1xzg+SnTTaWOu7pRa6rBJg5gAlgiOOkFko9CW98mBeoodLg9YlXRV0BEB9V8PZ4rk80CtXuErNKUXD1wx751zu8G5duRbMoUjm3RfmN4xMaQlh1MzB6nc2jl5/A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB8022.namprd12.prod.outlook.com (2603:10b6:806:307::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.26; Fri, 14 Jun 2024 15:31:22 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7677.026; Fri, 14 Jun 2024 15:31:21 +0000 Message-ID: <4702e8c5-1f3e-4d0b-acd4-2f33775000cc@amd.com> Date: Fri, 14 Jun 2024 16:31:14 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 4/4] net/ice: remove use of VLAs To: Konstantin Ananyev , Konstantin Ananyev , "dev@dpdk.org" Cc: "hujiayu.hu@foxmail.com" , "roretzla@linux.microsoft.com" , "bruce.richardson@intel.com" , "anatoly.burakov@intel.com" , "vladimir.medvedkin@intel.com" References: <20240523162604.2600-1-konstantin.v.ananyev@yandex.ru> <20240523162604.2600-5-konstantin.v.ananyev@yandex.ru> <9b196355-578a-48f3-926b-38cadff28052@amd.com> <773311c7507d4bad987d90bbf7ea41b8@huawei.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <773311c7507d4bad987d90bbf7ea41b8@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0344.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB8022:EE_ X-MS-Office365-Filtering-Correlation-Id: b5f7fcc3-6988-4633-60fe-08dc8c870b3e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cjB4NnNheXA3dDQvclRDSUp3NUdkUHNScmlldFdMUHVDQnR6anFwdGE2WEQx?= =?utf-8?B?VXFjSWRZK3ZBZTUyOGRsZm1WT1I5dk5jb0tqbmY2MU9WNWlOVENRclhNNTYy?= =?utf-8?B?YlM2SEdEd1pCeHBFNEowNXExeWN5Nm1OSlpLQmp2T1luVTlxUXBCbForejBH?= =?utf-8?B?Zlg4S2Vwa1kxSmZnVTZLOTJoM2FKbitqdm9mTzVSdEZiNGRKN25yWEx3eHZL?= =?utf-8?B?dDFQNDduUFI0Ty92KzVmajdCWWliTTJaOWhpWEV6NmxxU05McDR0TTlKYzY5?= =?utf-8?B?R0dsQlRUcDIxaEJUQ21QSDBVT1NtU0tDaVNtSnJSQmJJajFXbWlqQTNWTTk5?= =?utf-8?B?NUdjS200SUdVN1pGSzJnZlFWbjUyVkdRZmZMK0VqQ01jdlpBLzFEWm8vaWZS?= =?utf-8?B?VjBBYy9OSEg3VW9BZ3BXeThvYTlFZ2ZMYTBYeEptRlhFRFZpUHdjb2tpN2Jl?= =?utf-8?B?TllZWEZ6cGxvVnE1Y0t2TEtUUnBjUkRkQWhCakV5ZUh0Y09udUprSDhoR1pj?= =?utf-8?B?NmV6UzloN1oybHBaSllNOWEvbE9PdjljVS8wb2U3aUJVblNzMWFISXFubEt0?= =?utf-8?B?R2pBdFBnWXg0YjczL3ZBMG5raHovRkpySVNtb3JyNjRuNmdKMnE2N3pwKzNR?= =?utf-8?B?Zyt3dEFiKzlOZTRUcnR1MTlUL0MxYS9CeFRteXdQdnRJd0p5eUlOT3pNYmJS?= =?utf-8?B?R0RDQythV0lOd1ZkZjhENGlGdjB3NGt1aUt6ZzVnSTBCR2krblNCK2NmOU1N?= =?utf-8?B?cnJWNWZNdFRXSDdjeGNLRDdZektrRjdUTng5aEVBM2taVzJhc2RybVRhY0pr?= =?utf-8?B?Sk9OS3FqY3ZrUnIyS1ppQ0dPQk14cHZLQ2tmekczUkFyMFluOVlWb09mQkFY?= =?utf-8?B?MS9hK3JnK3VZZ2dDTnRTVTBBSzB3em9nM0dHQXN2ckJ3M2ZaeHo4cFpjZjhU?= =?utf-8?B?SGZtbjdQM2JWdXUwRHp3K25GNmlrQytnRDdXQmtBUUZiNjRuRGhJYi93ZjlD?= =?utf-8?B?c2o1RUQ4M0lIRlRtdXpjNFVTa3lvbGRTQjIwT2dHNWVLKzZjWENsTXY1TDdP?= =?utf-8?B?ditka2JQN0M2ZjRUYVVlTEFseGp2OWJpc0w5ZjhMVmIxOUF3ZmpUOFlMVFNo?= =?utf-8?B?Um1EVGtETWhOOW9XTk9haVFkSW5ZUzlGSTcwOGtYT0tpT2ZYUUZ6SGYvYmQx?= =?utf-8?B?K2wvTlVLb28yVGJTNHU4bjRpL0lQVFFKU3NTNkRMTzhacjlGQnFXNjV1MzJK?= =?utf-8?B?YjQ2bnpPMXUrc3h6a2ZVM0Iwd0MrcHQ3RTJKKzFVTUNZS09RMXVodTZuNGRE?= =?utf-8?B?aTg0NHZqUVNrd2xiekhLbWFlT2lQRnhrYUhFVG11NzlDK2ZIdWxUSk9YNHgx?= =?utf-8?B?QUFZQkRMbnkvdEFwT3YyT2lnV2JsYk9FSEcvSk9XMExuTVp6QkhFbmd5blNK?= =?utf-8?B?dW5KRjJReEJnZXpBSERuUlUxOGF2dFZXS1d5MlpLTTBBOGxxZVVaZ3BGZUxz?= =?utf-8?B?djZXdXVkRmV4aU0wTkE0SnF4ZmJNTFhVN1VGZ1ZtT0FuOXB2dFQ5RDAxV1o4?= =?utf-8?B?YXpHQjRhR1d3M0VsMkQxOVpCTjdjVURHcFlFaG9hSVU3SW9hZE9NVmoyRWc0?= =?utf-8?B?eU1rUXZrTFpTcDlEbnlpT09SQ0wzaXpDQ1ZZYXIyQ1ljTlgrS2YycVprZTJF?= =?utf-8?B?QmVUclFXNjRvU3FsL2lRYXFYbXgxeGg0bFJlaEQwMUFvUFhDcDNXQ29YblM0?= =?utf-8?Q?wm6AK6Z52o3q04A7Q7nwu4wlGgSRaa7qGef8ihW?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVQyOXdDRkRFKytkN2krb0xWWG14SWJyR3BCMTdNMzd0aG1DNC96N2hnQi9w?= =?utf-8?B?MFQ0VStBaWdyc1ROYmM0QVlPd3VROGVzNU5GWFY5RWpzNjg2RkV6TlVpQnpF?= =?utf-8?B?Z2xkdCtMbE5ZSFJYcmRibno1bjZSZGZGUVpHaTdzR2ZpdE5ac2hUTkFDRkxj?= =?utf-8?B?QzRtemVtM1FLcW1WemR0bW5aZ1RJcmJPcGZNaTdrd0xZbEUzVURBcFB3OExu?= =?utf-8?B?TDVWczhSZVc2MW1SRVE5akE4blUxdVRraWlrVW9DSTM5Q2EyNnBwUE82Snhi?= =?utf-8?B?NWVUcGVxZ0xJK1NXRk04RDFlU1UrbVVydVg2SlBUN3FZNm5UNGRsY1MvdUdK?= =?utf-8?B?ZFN5aSszTVp2QWt5VGFBb2V1MVQ1eEFDZHY1akJjeHVpeURIbXFZbmVZbFZO?= =?utf-8?B?TlBQMHZZS2Z3d2ErWWRXY3U1M05MekpSTmljL1NpZkx6eU9YUDRBRExwYjJE?= =?utf-8?B?VlV2Q0tEdkpTWjlCRzBPTHdGaEVpc2lMMnhNRlVRK29mYTBRSXdab1ViTVFj?= =?utf-8?B?Qi9BQzVpZUVjWDRNRndKZFdVUkF2SjhxWFRmek01a2FBN3NXR1BMS3Z0ZjRE?= =?utf-8?B?Y1VkOGhZOXI5QlB2eFUzTjVuZEZObWE1NlcvQTNLV0lZZWJTd0hGWFVqK0pa?= =?utf-8?B?UktPWXR5YW9UeERKckY2cXMveHA5T1MzcmhUWjlPQUVTTEJ2Tm9vblhlcjBk?= =?utf-8?B?RmNicE1ReSszSVJSM2R4MldWVmUrUGIxcjhweWpFU1ZoUzhSOEUzdWJFZVlI?= =?utf-8?B?WHlzZ0F5VXRmb2ltOW5nRnI3RFJCN2RPbURQalI5OFlhazZPRHEyb3dKZGhl?= =?utf-8?B?NVMvZW1JdE8zWEhpbXNpaGU5V3VvVGF5SEtTR3FidlhYVkpWVGRMd241NHRw?= =?utf-8?B?MlE1S0tQM2kzaVkwZjVXTXBUWU1vWjdxWVFSaGFYOWlUT2lRWWY2azRob2wz?= =?utf-8?B?T092dWNqem8xOUtYMEdaVlBZVytnL3VKWERuNmc4Q2lXZ0UyZEFUMnpPWW9H?= =?utf-8?B?NS9SRjA5NzlZZ1U3NmZMOXlLTEZDUWMrMmFVVXdLdTM1Q0lleWtNYk1RaXRy?= =?utf-8?B?WDAxM0c1T0psSElMbE83bHdYQnJQYmFabVh1aUh0ZGRTUFdmYk5RUU1PMVlI?= =?utf-8?B?RTBIT0UwblVSRkRqYzE5YldpbE8zSERCNmRmK0lhZk5rVEpFcWlFTGhjS0tz?= =?utf-8?B?bC9TVWk3cmJndWRybm1lNDJkNVdjT3RnZEo2TE1XRHQ0ZmNxQ2MxOEFYTFRl?= =?utf-8?B?RlV5OXVOa3dnS29raG90Y1hDWDF6S3M2dFk1S1BQSWpHSEhIdWRlTTM5ZUpH?= =?utf-8?B?TXNKQVh5ZVdiS0xFWi9sb3MvR1pENGNwN1NtNXE0dC80UW5oQ0d2Nll1b3JD?= =?utf-8?B?MjlBOGZ1ckVNSGNBRFVPdXQ2MXZxWmtZdE1pYi9tdXFtT2o2Z3lCeGxZaGRi?= =?utf-8?B?MzlzYmxTdnpMZnlmc0RqOU5KWElITjFTcXNyWWV2SXNaUitHUEl2a2N3cHpK?= =?utf-8?B?ZVJFWStRcUhTc1JWdEdOK0ZlS3Y5QTFqQnZwUkdTb3FLZkVSd2IwbTZqelFQ?= =?utf-8?B?WVZibmFTUlVJQTJjUzJEMGNUeHM2bUkxMFFOZ1FnWjZxT2lMTFkzeDNHNHo5?= =?utf-8?B?emU2U3Y3RHRiQXdLSXJ2bHFuMW9uRXZEejJJZ0QzRVpUSmkvbDMvRjN2RXVV?= =?utf-8?B?bmUzV1JtdWZQb05LbGY1ZGNDRUxKY0ZpbmdkL1JVK0g2SW82bkUyTjNYTUJh?= =?utf-8?B?cDB2RnFTVGVzLzlKeForREo3VjUxVkZ5UFdVZ3Z0VlQyVDRFQnplQzdSS3lH?= =?utf-8?B?ZXFrSjZYMGNsbVI0bUJqYm9sWUFpTjZrZm01NkdZWk9MQ1lLZHBIT1AxckZj?= =?utf-8?B?TnVjN25hL2NHUk9lQk1mbDNYZVBGNzhIdDVLSTF2ZjRSSmp0OFIwa0RGVUdh?= =?utf-8?B?Vk1NMGFBOUdrMmp6d2dLQmJSTVZONzdOTWJQR1VpanFOYnFVeTQ0cGdXODRV?= =?utf-8?B?NWpvSEpsNGsyY1oxTlU1aUlBeGlrNkZOYWJ6aFFMMXRPV1Zmdy9iam8xN0xB?= =?utf-8?B?SjE4TGlKVGdTUVRkNlduay8rTEpQeUQrSlNYaUZvaE16RExyQ2lnclora1BM?= =?utf-8?Q?BoYLIySriIGlI7tE4ils+u16H?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5f7fcc3-6988-4633-60fe-08dc8c870b3e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 15:31:21.9028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZBZAqu+GpPX15iT4ML73mdXx6iWjbOBuLSWwbBf9G2Pav2mQeFBXaMCs+Rta62U2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8022 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/13/2024 11:32 AM, Konstantin Ananyev wrote: > > >> >> On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: >>> From: Konstantin Ananyev >>> >>> ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] >>> >>> Here VLA is used as a temp array for mbufs that will be used as a split >>> RX data buffers. >>> As at any given time only one thread can do RX from particular queue, >>> at rx_queue_setup() we can allocate extra space for that array, and then >>> safely use it at RX fast-path. >>> >> >> Is there a reason to allocate extra space in sw_ring and used some part >> of it for split buffer, instead of allocating a new buffer for it? > > Less allocations - less points to fail, less checks to do. > Again, having it close to sw_ring is probably a good thing too, > possibly less pressure on MMU, etc. - even though I don't think it is really critical. > But yes, it could be a separate rte_zmalloc(), even though > I don't see good reason for that. > ack >> >>> Signed-off-by: Konstantin Ananyev >>> --- >>> drivers/net/ice/ice_rxtx.c | 18 ++++++++++++------ >>> drivers/net/ice/ice_rxtx.h | 2 ++ >>> 2 files changed, 14 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c >>> index 95a2db3432..6395a3b50a 100644 >>> --- a/drivers/net/ice/ice_rxtx.c >>> +++ b/drivers/net/ice/ice_rxtx.c >>> @@ -1171,7 +1171,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev, >>> struct ice_vsi *vsi = pf->main_vsi; >>> struct ice_rx_queue *rxq; >>> const struct rte_memzone *rz; >>> - uint32_t ring_size; >>> + uint32_t ring_size, tlen; >>> uint16_t len; >>> int use_def_burst_func = 1; >>> uint64_t offloads; >>> @@ -1279,9 +1279,14 @@ ice_rx_queue_setup(struct rte_eth_dev *dev, >>> /* always reserve more for bulk alloc */ >>> len = (uint16_t)(nb_desc + ICE_RX_MAX_BURST); >>> >>> + /* allocate extra entries for SW split buffer */ >>> + tlen = ((rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0) ? >>> + rxq->rx_free_thresh : 0; >>> + tlen += len; >>> + >>> /* Allocate the software ring. */ >>> rxq->sw_ring = rte_zmalloc_socket(NULL, >>> - sizeof(struct ice_rx_entry) * len, >>> + sizeof(struct ice_rx_entry) * tlen, >>> RTE_CACHE_LINE_SIZE, >>> socket_id); >>> if (!rxq->sw_ring) { >>> @@ -1290,6 +1295,8 @@ ice_rx_queue_setup(struct rte_eth_dev *dev, >>> return -ENOMEM; >>> } >>> >>> + rxq->sw_split_buf = (tlen == len) ? NULL : rxq->sw_ring + len; >>> + >>> ice_reset_rx_queue(rxq); >>> rxq->q_set = true; >>> dev->data->rx_queues[queue_idx] = rxq; >>> @@ -1868,7 +1875,6 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq) >>> uint64_t dma_addr; >>> int diag, diag_pay; >>> uint64_t pay_addr; >>> - struct rte_mbuf *mbufs_pay[rxq->rx_free_thresh]; >>> >>> /* Allocate buffers in bulk */ >>> alloc_idx = (uint16_t)(rxq->rx_free_trigger - >>> @@ -1883,7 +1889,7 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq) >>> >>> if (rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) { >>> diag_pay = rte_mempool_get_bulk(rxq->rxseg[1].mp, >>> - (void *)mbufs_pay, rxq->rx_free_thresh); >>> + (void *)rxq->sw_split_buf, rxq->rx_free_thresh); >>> >> >> Are we allowed to call 'rte_mempool_get_bulk()' with NULL object_table, > > Nope. > >> as 'rxq->sw_split_buf' can be NULL? >> Perhaps can allocate 'rxq->sw_split_buf' even buffer split offload is >> not enabled? > > No, if (rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) !=0, then > rxq->sw_split_buf should not be NULL. > If it is, then there is a bug in my changes, though right now I don't see > how it can happen: as in ice_rx_queue_setup() we always allocate space > rxq->sw_split_buf when RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT is set. > Ack, I see logical condition now. This logic assumes 'rxq->rx_free_thresh' is not '0', although practically this is true, technically can configure it 0 and crash the application.