From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 228DAA04B1; Thu, 24 Sep 2020 10:07:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D36FC1C235; Thu, 24 Sep 2020 10:07:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id A95101C234 for ; Thu, 24 Sep 2020 10:07:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600934838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PesJcbVKNA1agGlQvUq3qDenwoWV2KiWeLyUO30MoZc=; b=fN+ufnTe2gyy7t5LsMx+CmZCk9RTA7gpXcNG7QGeoyjHHO6bi7aislozafCnP2/36MbCOZ 7Q+jDkWgoL0waveRoDWCCrKYi/6/f78oiaZJV3oZO2c+Y8OKpv+u0GPdm2dOpXUaxYNHrk Huysu3Pg7pG3GEiE/4s6JoNwY3wBG8U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-a7f1DC2SNOyLold4Tc2rEQ-1; Thu, 24 Sep 2020 04:07:14 -0400 X-MC-Unique: a7f1DC2SNOyLold4Tc2rEQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E1D9800462; Thu, 24 Sep 2020 08:07:13 +0000 (UTC) Received: from [10.36.110.9] (unknown [10.36.110.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3B66100238E; Thu, 24 Sep 2020 08:07:11 +0000 (UTC) To: "Xia, Chenbo" , "dev@dpdk.org" , "Fu, Patrick" , "amorenoz@redhat.com" References: <20200911150805.79901-1-maxime.coquelin@redhat.com> <20200911150805.79901-8-maxime.coquelin@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <4706c872-5e7c-4815-f7b1-f99aac967f65@redhat.com> Date: Thu, 24 Sep 2020 10:07:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA backend X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/24/20 7:25 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: dev On Behalf Of Maxime Coquelin >> Sent: Friday, September 11, 2020 11:08 PM >> To: dev@dpdk.org; Fu, Patrick ; amorenoz@redhat.com >> Cc: Maxime Coquelin >> Subject: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA backend >> >> vhost-vDPA is a new virtio backend type introduced by vDPA kernel >> framework, which provides abstruction to the vDPA devices and >> exposes an unified control interface through a char dev. >> >> This patch adds support to the vhost-vDPA backend. As similar to >> the existing vhost kernel backend, a set of virtio_user ops were >> introduced for vhost-vDPA backend to handle device specific operations >> such as: >> - device setup >> - ioctl message handling >> - queue pair enabling >> - dma map/unmap >> vDPA relevant ioctl codes and data structures are also defined in >> this patch. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/meson.build | 1 + >> drivers/net/virtio/virtio_user/vhost.h | 1 + >> drivers/net/virtio/virtio_user/vhost_vdpa.c | 310 ++++++++++++++++++ >> .../net/virtio/virtio_user/virtio_user_dev.c | 9 +- >> 4 files changed, 320 insertions(+), 1 deletion(-) >> create mode 100644 drivers/net/virtio/virtio_user/vhost_vdpa.c >> >> diff --git a/drivers/net/virtio/meson.build >> b/drivers/net/virtio/meson.build >> index 3fd6051f4b..eaed46373d 100644 >> --- a/drivers/net/virtio/meson.build >> +++ b/drivers/net/virtio/meson.build >> @@ -42,6 +42,7 @@ if is_linux > > [snip] > >> +static int >> +vhost_vdpa_ioctl(struct virtio_user_dev *dev, >> + enum vhost_user_request req, >> + void *arg) >> +{ >> + int ret = -1; >> + uint64_t req_vdpa; >> + struct vhost_memory_vdpa *vm = NULL; >> + >> + PMD_DRV_LOG(INFO, "%s", vhost_msg_strings[req]); >> + >> + req_vdpa = vhost_req_user_to_vdpa[req]; >> + >> + if (req_vdpa == VHOST_SET_MEM_TABLE) >> + return vhost_vdpa_dma_map_all(dev); >> + >> + if (req_vdpa == VHOST_SET_FEATURES) { >> + /* WORKAROUND */ >> + *(uint64_t *)arg |= 1ULL << VIRTIO_F_IOMMU_PLATFORM; >> + >> + /* Multiqueue not supported for now */ >> + *(uint64_t *)arg &= ~(1ULL << VIRTIO_NET_F_MQ); >> + } >> + >> + switch (req_vdpa) { >> + case VHOST_SET_VRING_NUM: >> + case VHOST_SET_VRING_ADDR: >> + case VHOST_SET_VRING_BASE: >> + case VHOST_GET_VRING_BASE: >> + case VHOST_SET_VRING_KICK: >> + case VHOST_SET_VRING_CALL: >> + *(unsigned int *)arg = *(unsigned int *)arg; > > Above line should be deleted? Yes! >> + PMD_DRV_LOG(DEBUG, "vhostfd=%d, index=%u", >> + dev->vhostfd, *(unsigned int *)arg); >> + break; >> + default: >> + break; >> + } >> + >> + ret = ioctl(dev->vhostfd, req_vdpa, arg); >> + >> + if (vm) >> + free(vm); > > I think 'vm' is never changed after it's init-ed as NULL. Maybe it > should be deleted? If it's not needed, the definition of struct > vhost_memory_vdpa should also be deleted. Correct, will remove in v2. >> + >> + if (ret < 0) >> + PMD_DRV_LOG(ERR, "%s failed: %s", >> + vhost_msg_strings[req], strerror(errno)); >> + >> + return ret; >> +} >> + >> +/** >> + * Set up environment to talk with a vhost vdpa backend. >> + * >> + * @return >> + * - (-1) if fail to set up; >> + * - (>=0) if successful. >> + */ >> +static int >> +vhost_vdpa_setup(struct virtio_user_dev *dev) >> +{ >> + uint32_t did = (uint32_t)-1; > > I see in kernel, 'did' should be u8: > > static long vhost_vdpa_get_device_id(struct vhost_vdpa *v, u8 __user *argp) > > So I think here did should be uint8_t? > > Besides, there are two coding style issues: > CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) > #236: FILE: drivers/net/virtio/virtio_user/vhost_vdpa.c:112: > +vhost_vdpa_dma_unmap(struct virtio_user_dev *dev, void __rte_unused *addr, Not sure about this one. ^ > > CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' > #298: FILE: drivers/net/virtio/virtio_user/vhost_vdpa.c:174: > + int ret = rte_memseg_contig_walk_thread_unsafe( Same here. > Thanks! > Chenbo