From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 04CD058D3 for ; Fri, 20 Jun 2014 15:06:40 +0200 (CEST) Received: by mail-wi0-f176.google.com with SMTP id n3so775409wiv.9 for ; Fri, 20 Jun 2014 06:06:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=UVvsF6tC2rklvjx1V5p4z74SIcnucFiCAtIxQyoKYMA=; b=bIcbs05Bl7JD5j2BFZ7OCx4jqY/H9Swh22E18ivXg86BnvIFz8zItYhJBvNqAkcxbt j3OKuZJRcCq1nNK6INM+LAJQ3TO+vp9IMnEIpeuPfGFU1j9ZKVLUxJwBinRXd758sgEE h7io4us++K9sX/VfEo8ufirCu8SJbiyKZXHqPe+79i8Z0SKyagYqiv0vT9Wvs0y1Vg7V VzACnMgwo2MFXn3uCk58/fdl66LsduV2p5Uue5zfG89FUZgaBom9hIHbTijIK6BrtBcq z/ZkCdmJ5hjZBbYJ2J5y5ZrnglcT1mVotqj4r0GKjD/Zm14toIRDl8SZ1/1FqLAg/aDp EJwQ== X-Gm-Message-State: ALoCoQnMFKpX7KSe3Pa58xSOwUunYpuJQw33tAC3mFrtTOM9crsxdKKiqmOk5hkjHLVgsH+DR9M4 X-Received: by 10.180.212.77 with SMTP id ni13mr4087753wic.5.1403269615028; Fri, 20 Jun 2014 06:06:55 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gc5sm4644453wic.6.2014.06.20.06.06.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jun 2014 06:06:54 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Fri, 20 Jun 2014 15:06:48 +0200 Message-ID: <4709584.nAXykbU3l6@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <20140619151238.28b9bbea@nehalam.linuxnetplumber.net> References: <20140619151238.28b9bbea@nehalam.linuxnetplumber.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] rte_ethdev: add link support flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2014 13:06:40 -0000 Hi Stephen, 2014-06-19 15:12, Stephen Hemminger: > Only some devices support the link state interrupt configuration option. > Link state control does not work in virtual drivers > (virtio, vmxnet3, igbvf, and ixgbevf). Instead of having the application > try and guess whether it will work or not provide a driver flag that > can be checked instead. > > Note: if device driver doesn't support link state control, what > would happen previously is that the code would never detect link > transitions. This prevents that. > [...] > @@ -197,6 +197,8 @@ struct rte_pci_driver { > #define RTE_PCI_DRV_MULTIPLE 0x0002 > /** Device needs to be unbound even if no module is provided */ > #define RTE_PCI_DRV_FORCE_UNBIND 0x0004 > +/** Device driver supports link state interrupt */ > +#define RTE_PCI_DRV_LSC 0x0008 I feel RTE_PCI_DRV_INTR_LSC would be easier to understand. Do you agree? Note that related event is RTE_ETH_EVENT_INTR_LSC and configuration is intr_conf.lsc. Title should be "ethdev: add link state interrupt flag". Thanks -- Thomas