From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A95942C40; Tue, 6 Jun 2023 18:48:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 426A14067B; Tue, 6 Jun 2023 18:48:16 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2088.outbound.protection.outlook.com [40.107.220.88]) by mails.dpdk.org (Postfix) with ESMTP id 1E71740223 for ; Tue, 6 Jun 2023 18:48:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=APu94XvJaCBMvSQhwkb4UysWnYbPNtCgmFgrPlTmTCOXt7U+FDVo/p3zwaM+eQzzZGNq2FbzcK+lg4UMMOZnsWSyg1Z/gawkApXVZKtnhI1LpPX0Jcrzd0nZxkOmYiYiGgrZY+6yg7KUKXwCu+vuR9xWEL38PV4/UgWOmZSWlPkDgldl+9u8qHZYE+pF+q87bQax18zBMHFOoL+lyqLewBBN06a6C258ZuA6JwwiWe/YWCzQHrLxYECMdcTmAlrC/KCfE/a2KadbWRRCDpJtGV7gHUEE4nxYQVnijnbTymeZREvEaqEgnluGkLcvIJmH6qOz3rX41cab6hTeszVScA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vx7znjQ5zLIhuL6irtLm1o0kJWp/SFGYLrQ/ZZvPYAQ=; b=TrxOVmJ4lu0iEYI/AzPfF+oomSM47F91FDjzsrSLgWzQZyRQ/TVt2WOVv7d3OyqFIPxKkEKGceXXgz5HHjzPGJU3LhKnmAsob6+EPlGMqgUfocvlnNFKnplo6SyQ04k8l8T9/L82/R2e5aJQsztTyFvIhLDPEBXnuFOwdEU0j6r6eNyI1BkiNBh3IAhMXGpBrCleqhBri9YSXLj9kl2hOZGDyvw+neW2VYuleAYgwp5fWFQIBRcRjUfTrvMMWGyadK1JP2dujchcPUGR2MHLtoI1CTQ0Vkz88ra9TZhS0WbWfExPeO8yY65ZCMcLL27IP0pGA/C1EJtn0pm4qD1oYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vx7znjQ5zLIhuL6irtLm1o0kJWp/SFGYLrQ/ZZvPYAQ=; b=vEIfV6muTfeFOQ6gOL4DEQ0JYAjvtl5icnsioPMBTfZHmkGrDEZx7/hWdy91BCYBHI61/6qHWUl10BBMUtzZBwFjkxPij/eQvk8jP7JCoLsh6NnM15GpBavQ/4FKJVT5klK2mx9Ay013cezpGyVciqMbrCkzgobwOQGsApW3MTQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CO6PR12MB5425.namprd12.prod.outlook.com (2603:10b6:303:13e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Tue, 6 Jun 2023 16:48:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b%4]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 16:48:12 +0000 Message-ID: <470f085b-d479-4ea8-abdb-0de483439d13@amd.com> Date: Tue, 6 Jun 2023 17:48:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Chaoyong He , Chas Williams , "Min Hu (Connor)" Cc: oss-drivers , Niklas Soderlund , "dev@dpdk.org" , Aman Singh , Thomas Monjalon References: <20230216083231.4721-1-chaoyong.he@corigine.com> <20230301024826.885727-1-chaoyong.he@corigine.com> From: Ferruh Yigit Subject: Re: [PATCH v3 0/2] enhance bonding PMD to support the LACP negotiation In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0035.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CO6PR12MB5425:EE_ X-MS-Office365-Filtering-Correlation-Id: aa5b42dd-2535-4bf1-fc11-08db66add0e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8JFUfi+WX4kX7c0ZF27FREdGsHoamZHisyReajBXiqwVNU5v8p8Z9JtZ0ateWFhA1/pjBnJc3PiNup2SdE1tLG4hPSv9Ri01i3uOtVsX/WkR/pJJyMaJsF2ntWloz3FA1VoHK6BlbEUteADcJFoYRdHEBRk6ovpq0TXEVdwSOTE14IBfTKJ27Fw6D+uQmGKn5L3EriRhO8afaJ3HYQ/oS2gwGg8+Xjuxpr5sWir9Iap0ijTdp2JkDtz8Vd99IcEDBJyKZ0XucXOWXBVLit444AcraQ/yl1H71107CUcJ7Aina/erpvg7LEA04KS6GcbJBy6nFnBjcG4AjHi9dHivkI9nyWQPBsmfiiGv+SjSHAAsxdo/9T87/HBtNNodlDTexOdYDssVQ7S0ZlQ9qCm6YB9TWie+fiQiR86YEDFnDwmsOqValCAaKcRxwWWvi+fzB1cbtqKXhaocyfzR3+5u1zuWuFqfqfZo+FImXrwQr0hYE1VkIjuhLGPG/2JfJU2wfbp3SpHLK3dRGa1Z0BsWqwkZX5W5pd3Eh/HrXPJWk2/avkhoJnXIIDCuK083gQ6rCeo19nYW81ueaPdQLpJJyBTOJD5AgcDjGxEzjtgE1CuvXZmqgwwug/q39XJ91BEdSCIQLrGB5zj0mJHdVmKblw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199021)(186003)(6506007)(26005)(6512007)(53546011)(2616005)(31686004)(83380400001)(86362001)(6486002)(6666004)(36756003)(2906002)(8676002)(8936002)(44832011)(110136005)(478600001)(38100700002)(31696002)(5660300002)(4326008)(54906003)(316002)(41300700001)(66556008)(66946007)(66476007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWlXMVl6TkFOK3ZaTkdNWVYwNlltV0xNanpNWkg4eUpySDBucHdEYTFwbHlC?= =?utf-8?B?YUJpWUlVQlZTZjloVndFd1kxcjFmNGZzbnRkU1lLT21PdVdoS1VqK295dkcz?= =?utf-8?B?bGh6ZllPUlBTRjIvUCtYY1JycXFlOTZ0dnpieHQrekZCbVhnYUlKdC9VT1dn?= =?utf-8?B?M3ZTS2lyUHJPOUs0ZEk1VHI4S014TEVBbjlkVmNIRG01Y21PMUhkeW9pT0RR?= =?utf-8?B?U0YyRDRrNFVKMXAyQnhpNi9oUFFONDRZZlNHK0l3cXgwY3hGamtBajArbEp4?= =?utf-8?B?aW5yOHFySW1ld1ZrY0tvTFI1MEx4Nm5HVFJYT3RJWTVQSFBDd2VnZm43b2Y5?= =?utf-8?B?Z3luU1dDTFZIWVdEVVVuTE1TQy9FWkJOVlJtbEFxYXNNM2d3S0NkcGhHNGNC?= =?utf-8?B?N3JaTmlTeUZ0NjdScEdPNnRwMloyVUZydkZqWWtTMWRzZzVvL1hVYW1PVlJ3?= =?utf-8?B?Zlo2RkZpZjVrNVN5M2RvMk1lUVFIM1BGay93Ni81cUoxMmpheXdnWTJTdkQr?= =?utf-8?B?UDNKZnlReTFVRWp4WGFPZWROenFkTjU0Rm5xZ1RXNWIwb3JoSnltMVhwSHJ3?= =?utf-8?B?QVZUUDRxS3hZWExZQ2YvbThRaENIdEF4Q3BZSXg5YzRoYlorWnZyZlNSMS9Y?= =?utf-8?B?dU03RnJPL1g0UXBrRjVoN3ZOMVFydGdwbSsyaENwckVqQy9rTjZQMGlsRERB?= =?utf-8?B?bzI1Q2hSQ2hUSUNvRkFmYklldUtrN2tUYno0OGg0cUFoamVIbDlaNkFNME1k?= =?utf-8?B?MzAybGZoK09yODhPbFVyY0hycVo0QWc4Uld5WWpQU2gwS01uNmltaDNqZFlv?= =?utf-8?B?clNJRy9tdWM2S3RjdjV5QmZWVHNSMFhiZ2RxRFFvUVVSOFQySUNmTUtTb1I4?= =?utf-8?B?Tmh6ZXdQT2tnaVpxZVFHaTVML0xCbDRQd0RsWklOMTNDYkVGQlFSc2ZLVzVw?= =?utf-8?B?SDUvaGk4aVdLTEJhM25GV0RVQmZUa1hQWGNQK0JXdVY2NVZIU08vQXU4WnlP?= =?utf-8?B?bGYzQWo0YTNmV2FMK2x4OUgxNXRJc0tHeStVMmZHZVlPOHVDS01uakJDWk54?= =?utf-8?B?RDRSMFZibTBxMHVBdFNLNXVkcVRDZ0duSk9IVzJnaHBXcjhFY0tPVTF2N2Z6?= =?utf-8?B?RmZPeGlQYi9yeXJOU01LalBNM0hlQmZQQUhjMGZGSkxMdTY1MGFaOTNyQ0Rx?= =?utf-8?B?SmhNaTNXV3NrZTJaUTIrbDZwcms0YkhBWkl6ZWlXV2hkUkpJTy9rNXJtUmJW?= =?utf-8?B?dkhvVG1QaVhYRTFTUjBVYy9idER3K3oxRXQrNVVJUCt2QmhHMkVCZUhDSDMw?= =?utf-8?B?dSs3bHk2VE9mRWRrdE5MMk0wUFBRQU1VRkxOM3BtRHhVNjF5YnQwY05PMkkz?= =?utf-8?B?NnI1ZGNrQ1FxWFNpMEJ4RkRKQXphNmZXaS9xNktNcE82WktwSGNueXJ6RzVv?= =?utf-8?B?WXg3M2FVbGNFYURuZVlQTHJ6RTQ3b3I2MzBrb3M0WjNDNHFtQVhJMjdQQTlq?= =?utf-8?B?ZzRpeitudUlqUmhBVnNMb05WbEhxeWpaZHdVeXh1MTdNNzIyVUdubmV1NUFa?= =?utf-8?B?YWVoZ2FWUW80UVVTdkRVckhqejE2MHR6YUtZejgzd0VValpucjJCM01CL0xN?= =?utf-8?B?bWZTV2hVL3FGcDd0RDZZU0UwVTg4cDhER3Zienl1TWFMT0hXZHhEUFk3TXVx?= =?utf-8?B?dEFTdkt3bmZTRnl5Uk5yUDRCcDEvVnduT0RXZHNMVHNWYk9wMk4vaVNYSkdG?= =?utf-8?B?elhFK1Z1Zk9lNXhtZ3hGTHlWMlZ1NUZSZTYrakxUTEo3OTU4SkpvTjg2dXV2?= =?utf-8?B?NWVQaXJBd2JnanppK21CaHk1SzRMVDRWc2t1cjByMXFjb3BkWHdrck04VUdL?= =?utf-8?B?bEhqaUFYOVF2Mnhxb0YycGhsOFRVc05DSlNjQ0NuUUF3QXA1TXlNWFc5aHV6?= =?utf-8?B?K0c5Nlo5SVhEL250VVNUS3Z4Tk44aSt0OWJwRGJ4enhpeVVjdnJra0M5N3JY?= =?utf-8?B?aEttQWhIbnJ3WDU2bEtaWTBJZHMyQ0VXWUZFV0JycFMyZDFHMVRwR3dkMjdq?= =?utf-8?B?L3djdWcrV1M5VXNERGV1L21RdTFZT2tJeGNITll6ZVdmM3JiM3hBVnY0SW5F?= =?utf-8?Q?8RjDhZ5GP6XIw2Fou3WIJZAEU?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa5b42dd-2535-4bf1-fc11-08db66add0e3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 16:48:12.5952 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CI1V/Rj8k7aDFyMo5hh7UB6O+A/rsimA2ft2XqJba/vi1CKPRoMCwtlH/X5iWf8R X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5425 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/6/2023 2:23 AM, Chaoyong He wrote: > A gentle ping on this series. > >> -----Original Message----- >> From: Chaoyong He >> Sent: Friday, May 12, 2023 9:51 AM >> To: dev@dpdk.org >> Cc: oss-drivers ; Niklas Soderlund >> >> Subject: RE: [PATCH v3 0/2] enhance bonding PMD to support the LACP >> negotiation >> >> A gentle ping on this series. >> >> There has a large patch series enhance the bonding PMD depends on this >> series is waiting for send out, it would be kind if this could be looked at early in >> this release cycle. >> >>> -----Original Message----- >>> From: Chaoyong He >>> Sent: Wednesday, March 1, 2023 10:49 AM >>> To: dev@dpdk.org >>> Cc: oss-drivers ; Niklas Soderlund >>> ; Chaoyong He >>> >>> Subject: [PATCH v3 0/2] enhance bonding PMD to support the LACP >>> negotiation >>> >>> App may not support the LACP negotiation in some cases. >>> This patch series solves this problem and add logics to testpmd app to >>> support the forward of bonding port in mode 4 with the disabled dedicated >> queue. >>> >>> --- >>> v2: >>> * Export symbol to solve the link problem. >>> v3: >>> * Add 'rte_experimental' flags to new add API. >>> * Move '#ifdef RTE_NET_BOND' into function. >>> * Replace 'slave' with 'member' in new add logic. >>> --- >>> >>> Long Wu (2): >>> net/bonding: add independent LACP sending function >>> app/testpmd: add support for bonding port's LACP negotiation >>> >>> app/test-pmd/config.c | 19 ++++++++ >>> app/test-pmd/parameters.c | 4 ++ >>> app/test-pmd/testpmd.c | 37 +++++++++++++++ >>> app/test-pmd/testpmd.h | 4 ++ >>> doc/guides/testpmd_app_ug/run_app.rst | 4 ++ >>> drivers/net/bonding/rte_eth_bond_8023ad.c | 58 >>> +++++++++++++++++++++++ >> drivers/net/bonding/rte_eth_bond_8023ad.h >>> | 21 ++++++++ >>> drivers/net/bonding/version.map | 8 ++++ >>> 8 files changed, 155 insertions(+) >>> >>> -- >>> 2.39.1 > Hi Chaoyong, Sorry for the delay, bonding maintainers are cc'ed. I can see this set adds new bonding specific APIs, instead can't application (in this case testpmd) call bonding Tx function explicitly to handle LACP packets? Or should we have a special forwarding mode for bonding, as we have one for ICMP echo?