From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 180B0A00BE; Sun, 26 Apr 2020 23:19:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC18A1C1C9; Sun, 26 Apr 2020 23:19:35 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 2C55A1C1C7 for <dev@dpdk.org>; Sun, 26 Apr 2020 23:19:34 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id BA6AA50E; Sun, 26 Apr 2020 17:19:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 26 Apr 2020 17:19:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= +SHut/XaeP3dYsQNNKgJDjW1Ot3DZQER1faZahZjp+I=; b=o/YgnY2jxfugDJ1U mmCxCcysx9ZRx2AgZ/CXrqVo2VBv89H8A3riOyS/Yxg6v9ezgFVjFvPN91I7vCtd rOAXC57ONxAdxzN3LkztyL+bM8soRMC2Lg9+71kxs1CrbR0QVChHlvHSfmt44w4S CiwTpctWeQbEEhej4IIDYxKvmcG7F1o5XtI3yWFc/5Gv7Px6ttxChF6vsqF98muB C/ayZh1fA7qsvn1I+n7lKY2kY7KGcG2PbMaN+6OrwGt8ONBQEQ2yAOVtJo20FBFq RIkgcYqjMElGeagq9F0rk7QWNyDcG7jFP16Po3B7ZEwc36gWtguj6pqZBnXTglqw uGh7rg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+SHut/XaeP3dYsQNNKgJDjW1Ot3DZQER1faZahZjp +I=; b=tO/MbJqc6Gdb72jD3QJLntTqCg1r6hoiDk6nlaC3OzzsxX5y6xOQ1Q2jr X09EMqRyAeYFG1pmVK4DjhYhBMl/fZYNNngmIDW8iGem6MU+JT6Ed5XYl517P4Jm iR4mCJ509bP1XYg3IN9AQExWVyETOcYVbQyfiA69riQtBQvkx2sLJghL7dyk06qK Z9ReWAxt98BM6VZgqdqh8SVoSBtiv68zHrqcW3pXsKsk5v+o0s6vZrkCkhZjvU65 v+c2aRgRgepFIce9q7JQGOI3quuFzhgIHWQvaIrw7jdoyLvF4A6zOdSMsDl7FBTh SHQgWBkgeWYZyXj336GxbCYj1IoUA== X-ME-Sender: <xms:4vqlXtCk7O0YyJtjAYLX6ldZFsLh0Xqij9f1XLlRmw-oY5NvPrRpow> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:4vqlXvwButrpd3fxHyEXB1BTBYE3G4fw71FFSySmZKLBJwJfPoqR5A> <xmx:4vqlXjkt9lyWm9ceq21zc6DATpHv_FzlBkHi8M8qEsIGE6MWd2Wwow> <xmx:4vqlXsGA_e4clea7yyLGL_BKJW9gpbEH_fyQbhpyiB7EUu9L1HuwcQ> <xmx:4_qlXhKkO3TcoyVKX2i0O9fq1AfvISOwRUyf9SQDnZ09seCNuhn5KA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CC5CB3280060; Sun, 26 Apr 2020 17:19:29 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Vamsi Attunuru <vattunuru@marvell.com> Cc: dev@dpdk.org, jerinjacobk@gmail.com, bruce.richardson@intel.com, david.marchand@redhat.com, grive@u256.net, jerinj@marvell.com, pbhagavatula@marvell.com, aostruszka@marvell.com Date: Sun, 26 Apr 2020 23:19:28 +0200 Message-ID: <4727111.097qLLJo0e@thomas> In-Reply-To: <20200405035243.8726-1-vattunuru@marvell.com> References: <20200403033013.4842-1-vattunuru@marvell.com> <20200405035243.8726-1-vattunuru@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] [v2 1/1] examples/l2fwd: add cmdline option for forwarding port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 05/04/2020 05:52, vattunuru@marvell.com: > From: Vamsi Attunuru <vattunuru@marvell.com> > > Current l2fwd application configures adjacent ports as destination > ports for forwarding the traffic which is a kind of static mapping > that can not be altered by the command line options. > > Patch adds a config option to pass the forwarding port pair mapping > as a command line parameter which allows the user to pass required > forwarding port mapping. > > If no config argument is specified, destination port map is not > changed and traffic gets forwarded with existing mapping. > > When port pair mapping is passed in config option, destination port map > is configured and traffic gets forwarded accordingly. > > Ex: ./l2fwd -c 0xff -- -p 0x3f --config="(0,3)(1,4)(2,5)" The option name "--config" is vague. Could we call it "--portmap", or something similar?