From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 682B07F39 for ; Wed, 5 Nov 2014 22:36:47 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id x12so1956717wgg.32 for ; Wed, 05 Nov 2014 13:46:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Kf1sJMgajwf6dQbdi2WUawJMTwTooQFSctkHSyALTgI=; b=PuxP5OxZs4lIT855GwJMQXYuYNDrVbO1O2/yBhyeZHPwrPLKzBwAMJy64x+R9BDzTS 93fYGMQIUCN6/iMn+pUxKueCopBktZaz+q43gHYekBknxjfQbEnTNUcC9Y8MnAG/RoN4 A71HjpjMbV7ZBbi07A0UJDP1leM51n219yt7tAlmAJrDT0eS/DhogbvRykEG0CCEiA44 cJ2lKOBrJNJ+/c83Dkt3dofUBQ9JFT7yvuGN55Khk09QgUVjfT0nxnvsVNInA+T1y/Hv pz8UIII8xrB+WeKZ5QBWrg+kS34U0kRrGmlP1UaJDEny9lc0LcNd9hB94o0QrbxnYW20 HUUg== X-Gm-Message-State: ALoCoQn6FaNlbvYti/C7iFDVQiaJumjeIZm4bsLSsWLI/QCZpLSn98ZO/MctBVHkztqwebxqCK8B X-Received: by 10.180.109.194 with SMTP id hu2mr9104791wib.24.1415223972025; Wed, 05 Nov 2014 13:46:12 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gw6sm5988248wib.8.2014.11.05.13.46.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Nov 2014 13:46:11 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 05 Nov 2014 22:45:52 +0100 Message-ID: <4733896.5T345UQtsj@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1415034068-22656-1-git-send-email-bruce.richardson@intel.com> References: <1415013076-30314-1-git-send-email-bruce.richardson@intel.com> <1415034068-22656-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix icc issue with mbuf initializer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2014 21:36:47 -0000 > When using Intel C++ compiler(icc) 14.0.1.106 or the older icc 13.x > version, the mbuf initializer variable was not getting configured > correctly, as the mb_def variable was not set correctly. This is due > to an issue with icc (DPD200249565 which already been fixed in > icc 14.0.2 and newer compiler release) where it incorrectly calculates > the field offsets with initializers when zero-sized fields > are used in a structure. > To work around this, the code in ixgbe_rxq_vec_setup does not setup the > fields using an initializer, but instead assigns the values individually > in code > NOTE: There is no performance impact to this change as the queue > setup functions are not data-plane APIs, but are only used at app > initialization. > > Signed-off-by: Bruce Richardson Acked-by: Thomas Monjalon Applied Thanks -- Thomas