From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
by dpdk.org (Postfix) with ESMTP id 816CF374F
for <dev@dpdk.org>; Tue, 22 Mar 2016 11:07:45 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id r129so84947434wmr.1
for <dev@dpdk.org>; Tue, 22 Mar 2016 03:07:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:organization:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=J9exxE0OTjZjCK6RUkNdnsGqXULYbIrBnHTjc/Xd2FQ=;
b=sVXkbFsZXD3v8YQYFs2KvsuAd+2kObbBBikx++2Cga9V0jAx2G38VVXMPIu4atE0xU
zOiqY62gyN1aYql3jrIJpO+qsf2EtkV3UBS1INSS2H7wiPxw578xsZQLbPVvGjXQMh1t
iZoCfNwYHsGuVpYGqc8PwE9ZbWi5CIBYD/n4WbwD2i1pPMCi2oVWt430OC2s10DRSPrf
AZ2tPKXLcn+pbfIr0yA2qKqaUwa8cgcnCikz2f1QHqoliQfvRBwh4Qhc2EYAqC5af5LK
28NN9feBb/54jJdQ0jyPtaImnmKRSKBObdezTU1dTqGsY7Zjka79+8EPIUdZRaiQlQ5m
ZaXQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding;
bh=J9exxE0OTjZjCK6RUkNdnsGqXULYbIrBnHTjc/Xd2FQ=;
b=huRZui/9D1gmNGatPYEAA0DCWV/4mjQcifmyxYT9mVBQ3H5g7jlwbSifdgr+dmQYsA
yu0vJpf2lt0A4m/QYb1HoJOmUpgflFxZ8Wu6iXOykIfl9VPSrcixi+jrwa0s9F0tN3d0
3WCItCH3PiL6HGCldeXNZqqh05XjJSvFO8o5onbLqwnM3+747XkTAFyasDR/5cLgfa7M
AGWD67UXmvPCMG7kvaOuq+2xLKmWyUOXvbuA56ITVCpTZOrIQA4g6qUS5VFzqiXouQJN
WztthiuJ0ekrGlCFTVNTtvSdyNQ5gd223Bz7uGe71BmGo1UVUeQ6vW3G265rBil/UgiT
Jw3Q==
X-Gm-Message-State: AD7BkJLU4iAhJ7b+2HFgLD9b4jtRBWiYA9Ak9LbOmbSBqa5NRxkRCyzcIbb3Q0l/pxH8WyBA
X-Received: by 10.28.228.137 with SMTP id b131mr18455634wmh.16.1458641265379;
Tue, 22 Mar 2016 03:07:45 -0700 (PDT)
Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91])
by smtp.gmail.com with ESMTPSA id z127sm16512621wme.5.2016.03.22.03.07.44
(version=TLSv1/SSLv3 cipher=OTHER);
Tue, 22 Mar 2016 03:07:44 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: dev@dpdk.org, maryam.tahhan@intel.com, olivier.matz@6wind.com
Date: Tue, 22 Mar 2016 11:06:05 +0100
Message-ID: <4735724.6EMEy1TxCb@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <2180400.M1OUCR6DC3@xps13>
References: <1457615010-87436-1-git-send-email-iryzhov@nfware.com>
<2180400.M1OUCR6DC3@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in
erroneous packets counter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Mar 2016 10:07:45 -0000
2016-03-17 17:40, Thomas Monjalon:
> CC Maryam and Olivier who had discussions about imissed and other stats:
> http://dpdk.org/ml/archives/dev/2015-August/022905.html
> http://dpdk.org/ml/archives/dev/2015-September/023351.html
> http://dpdk.org/ml/archives/dev/2015-September/023612.html
>
> 2016-03-10 16:03, Igor Ryzhov:
> > Comment for "ierrors" counter says that it counts erroneous received packets. But for some reason "imissed" counter is added to "ierrors" counter in most drivers. It is a mistake, because missed packets are obviously not received. This patch fixes it.
>
> According to this patch
> http://dpdk.org/browse/dpdk/commit/?id=70bdb186
> imissed was kept in ierrors because of backward compatibility.
> I'm OK to remove imissed from ierrors.
>
> Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc and badlen packets")
> Fixes: 6bfe648406b5 ("i40e: add Rx error statistics")
> Fixes: 856505d303f4 ("cxgbe: add port statistics")
>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied, thanks