DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
	"Jerin Jacob" <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
	"Ruifeng Wang" <ruifeng.wang@arm.com>,
	"Jan Viktorin" <viktorin@rehivetech.com>,
	"David Christensen" <drc@linux.vnet.ibm.com>,
	"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
	"David Marchand" <david.marchand@redhat.com>,
	"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	fengchengwen <fengchengwen@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build
Date: Wed, 08 Jun 2022 10:30:39 +0200	[thread overview]
Message-ID: <4742743.31r3eYUQgx@thomas> (raw)
In-Reply-To: <CALBAE1OjqpOpkCX7LZvDjXgSUHfjTtxuFytn2fisk0yTiLuxfA@mail.gmail.com>

08/06/2022 10:22, Jerin Jacob:
> On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> >
> > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > 02/06/2022 11:43, Jerin Jacob:
> > > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson
> > > > <bruce.richardson@intel.com> wrote:
> > > > >
> > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jerinj@marvell.com wrote:
> > > > > > From: Jerin Jacob <jerinj@marvell.com>
> > > > > >
> > > > > > By default, ccache is not used for cross build[1].
> > > > > > Update all cross files to use ccache if it is available
> > > > > > in build machine.
> > > > > >
> > > > > > [1]
> > > > > > https://mesonbuild.com/Machine-files.html
> > > > > >
> > > > > > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > > >
> > > > > Does this still work even if ccache is not available? That's not fully
> > > >
> > > > Yes.
> > > >
> > > > > clear from the docs, but it seems to be that if an array is passed the
> > > > > whole array is used as the command, rather than just one element of the
> > > > > array. That would imply that cross-builds now require ccache. Is that
> > > > > acceptable?
> > > >
> > > > I have removed ccache from the build machine still it works.
> > >
> > > I don't understand why it works without ccache.
> >
> > Meson is detecting valid compiler prefix. ccache is one of them.
> >
> > See
> > https://github.com/fabio-porcedda/meson/commit/44db495f5ece43645ca3994dc95895c76a828530
> > https://github.com/mesonbuild/meson/issues/1392
> 
> I hope there are no other review comments to fix it for this patch.
> Since it is improving the build time for cross-build. If there is no
> objection to this patch, Please merge it.

I've tested it now and I see a big blocker.
This patch is breaking the use of devtools/test-meson-builds.sh
so I cannot merge it as-is, sorry.




  reply	other threads:[~2022-06-08  8:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02  9:23 jerinj
2022-06-02  9:41 ` Bruce Richardson
2022-06-02  9:43   ` Jerin Jacob
2022-06-02 10:55     ` Thomas Monjalon
2022-06-02 12:00       ` Jerin Jacob
2022-06-02 13:33         ` Bruce Richardson
2022-06-08  8:22         ` Jerin Jacob
2022-06-08  8:30           ` Thomas Monjalon [this message]
2022-06-08 17:16             ` Jerin Jacob
2022-06-08 18:30               ` Stanisław Kardach
2022-06-08 17:13 ` [dpdk-dev] [PATCH v2] " jerinj
2022-06-09  1:44   ` fengchengwen
2022-06-10  7:30   ` Ruifeng Wang
2022-06-14 16:09     ` Thomas Monjalon
2022-06-14 16:01   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4742743.31r3eYUQgx@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=fengchengwen@huawei.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=ruifeng.wang@arm.com \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).