From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 2731B3239
 for <dev@dpdk.org>; Mon, 13 Jul 2015 17:12:23 +0200 (CEST)
Received: by wgmn9 with SMTP id n9so45568898wgm.0
 for <dev@dpdk.org>; Mon, 13 Jul 2015 08:12:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=EdlsA+1t66qNBCQjzEpWPy+hbAXZpX92AQyk/Bjkkoo=;
 b=FxCOG4gghho+/6AlHMPzMqlE38KahUwUW0daZxh7TYeoTbl2BpCxf16qb37NiAAkNj
 8AG+0KgkrRcblebCBJ7aJ963dGIbHqy5dfju72cttnl4nBdxbd0zQEhrGee4PC28wOQ5
 zSLNHQuMRhgRzedtnQNxrXAJGXhvfxKxv2M1S/VPihvEdCFZRu+NptesOhd5y0b5pU8A
 XJpA04tWM26PgKKU+27r3nW7TVF3Kl7mywM1343vhtU8U0oJmyErKt5LGopX9HU6sYrN
 Zh2lz9Pzjq/LpjmOYM+bVwF3NCfMI4GHICpmjr6n63TTnOsUqT3o3oM8PvLJz9fu2iiF
 boTw==
X-Gm-Message-State: ALoCoQmdj0cYG8+akMm9tMmg57yoL3F8HECj+2CIwlnjqEp95fYp8fc8RjanAhcd8nBnI68kh72O
X-Received: by 10.194.133.73 with SMTP id pa9mr66964116wjb.148.1436800342962; 
 Mon, 13 Jul 2015 08:12:22 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id c2sm29731957wjf.18.2015.07.13.08.12.21
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 13 Jul 2015 08:12:22 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
Date: Mon, 13 Jul 2015 17:11:09 +0200
Message-ID: <4742898.RcqEgbPpyt@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <3042915272161B4EB253DA4D77EB373A019FE98C@IRSMSX102.ger.corp.intel.com>
References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com>
 <2033219.3PlE3JM2PJ@xps13>
 <3042915272161B4EB253DA4D77EB373A019FE98C@IRSMSX102.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2015 15:12:23 -0000

2015-07-13 14:43, Kulasek, TomaszX:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-06-29 16:50, Tomasz Kulasek:
> > > This implementation allows to set and read RSS configuration for ring
> > > device, and is used to validate right values propagation over the
> > > slaves, in test units for dynamic RSS configuration for bonding.
> > >
> > > It have no impact on packet processing by ring device.
> > 
> > Adding some fake RSS to the ring PMD (in order to test bonding) is weird.
> > The ring PMD is not a driver for testing. Maybe that the null PMD would be
> > more appropriate.
> > By the way the current RSS implementation is really bound to Intel
> > devices.
> > Before applying it to more drivers, we have to make sure it is generic
> > enough. Maybe the RETA needs more abstraction.
> 
> This is not RSS implementation, but implementation of Dynamic RSS
> Configuration, already existing, and well defined in official documentation
> for single port.
> I don't know where you see bounding to Intel device.
> It's an implementation of official API.

What do you mean by "official"?
My concern is that the RSS API in ethdev comes from a time where DPDK was
Intel DPDK. I may be wrong but I think that other devices could need
something more generic and better defined.

> Anyway I will appreciate for any comment and opinion on that and
> clarification what means more RETA abstraction in context of official API.
> 
> I will check the possibility of moving it to the null pmd driver and will
> prepare new version for easier reviewing. Meantime I'm waiting for more
> opinions.

Exact, we need more opinions on this topic.