From: Thomas Monjalon <thomas@monjalon.net>
To: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/4] net/sfc: support regioned NIC DMA memory mapping type
Date: Sat, 06 Nov 2021 09:48:14 +0100 [thread overview]
Message-ID: <4744656.aQMOscmkOB@thomas> (raw)
In-Reply-To: <a3ec303f-4659-7941-4f01-cdeb771ea8e0@oktetlabs.ru>
06/11/2021 09:39, Andrew Rybchenko:
> On 11/5/21 11:14 PM, Thomas Monjalon wrote:
> > 05/11/2021 20:05, Ferruh Yigit:
> >> On 11/5/2021 8:33 AM, Andrew Rybchenko wrote:
> >>> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
> >>>
> >>> DMA on SN1022 SoC requires extra mapping of the memory via MCDI.
> >>> The mapping is expensive on datapath, so make it a build-time option.
> >>> Usage of build-time option is acceptable since it is required in
> >>> very specific case only.
> >>>
> >>
> >> Not really sure if it is acceptable.
> >>
> >> The change does not look trivial, it touches in many areas with ifdef blocks,
> >> cluttering the code.
> >>
> >> Even it is in datapath, it should be possible to have another datapath
> >> function that is only set for the specific device, even perhaps by automatically
> >> detecting the device, not needing a compile or runtime flag.
> >
> > Indeed compilation option is forbidden.
> > Function pointer is a better choice.
>
> Thanks for the feedback. Unfortunately expected.
Ideally the values in drivers/net/sfc/sfc_tweak.h should be configurable
at runtime with devargs options.
next prev parent reply other threads:[~2021-11-06 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 8:33 [dpdk-dev] [PATCH 0/4] net/sfc: support SN1022 SoC Andrew Rybchenko
2021-11-05 8:33 ` [dpdk-dev] [PATCH 1/4] common/sfc_efx: use correct define to control debug Andrew Rybchenko
2021-11-05 21:07 ` Ferruh Yigit
2021-11-05 8:33 ` [dpdk-dev] [PATCH 2/4] common/sfc_efx/base: support NIC DMA memory regions API Andrew Rybchenko
2021-11-05 8:33 ` [dpdk-dev] [PATCH 3/4] net/sfc: make adapter lock recursive Andrew Rybchenko
2021-11-05 8:33 ` [dpdk-dev] [PATCH 4/4] net/sfc: support regioned NIC DMA memory mapping type Andrew Rybchenko
2021-11-05 19:05 ` Ferruh Yigit
2021-11-05 20:14 ` Thomas Monjalon
2021-11-06 8:39 ` Andrew Rybchenko
2021-11-06 8:48 ` Thomas Monjalon [this message]
2021-11-17 7:05 ` [PATCH v2 0/2] net/sfc: support SN1022 SoC Andrew Rybchenko
2021-11-17 7:05 ` [PATCH v2 1/2] common/sfc_efx/base: support NIC DMA memory regions API Andrew Rybchenko
2021-11-17 7:05 ` [PATCH v2 2/2] net/sfc: support regioned NIC DMA memory mapping type Andrew Rybchenko
2021-11-17 11:44 ` [PATCH v2 0/2] net/sfc: support SN1022 SoC Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4744656.aQMOscmkOB@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=viacheslav.galaktionov@oktetlabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).