From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95015A0C4B; Sat, 6 Nov 2021 09:48:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C6804067C; Sat, 6 Nov 2021 09:48:24 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id E777640151 for <dev@dpdk.org>; Sat, 6 Nov 2021 09:48:20 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 9263E320091B; Sat, 6 Nov 2021 04:48:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 06 Nov 2021 04:48:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= NUqomqdXLMHjsg9KyH+g4m6WogqRXCgxHp7q3SoRpmo=; b=Yv8DJu0fF53k+ZDb S5Nf9UC4FBcNvOPYpE0uegac31JXEfQ+EWf0kbfn1FuTuCltt+iJasy12X8ug1EM Ba4ZJPCdsCk2OwRqLvsfYUsfzZ+9q//Bszngycri+WtqqX0A6buL+nazUdpI8fsL L9bVyb0ZKR48vUhfimDtIiqiTU0r/aOUvyN6uQwlY/9kM0r0u53k5C+pM74h9WCa 518RBhCYVeCF77LCoRgYIr5e9qJe2TEojnb25uPR7VdOxRRfc83Xps39fypLwzZx KKmvnJOXfeuElSIARtk+A5kDO+crVynWewrWtm3dFU0ioVgr8G6l8LhcS8rtTtyt SlNtcw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=NUqomqdXLMHjsg9KyH+g4m6WogqRXCgxHp7q3SoRp mo=; b=n3khGUshBDY1fDk5+46frPbZIUhZbtPpAYs17yUTgK1SMqR56YLKONDuV XM1jpo7Xpb464/f38NKwMXz7B9sWMDnsAtD4RxI10GbQ7Sew+/S6FusKrzADYl9P qYYnWZ3y+uTLhIjEQ3LZ+u/zdyjBBJv/69iu5aBK4F46fzMn6YYkgL7d1TMtneDx WAZhZFb4fqpBQBDohb+zkSMSJnkvsAQqCJFFC7wqvhr+wFlk6BWwN4de0ghczguC mLcmn1/APjfYeVTsfk3Nb7TSOYrf0ZesEPwvjerb1jMJK6WgXHZn7Y5+ScIbjiZl 9NVuM91dCXv3tbUYWqbnYJI76CFRg== X-ME-Sender: <xms:UEGGYaRBt854eQ1SW3zAMcsMGOkU10ZayRpZcDpIgb7OCBkRcrtGlg> <xme:UEGGYfxmJqz8OJGJcrQunG88YD7YPdHEZ-Mq_3xdvW_yL4Hkhjjl2m9fNb3jDD-ux frF84U76dFVxLCBdQ> X-ME-Received: <xmr:UEGGYX2ZkDwLPcAUcmzqczv9pG9IH5uWJrzIYzK7S4p3PQ-Pmo2h5X4Sy-YysWIO_zCHuj4tuP73JouIcDj3AWvvVw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdejgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:UEGGYWAUl91ka5aHXHTgMotC2wOmXw7MHKtQK-tJIdvDZc8Kr0ElqA> <xmx:UEGGYTixZVo6fKX7Na2Xr0lvlkDlX2Odo_smlSZdWXe-8g0fb8-0Gg> <xmx:UEGGYSphC0vPfy6Vhk2Pd9f9kE6BYcbtsqCNWXGQPy8ppYz-lKe8Iw> <xmx:UUGGYTdgvdcwq2JtEg2f-x4RkEM0KXfE6XmkUWRnVM64P8mOE_N4tQ> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Nov 2021 04:48:16 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Ivan Malov <ivan.malov@oktetlabs.ru>, David Marchand <david.marchand@redhat.com>, dev@dpdk.org Date: Sat, 06 Nov 2021 09:48:14 +0100 Message-ID: <4744656.aQMOscmkOB@thomas> In-Reply-To: <a3ec303f-4659-7941-4f01-cdeb771ea8e0@oktetlabs.ru> References: <20211105083333.1960017-1-andrew.rybchenko@oktetlabs.ru> <2688687.HSkE7oWr40@thomas> <a3ec303f-4659-7941-4f01-cdeb771ea8e0@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/4] net/sfc: support regioned NIC DMA memory mapping type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 06/11/2021 09:39, Andrew Rybchenko: > On 11/5/21 11:14 PM, Thomas Monjalon wrote: > > 05/11/2021 20:05, Ferruh Yigit: > >> On 11/5/2021 8:33 AM, Andrew Rybchenko wrote: > >>> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru> > >>> > >>> DMA on SN1022 SoC requires extra mapping of the memory via MCDI. > >>> The mapping is expensive on datapath, so make it a build-time option. > >>> Usage of build-time option is acceptable since it is required in > >>> very specific case only. > >>> > >> > >> Not really sure if it is acceptable. > >> > >> The change does not look trivial, it touches in many areas with ifdef blocks, > >> cluttering the code. > >> > >> Even it is in datapath, it should be possible to have another datapath > >> function that is only set for the specific device, even perhaps by automatically > >> detecting the device, not needing a compile or runtime flag. > > > > Indeed compilation option is forbidden. > > Function pointer is a better choice. > > Thanks for the feedback. Unfortunately expected. Ideally the values in drivers/net/sfc/sfc_tweak.h should be configurable at runtime with devargs options.