From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8CE8A04B5; Fri, 11 Sep 2020 01:35:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D02B1B9B7; Fri, 11 Sep 2020 01:35:19 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 85D3E1DB8 for ; Fri, 11 Sep 2020 01:35:17 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 0659B5803A0; Thu, 10 Sep 2020 19:35:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 10 Sep 2020 19:35:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= oPu+7Gs6v7QJOz+v50oaEzKdODlWYD5xe19AC0UFxyA=; b=Wi2FbITxffNzVuZO mrxP47q+88uKVMRwIlJ5v3DNVETWGwLPLxSAaqb4r5HBHS2LS87kO+afJLNKylPM GCq6Cj/lIPuF8wn9m2qVyn6E1PKAXNzNXiPBwqQMkZwKpliYOygvOz+66NheR2uN URhv1socJfwEJgOuHrAtmVWzwyfoSS9IBYehBDjOsdAI7omrA4eKHF7dvwKIFPoM RXXNSJAgkq8rUKJuTbI4OfGRA52CclcYtQ9/bX4I7266P03vMdl/FY4w1BRrUqT5 h8qzeWORuugZ8MHmtoxcl7ihN4SJvS/J+RzwQ6D4rArfbYMQsHEmrK9XtjGT/hzz yslmdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=oPu+7Gs6v7QJOz+v50oaEzKdODlWYD5xe19AC0UFx yA=; b=I00IejdkQWSfJ9GtnPpKKr4OIcRnXXQzoQWL9AMeLJ+Gbdw7MoNEZJwW8 quRMi+8r6mtSrzpZVp+dbRIiPwpAF04E5Y7iY+/Uc5d+8voPvv33J3JpsgT9cZn/ xQuDmN+PKll7LZMzl7H27HirDjxhW/f6PpS0hE402FaEV5rWPGrqAO/xZkdt3bc2 p5V67kQ28Yt00f0RaCnJHc8S3ZsQD4O+qBbDTeH2UH+/ua2MYrrWSzu/BpoQATQM TTjqvUs38ZDVrd1ttiu5j/4PqFKBTwBLp2YAJMsEwcxK1TAdUVEBdWGBIoRfOU+3 I3j1Ah8em0uenYif/hClHGcBLWE+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehkedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EBA433280065; Thu, 10 Sep 2020 19:35:12 -0400 (EDT) From: Thomas Monjalon To: Fady Bader Cc: dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, kevin.laatz@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, ciara.power@intel.com, navasile@linux.microsoft.com Date: Fri, 11 Sep 2020 01:35:11 +0200 Message-ID: <4746807.uhkucg70k9@thomas> In-Reply-To: <20200811062424.14248-5-fady@mellanox.com> References: <20200625133038.25180-1-fady@mellanox.com> <20200811062424.14248-1-fady@mellanox.com> <20200811062424.14248-5-fady@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 4/5] telemetry: implement empty stubs for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > --- a/lib/librte_telemetry/rte_telemetry.h > +++ b/lib/librte_telemetry/rte_telemetry.h > +#ifdef RTE_EXEC_ENV_WINDOWS > +#include > +#endif I don't think sched.h is required only for Windows. It happens to be already included in Linux build, but there is no good reason for the #ifdef above. I'll drop the #ifdef. In the rest of the patch, we can avoid duplicating some includes and keep register functions untouched.