From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F1DFA0548; Wed, 19 May 2021 22:36:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8971F40041; Wed, 19 May 2021 22:36:01 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 7FB3F4003F for <dev@dpdk.org>; Wed, 19 May 2021 22:36:00 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AD6765C003F; Wed, 19 May 2021 16:35:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 19 May 2021 16:35:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= K3bAw8xoQx+EAY0BUVLwyAVXAxf2EV3gv0BVCikR6/s=; b=rtppXE0I1Zm/LtlF RaqCF1qyvXPo/twvl9He7z1mKOff0zAJGkdX/pT40w0VBWhGLBIBO8Equql8JUX5 qJh7/dBGwXeOrgoEsoQfNLMs2pUWe/P9GWK9+RDy/19MIWkHm4OUOVumVPP2bzag /BN6I5bT00v5NsYW8FlXc4qf175muoQ8myfgQ6z0uU5LWOdUOT4m3cwItcFeJf7s EIMz8KNwMnSptgegj8+L0qFqfokCAzCCjKVJm4RS2U+qB0zdIXfI269u18pLHUrt 3fymDqg7QEk/NJCnGW35Tdo8msDdAINUn7v+a5EFXkV7cAoqt0NItTV76uZCiXvy S7wPKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=K3bAw8xoQx+EAY0BUVLwyAVXAxf2EV3gv0BVCikR6 /s=; b=iNqjlysFhu9UQxpy1Lrh1WM7GrUkxUUXOXOrdQe1Tbhgz93a8jSdPNOqQ ADQRKg1VoEOP6ZZdFRxZ+AtQFNjafoRmCFn/eAwHyQjs89KF/cO13kGOYRuK+qiw Pm6isMLK0GJKD6G1BB5dyfOpTBtfVt/4O8ZhAPghJ0gfIGraiYZzCO4WfiWAYqXA xPcX71q0qS93FRi63+OuVJtwGWbdOOb/vGYTbVF1ZDgW44f7ZijPwVW/NGCIPiGh DAVPYM2cHZk+5BVa+z/vyXx7mFYLv68p4B5IgpLeZOAFxbsmjYYk196tGv+QvmnQ D5zoI+2b8CFNelrqVOq3oPqU/KCZg== X-ME-Sender: <xms:rnalYJHTtRikM11MnIzSwJQnMkMfmCFz9hCHK0EIysyB7ylLjxjtAw> <xme:rnalYOV2IfEwxCQAuY5xU7F1SeckYKkpKTpH48UeBe_EsHi3OQAlGmnHiH8IqAE0h YWXJ3SSq3Z8g7egVg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeiledgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: <xmx:rnalYLK1jeS_Co_a3zr4e_TKxR_vWu3WpC9vatPtIAl9gdk-o4Agqw> <xmx:rnalYPG0j8Lgqwhu8pPI5qz1JuuGk0ydSiO3-mC4w0pGfws2Vop6gQ> <xmx:rnalYPVUMPzRc32fgNpeNlFB-ODMT0tPREMv_dUcX-VXD4MBlscjTw> <xmx:r3alYKRdfmhQLACwl5pbfsY_PN1Lrd_E1lrY_N_fdxCqqiw2OSDxEg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 May 2021 16:35:57 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: asafp@nvidia.com, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Ori Kam <orika@nvidia.com>, Ferruh Yigit <ferruh.yigit@intel.com> Date: Wed, 19 May 2021 22:35:55 +0200 Message-ID: <4757290.T23uDqQqg0@thomas> In-Reply-To: <f02f8d63-96c4-fae3-2bc0-019489a01932@intel.com> References: <20210519162725.2179226-1-thomas@monjalon.net> <20210519173316.2364189-1-thomas@monjalon.net> <f02f8d63-96c4-fae3-2bc0-019489a01932@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix comments of packet integrity flow item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 19/05/2021 19:47, Ferruh Yigit: > On 5/19/2021 6:33 PM, Thomas Monjalon wrote: > > The Doxygen comments are placed before the related lines, > > but the markers were /**< instead of /** > > > > The struct rte_flow_item_integrity did not appear in Doxygen output > > because there was no general comment for the struct. > > > > Fixes: b10a421a1f3b ("ethdev: add packet integrity check flow rules") > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied