From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EA4B5A0543;
	Thu,  7 Jul 2022 14:42:57 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8F9E7406B4;
	Thu,  7 Jul 2022 14:42:57 +0200 (CEST)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by mails.dpdk.org (Postfix) with ESMTP id 751754069D
 for <dev@dpdk.org>; Thu,  7 Jul 2022 14:42:55 +0200 (CEST)
Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Ldwx50QLmz1L8xQ;
 Thu,  7 Jul 2022 20:40:25 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (7.193.23.242) by
 dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.24; Thu, 7 Jul 2022 20:42:51 +0800
Received: from [10.67.103.231] (10.67.103.231) by
 kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.24; Thu, 7 Jul 2022 20:42:51 +0800
Message-ID: <4757b6d3-1796-05c3-1324-39c4e541085b@huawei.com>
Date: Thu, 7 Jul 2022 20:42:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] app/testpmd: fix display types failure when query RSS rule
To: Ferruh Yigit <ferruh.yigit@xilinx.com>, <andrew.rybchenko@oktetlabs.ru>
CC: <dev@dpdk.org>, <thomas@monjalon.net>, <weiyuanx.li@intel.com>,
 <huangdaode@huawei.com>, <liudongdong3@huawei.com>
References: <20220707105044.10567-1-lihuisong@huawei.com>
 <773cea2b-68e3-ac28-b6cc-dd57377144b1@xilinx.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <773cea2b-68e3-ac28-b6cc-dd57377144b1@xilinx.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
 kwepemm600004.china.huawei.com (7.193.23.242)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


在 2022/7/7 20:22, Ferruh Yigit 写道:
> On 7/7/2022 11:50 AM, Huisong Li wrote:
>> Now testpmd fails to display types when query RSS rule. The failure is
>> because the '\n' character is missing at the end of the function
>> 'rss_config_display()'.
>>
>
> Bugzilla ID: 1048
>
>> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>>   app/test-pmd/config.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>> index 608bec9796..bcb6d42da3 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss 
>> *rss_conf)
>>           return;
>>       }
>>       rss_types_display(rss_conf->types, 
>> TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
>> +    printf("\n");
>
>
> Thanks Huisong for the fix.
>
> What do you think to have '\n' in the 'rss_types_display()' function 
> and update 'port_rss_hash_conf_show()' usage?
>
> And can do same change for 'rss_offload_types_display()', having last 
> '\n' in the function.
For the quering RSS rule command, the 'rss_types_display()' is the last 
function
of 'port_flow_query(). But it is not the case in other RSS commands, and 
all have
''printf("\n")'' after 'xxx_types_display()'.
>
>>   }
>>     static struct port_indirect_action *
>
> .