From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0928A00C5; Thu, 15 Sep 2022 11:42:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 645EA4021D; Thu, 15 Sep 2022 11:42:44 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id D6B6C40156 for ; Thu, 15 Sep 2022 11:42:42 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 115) id 67C427D; Thu, 15 Sep 2022 12:42:42 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD autolearn=no autolearn_force=no version=3.4.6 Received: from bree.oktetlabs.ru (bree.oktetlabs.ru [192.168.34.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPS id DCF9274; Thu, 15 Sep 2022 12:42:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru DCF9274 Authentication-Results: shelob.oktetlabs.ru/DCF9274; dkim=none; dkim-atps=neutral Date: Thu, 15 Sep 2022 12:42:41 +0300 (MSK) From: Ivan Malov To: Thomas Monjalon cc: Rongwei Liu , Matan Azrad , Slava Ovsiienko , Ori Kam , Aman Singh , Yuying Zhang , Andrew Rybchenko , "dev@dpdk.org" , Raslan Darawsheh Subject: Re: [PATCH v1] ethdev: add direction info when creating the transfer table In-Reply-To: <2472631.4XsnlVU6TS@thomas> Message-ID: <476338da-52c2-442c-b539-c6ab31d4538c@oktetlabs.ru> References: <20220907024020.2474860-1-rongweil@nvidia.com> <2472631.4XsnlVU6TS@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, On Thu, 15 Sep 2022, Thomas Monjalon wrote: > 15/09/2022 09:47, Ivan Malov: >> As I said, match criteria belong in flow pattern. I recognise the >> importance of the problem that you're looking to solve. It's very >> good that you care to address it, but what this patch tries to do >> is to add more match criteria in the form of new attributes with >> rather questionable names... There's a room for improvement. >> >> When I say that new features should not confuse readers, I mean >> a very basic thing: readers know that match criteria all sit >> in the pattern. And they refer to the pattern item enum in >> the code and in documentation to learn about criteria, >> while "struct rte_flow_attr" is an unusual place from >> which to learn about match criteria. >> >>> We should get a conclusion and reflect in the commit changes&logs, and it's easy for others to absorb. >> >> Yes, but before we get to that, perhaps it pays to hear >> more feedback from other reviewers. Thomas? Ori? Andrew? > > Sorry I did not read all. OK, I will attempt to summarise it to some extent in my next response to Rongwei which is to follow. > I think the main question is about the use of attributes. > I refer to this commit of Ivan last year which was agreed: > > ethdev: deprecate direction attributes in transfer flows > > Attributes "ingress" and "egress" can only apply unambiguosly > to non-"transfer" flows. In "transfer" flows, the standpoint > is effectively shifted to the embedded switch. There can be > many different endpoints connected to the switch, so the > use of "ingress" / "egress" does not shed light on which > endpoints precisely can be considered as traffic sources. > > Add relevant deprecation notices and suggest the use of precise > traffic source items (PORT_REPRESENTOR and REPRESENTED_PORT). > > Signed-off-by: Ivan Malov > Acked-by: Ori Kam > Acked-by: Andrew Rybchenko > Acked-by: Viacheslav Ovsiienko > > So +1 for using only pattern items as matching criteria. Thank you. > > > Ivan