Re: 21.11.1 patches review and test

[Kevin Traynor <ktraynor@redhat.com>]

On 13/04/2022 08:26, Christian Ehrhardt wrote:
> On Mon, Apr 11, 2022 at 8:58 AM Christian Ehrhardt
> <christian.ehrhardt@canonical.com> wrote:
>>
>> On Fri, Apr 1, 2022 at 12:22 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>>
>>> Hi all,
>>>
>>> Here is a list of patches targeted for stable release 21.11.1.
>>
>> Hi Kevin,
>> this breaks on me at build time due to symbol changes.
>> It is a wild mix of Base->Internal/Experimental, a few new symbols,
>> and even just removed ones (in gpu which is experimental, but still
>> would that need a minor soname bump?).
>> They might be intentional, but it felt too much to me without at least
>> discussing it.
>> Could you have a look if you think that they are all intentional, save
>> and correct for an LTS release?
> 
> ping ^^ ?
> 

Thanks Christian, will look at this this morning.

Kevin.

>> dpkg-gensymbols: warning: some new symbols appeared in the symbols
>> file: see diff output below
>> dpkg-gensymbols: warning: debian/librte-common-cnxk22/DEBIAN/symbols
>> doesn't match completely debian/librte-common-cnxk22.symbols
>> --- debian/librte-common-cnxk22.symbols
>> (librte-common-cnxk22_21.11.1~rc1-0ubuntu1~jammyppa2_amd64)
>> +++ dpkg-gensymbolsUuRb8d 2022-04-11 06:46:22.276766813 +0000
>> @@ -197,6 +197,7 @@
>>    roc_nix_ptp_clock_read@INTERNAL 21.08
>>    roc_nix_ptp_info_cb_register@INTERNAL 21.08
>>    roc_nix_ptp_info_cb_unregister@INTERNAL 21.08
>> + roc_nix_ptp_is_enable@INTERNAL 21.11.1~rc1-0ubuntu1~jammyppa2
>>    roc_nix_ptp_rx_ena_dis@INTERNAL 21.08
>>    roc_nix_ptp_sync_time_adjust@INTERNAL 21.08
>>    roc_nix_ptp_tx_ena_dis@INTERNAL 21.08
>>
>> dpkg-gensymbols: warning: some new symbols appeared in the symbols
>> file: see diff output below
>> dpkg-gensymbols: warning: debian/librte-ethdev22/DEBIAN/symbols
>> doesn't match completely debian/librte-ethdev22.symbols
>> --- debian/librte-ethdev22.symbols
>> (librte-ethdev22_21.11.1~rc1-0ubuntu1~jammyppa2_amd64)
>> +++ dpkg-gensymbolskEnokB 2022-04-11 06:46:25.252795157 +0000
>> @@ -37,6 +37,7 @@
>>    rte_eth_dev_flow_ctrl_get@DPDK_22 21.11
>>    rte_eth_dev_flow_ctrl_set@DPDK_22 21.11
>>    rte_eth_dev_fw_version_get@DPDK_22 21.11
>> + rte_eth_dev_get_by_name@INTERNAL 21.11.1~rc1-0ubuntu1~jammyppa2
>>    rte_eth_dev_get_dcb_info@DPDK_22 21.11
>>    rte_eth_dev_get_eeprom@DPDK_22 21.11
>>    rte_eth_dev_get_eeprom_length@DPDK_22 21.11
>>
>> dpkg-gensymbols: warning: some new symbols appeared in the symbols
>> file: see diff output below
>> dpkg-gensymbols: error: some symbols or patterns disappeared in the
>> symbols file: see diff output below
>> dpkg-gensymbols: warning: debian/librte-regexdev22/DEBIAN/symbols
>> doesn't match completely debian/librte-regexdev22.symbols
>> --- debian/librte-regexdev22.symbols
>> (librte-regexdev22_21.11.1~rc1-0ubuntu1~jammyppa2_amd64)
>> +++ dpkg-gensymbolsPD0Ygo 2022-04-11 06:46:33.368872490 +0000
>> @@ -1,6 +1,8 @@
>>   librte_regexdev.so.22 librte-regexdev22 #MINVER#
>>    EXPERIMENTAL@EXPERIMENTAL 20.11
>> - rte_regex_devices@Base 20.11
>> + INTERNAL@INTERNAL 21.11.1~rc1-0ubuntu1~jammyppa2
>> + rte_regex_devices@EXPERIMENTAL 21.11.1~rc1-0ubuntu1~jammyppa2
>>    rte_regexdev_attr_get@EXPERIMENTAL 20.11
>>    rte_regexdev_attr_set@EXPERIMENTAL 20.11
>>    rte_regexdev_close@EXPERIMENTAL 20.11
>> @@ -8,12 +10,16 @@
>>    rte_regexdev_count@EXPERIMENTAL 20.11
>>    rte_regexdev_dump@EXPERIMENTAL 20.11
>>    rte_regexdev_get_dev_id@EXPERIMENTAL 20.11
>> - rte_regexdev_get_device_by_name@Base 20.11
>> + rte_regexdev_get_device_by_name@INTERNAL 21.11.1~rc1-0ubuntu1~jammyppa2
>>    rte_regexdev_info_get@EXPERIMENTAL 20.11
>> - rte_regexdev_is_valid_dev@Base 20.11
>> - rte_regexdev_logtype@Base 20.11
>> + rte_regexdev_is_valid_dev@EXPERIMENTAL 21.11.1~rc1-0ubuntu1~jammyppa2
>> + rte_regexdev_logtype@EXPERIMENTAL 21.11.1~rc1-0ubuntu1~jammyppa2
>>    rte_regexdev_queue_pair_setup@EXPERIMENTAL 20.11
>> - rte_regexdev_register@Base 20.11
>> + rte_regexdev_register@INTERNAL 21.11.1~rc1-0ubuntu1~jammyppa2
>>    rte_regexdev_rule_db_compile_activate@EXPERIMENTAL 20.11
>>    rte_regexdev_rule_db_export@EXPERIMENTAL 20.11
>>    rte_regexdev_rule_db_import@EXPERIMENTAL 20.11
>> @@ -21,7 +27,8 @@
>>    rte_regexdev_selftest@EXPERIMENTAL 20.11
>>    rte_regexdev_start@EXPERIMENTAL 20.11
>>    rte_regexdev_stop@EXPERIMENTAL 20.11
>> - rte_regexdev_unregister@Base 20.11
>> + rte_regexdev_unregister@INTERNAL 21.11.1~rc1-0ubuntu1~jammyppa2
>>    rte_regexdev_xstats_by_name_get@EXPERIMENTAL 20.11
>>    rte_regexdev_xstats_get@EXPERIMENTAL 20.11
>>    rte_regexdev_xstats_names_get@EXPERIMENTAL 20.11
>>
>> dpkg-gensymbols: error: some symbols or patterns disappeared in the
>> symbols file: see diff output below
>> dpkg-gensymbols: warning: debian/librte-gpudev22/DEBIAN/symbols
>> doesn't match completely debian/librte-gpudev22.symbols
>> --- debian/librte-gpudev22.symbols
>> (librte-gpudev22_21.11.1~rc1-0ubuntu1~jammyppa2_amd64)
>> +++ dpkg-gensymbols4qkXdt 2022-04-11 06:46:34.552883776 +0000
>> @@ -1,7 +1,7 @@
>>   librte_gpudev.so.22 librte-gpudev22 #MINVER#
>>    EXPERIMENTAL@EXPERIMENTAL 21.11
>>    INTERNAL@INTERNAL 21.11
>> - gpu_logtype@Base 21.11
>>    rte_gpu_add_child@EXPERIMENTAL 21.11
>>    rte_gpu_allocate@INTERNAL 21.11
>>    rte_gpu_attach@INTERNAL 21.11
>>
>>
>> Full log:
>> https://launchpadlibrarian.net/596047842/buildlog_ubuntu-jammy-amd64.dpdk_21.11.1~rc1-0ubuntu1~jammyppa2_BUILDING.txt.gz
>>
>>> Please try and complete validation by April 13th.
>>>
>>> Please help with testing and validation of your use cases and report
>>> any issues/results with reply-all to this mail. For the final release
>>> the fixes and reported validations will be added to the release notes.
>>>
>>> A release candidate tarball can be found at:
>>>
>>>      https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.1-rc1
>>>
>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>      https://dpdk.org/browse/dpdk-stable/
>>>
>>> Thanks.
>>>
>>> Kevin
>>>