From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m13-124.163.com (m13-124.163.com [220.181.13.124]) by dpdk.org (Postfix) with ESMTP id 508D9E5D for ; Sat, 16 Dec 2017 15:35:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=oc91M Hk4OoSM5WT4OpVTyJmaAdMB6WCe/LVldg6+Ct8=; b=kQIGtZC1IrYbRnQror7q8 0FuDQQqIRAd6WNn0RgZZb/1Grt5RLlx5to4c47ieG8AOdx9CoHdae14PddqHEZOs KPP756i9+tY5ZtnO6lsuu+TZX0YqG9yZaKuvFjEao0p400nJPCNYcYLRZ4exBfLd 4lfGbFl5nJguUHLAqPJjP8= Received: from liupan1234$163.com ( [106.2.231.96] ) by ajax-webmail-wmsvr124 (Coremail) ; Sat, 16 Dec 2017 22:35:13 +0800 (CST) X-Originating-IP: [106.2.231.96] Date: Sat, 16 Dec 2017 22:35:13 +0800 (CST) From: liupan1234 To: "dev@dpdk.org" X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2017 www.mailtech.cn 163com X-CM-CTRLDATA: kU9EkmZvb3Rlcl9odG09NjU3OjU2 MIME-Version: 1.0 Message-ID: <477552f3.52bb.1605fc01ca2.Coremail.liupan1234@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: fMGowADn1oAiLzVa3uAlAA--.52870W X-CM-SenderInfo: xolx1tjqrsjki6rwjhhfrp/1tbiEQKwvFWBdWRpsQAAsC X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] how to iterator all malloc_elem of a malloc_heap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Dec 2017 14:35:19 -0000 SGkgQWxsLAoKCnN0cnVjdCBtYWxsb2NfaGVhcCB7CiAgICAgICAgcnRlX3NwaW5sb2NrX3QgbG9j azsKICAgICAgICBMSVNUX0hFQUQoLCBtYWxsb2NfZWxlbSkgZnJlZV9oZWFkW1JURV9IRUFQX05V TV9GUkVFTElTVFNdOwogICAgICAgIHVuc2lnbmVkIGFsbG9jX2NvdW50OwogICAgICAgIHNpemVf dCB0b3RhbF9zaXplOwp9IF9fcnRlX2NhY2hlX2FsaWduZWQ7CgoKSSBmb3VuZCB0aGVyZSBhcmUg ZnJlZSBsaXN0IG9mIG9uZSBtYWxsb2MgaGVhcCwgaXQgdGhlcmUgYW55IHdheSB0byBnZXQgdXNl ZCBsaXN0PyBJIHdhbnQgdG8gZ2V0IGl0IHRvIGRvIHNvbWUgc3RhdGlzdGljLgoKClRoYW5rcwpQ YW4= >From olivier.matz@6wind.com Sat Dec 16 18:25:15 2017 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id E10A69FE; Sat, 16 Dec 2017 18:25:15 +0100 (CET) Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1eQGJ8-0004GW-M0; Sat, 16 Dec 2017 18:31:32 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Sat, 16 Dec 2017 18:25:04 +0100 Date: Sat, 16 Dec 2017 18:25:04 +0100 From: Olivier MATZ To: Ferruh Yigit Cc: dev@dpdk.org, Ajit Khaparde , stable@dpdk.org Message-ID: <20171216172502.kd2ngzl6moqfzhv5@platinum> References: <20171214142825.28176-1-olivier.matz@6wind.com> <5f0b6b54-9813-b03f-47ed-c10e49cb3d44@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f0b6b54-9813-b03f-47ed-c10e49cb3d44@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/bnxt: fix headroom initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Dec 2017 17:25:16 -0000 Hi Ferruh, On Fri, Dec 15, 2017 at 06:30:58PM -0800, Ferruh Yigit wrote: > On 12/14/2017 6:28 AM, Olivier Matz wrote: > > When allocating a new mbuf for Rx, the value of m->data_off should not > > be reset to its default value (RTE_PKTMBUF_HEADROOM), instead of reusing > > the previous undefined value, which could cause the packet to have a too > > small or too high headroom. > > > > Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") > > Cc: stable@dpdk.org > > > > Signed-off-by: Olivier Matz > > --- > > drivers/net/bnxt/bnxt_rxr.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > > index 188df362e..3fff4d437 100644 > > --- a/drivers/net/bnxt/bnxt_rxr.c > > +++ b/drivers/net/bnxt/bnxt_rxr.c > > @@ -75,7 +75,7 @@ static inline int bnxt_alloc_rx_data(struct bnxt_rx_queue *rxq, > > > > rx_buf->mbuf = data; > > > > - rxbd->addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR(rx_buf->mbuf)); > > + rxbd->addr = rte_cpu_to_le_64(rte_mbuf_data_dma_addr_default(data)); > > Hi Olivier, > > Using deprecated rte_mbuf_data_dma_addr_default() breaks build for this commit. > > What do you think using directly rte_mbuf_data_iova_default() in this patch? No problem. It was initially split in 2 patches to ease the backport for stable versions.