Re: [dpdk-dev] [PATCH v5] devtools: add test script for meson builds

[Thomas Monjalon <thomas@monjalon.net>]

29/05/2018 16:58, Richardson, Bruce:
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Tuesday, May 29, 2018 3:43 PM
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>
> > Subject: [PATCH v5] devtools: add test script for meson builds
> > 
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > To simplify testing with the meson and ninja builds, we can add a script
> > to set up and do multiple builds. Currently this script sets up:
> > 
> > * clang and gcc builds
> > * builds using static and shared linkage for binaries (libs are always
> >    built as both)
> > * a build using the lowest instruction-set level for x86 (-march=nehalem)
> > * cross-builds for each cross-file listed in config/arm
> > 
> > Each build is configured in a directory ending in *-build, and then for
> > the build stage, we just call ninja in each directory in turn. [i.e. we
> > assume every directory starting with "build-" is a meson build, which is
> > probably an ok assumption].
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > v2: it is a rework with 3 major changes
> >    - automatically stop on error thanks to -e
> >    - directory name starts with "build-"
> >    - optionally load a config file to get some environment variables
> > v3:
> >    - remove forcing "cd": use current directory
> >    - remove CROSS: use hard-written aarch64-linux-gnu-gcc
> >    - remove config load in script start
> > v4:
> >    - remove config file loading (will be improved and sent later)
> >    - the v4 is closer to what Bruce sent as v1
> > v5:
> >    - specify srcdir to build from anywhere
> >    - use ccache for ARM
> > ---
> >  MAINTAINERS                   |  1 +
> >  devtools/test-meson-builds.sh | 46
> > +++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 47 insertions(+)
> >  create mode 100755 devtools/test-meson-builds.sh
> 
> LGTM

Applied, thanks