DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ravi Kerur <rkerur@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c
Date: Thu, 16 Apr 2015 10:24:57 +0200	[thread overview]
Message-ID: <4780798.Fhdhc6hoDZ@xps13> (raw)
In-Reply-To: <1428608412-31191-3-git-send-email-rkerur@gmail.com>

Hi Ravi,

I think this patch is too complex and move too many different things:
- sysfs
- mem_cfg
- proc_type
- application_usage
Please split them up.

I'm not sure the classification in eal_common_runtime.c and eal_common_system.c
new file is clear.

2015-04-09 12:40, Ravi Kerur:
> +	mem_config = (struct rte_mem_config *) mmap(NULL, sizeof(*mem_config),

Why this cast is needed?

  reply	other threads:[~2015-04-16  8:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 19:38 [dpdk-dev] [PATCH v5 0/8] Move common functions in EAL Ravi Kerur
2015-04-09 19:40 ` Ravi Kerur
2015-04-09 19:40   ` [dpdk-dev] [PATCH v5 1/8] Move common functions in eal_thread.c Ravi Kerur
2015-04-14 13:59     ` Thomas Monjalon
2015-04-14 21:35       ` Ravi Kerur
2015-04-16 22:19         ` Ravi Kerur
2015-04-09 19:40   ` [dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c Ravi Kerur
2015-04-16  8:24     ` Thomas Monjalon [this message]
2015-04-16 22:08       ` Ravi Kerur
2015-04-16 22:22         ` Ravi Kerur
2015-04-09 19:40   ` [dpdk-dev] [PATCH v5 3/8] Move common functions in eal_lcore.c Ravi Kerur
2015-04-16  8:39     ` Thomas Monjalon
2015-04-16 22:10       ` Ravi Kerur
2015-04-09 19:40   ` [dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c Ravi Kerur
2015-04-16  8:46     ` Thomas Monjalon
2015-04-16 22:11       ` Ravi Kerur
2015-04-09 19:40   ` [dpdk-dev] [PATCH v5 5/8] Move common functions in eal_memory.c Ravi Kerur
2015-04-16  8:52     ` Thomas Monjalon
2015-04-16 22:11       ` Ravi Kerur
2015-04-09 19:40   ` [dpdk-dev] [PATCH v5 6/8] Move common functions in eal_pci.c Ravi Kerur
2015-04-16  9:02     ` Thomas Monjalon
2015-04-16 22:12       ` Ravi Kerur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4780798.Fhdhc6hoDZ@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=rkerur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).