From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 28D71A0503;
	Fri, 20 May 2022 08:28:08 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C149240156;
	Fri, 20 May 2022 08:28:07 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 55C3A40151
 for <dev@dpdk.org>; Fri, 20 May 2022 08:28:06 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D19B98A;
 Fri, 20 May 2022 09:28:05 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D19B98A
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1653028085;
 bh=/s1LxcFNie7YI/9FweBBEqUhEd5qUbURWArZVkRgPBo=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=VGAolAdVfdZMrkRfeQEybxESUq8WgZcATQrosxfrVYHb99WF0oSxApT46XbzOA6gx
 Fj4wa4jvSS5wai/Gj+oSD0JahRFZK6iflM6mIBVijFPnbDjlFIWCc2p5Krou5p1eQv
 W0nFvfrmUvvB9Rm5pMERnnZaBWqqnl/J0UFbRvPQ=
Message-ID: <47abe7c5-c78c-1ede-a97a-098f9311d09d@oktetlabs.ru>
Date: Fri, 20 May 2022 09:28:05 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [RFC PATCH v2 1/5] app/testpmd: mark cmdline symbols as static
Content-Language: en-US
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, Xiaoyun Li <xiaoyun.li@intel.com>,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>
References: <20220513075718.18674-1-david.marchand@redhat.com>
 <20220518194649.1868574-1-david.marchand@redhat.com>
 <20220518194649.1868574-2-david.marchand@redhat.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220518194649.1868574-2-david.marchand@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 5/18/22 22:46, David Marchand wrote:
> All those symbols don't need to be global, plus it hides unused code
> such as cmd_set_conntrack_dir_set and cmd_set_conntrack_dir_conntrack
> tokens.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Very good idea. A couple of days ago I was wondering why these
symbols are global when I found few unused symbols in mtr
commands: cmd_create_port_meter_g_action,
cmd_create_port_meter_y_action and
cmd_create_port_meter_r_action.

So, it would be good to apply it to other similar files as
well.

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>