From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EAF9A0C43; Thu, 21 Oct 2021 18:59:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55B8640E5A; Thu, 21 Oct 2021 18:59:13 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 2426340683 for ; Thu, 21 Oct 2021 18:59:11 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="216257035" X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; d="scan'208";a="216257035" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 09:59:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; d="scan'208";a="495234470" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 21 Oct 2021 09:59:10 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 21 Oct 2021 09:59:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 21 Oct 2021 09:59:09 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 21 Oct 2021 09:59:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PhX40T5reHbAFbaTXQgPYjZ7Qln9v3kveEr3c3/8ppAGyZAytxivNfAlzRVx6RhSbKuINTeUDWRRXRJ4CBS47EVaqy53kcwNMY84JlqYOc8ijCef/RqXcU8XJdE8dU/vsnbscHdnkfpJ/kT26Bh5hK0AZxjxkSyI4lS9Lm/oyPsYFoM3cswqyI1WlDFVG0YieUtz0sjTY+ZQQqYCW8rMVf9HG3Jnxc9McHeTWKtMgncMOCAvAhZyhqY9HbG2pSgo3v5xTNrHx7FCxyYMIbq23REBMrFhrOwdg9Cd1ULsUs2Yhmv0d4l90hkXW7daxCt88MGg3/ztFPi2FMWGlRGr9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ihjO6DCKfrumbajyuS8NeT8lniaGPJqyszEa9fQUG9A=; b=Y0yCu6yCC51mo4RtugwYyAETcBmOdwxoISR/2l6i6twCQprtQHCiqQJEhvQC4KJ3nV/RKOovfZJSJOm+2thPgxl4tMmInrJVstvo65fyczbD+/jusb32GiCSHbMU/nfB7PXXDWkFp9pJvuw4/jq8NP0eD4e1sT28pg30+NLmDCUK1H7T0Ctq4LfM+MjllAQhZ63RgE5PNNhOrIvAEuBPzgWiUBP/CuJoIgE86l141SDt/RtQo3UtBqcJBOVa9G/dvqpS8FXStu4emmQ0DdoiFHbcQ5lv3V6xLR35IiKp1R36CgirUHFcNHSaf04QXMM8biHOo5gfp6DjicywrbC1mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ihjO6DCKfrumbajyuS8NeT8lniaGPJqyszEa9fQUG9A=; b=rrcKhp3QE2veRDLL0k4JTs2GxB2GQ1/4daZ9EAo6bsznDIRxvJ0gZ1NTa6EKj1wdBu/F9eWiTXP8MOKBkJpYoyHhz9hrHMSVDTccYlKI2D0nxy3pobXXUxOEDPmnX+6lLAXbUJNL0H0/XFCGJmKGYejZcZQhgqCLcQBIe2Qcm0s= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (20.182.107.83) by PH0PR11MB5112.namprd11.prod.outlook.com (20.182.126.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Thu, 21 Oct 2021 16:59:08 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021 16:59:07 +0000 Message-ID: <47ad3cc9-bfe9-f8e5-83c7-626edbcee3c0@intel.com> Date: Thu, 21 Oct 2021 17:59:02 +0100 Content-Language: en-US To: Miao Li , CC: , References: <20211015170911.478394-1-miao.li@intel.com> <20211018141638.5916-1-miao.li@intel.com> <20211018141638.5916-2-miao.li@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211018141638.5916-2-miao.li@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P195CA0001.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P195CA0001.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Thu, 21 Oct 2021 16:59:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33e23418-dae7-46e4-34b3-08d994b41885 X-MS-TrafficTypeDiagnostic: PH0PR11MB5112: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BLiaFJ/VzexckByIThByI88xNP+FpvZT+ooSmifdJ7c2xJ6Zsm0n1ZbAaC74ZU5wrzO+aDw6frnlwKY9BhVlgkEzj+IRg65IV5qzYhMgfF9rp1wnx2JQ2BYxWfOY2LSbPq27bvgbpWU27OfaKBlc/1MdYSt4rR/SKuE09/0j+jb+IqIualuKyMTIMXcH/8igT5VDFv7+KyfwttzPVqTrxFAfP+8vO48Xx5nSHTKS8BGOp9Wmims552kyXyzqt/Sa/CHwWF0bEa0puTgs/nqj3OOqCdvEVtYiS4jSRM64uf+X1yE6VhNCn2SwmARt285bxpbpZQzkEB04cNbCK4+WjrEeLr1qEdPFeEqkcGocGb1vg2KOj8E9ZGQxD07ycy7NoVgx/NFSdz61P8FYYsQiElOh8k3bj2Gseh55kV0OexZD2efbx8KitFfDWZ6ai+y+1xbzL+xKKJvOk9PsNbIS7bTjaGV3h2CDbPjIThu+yhAxusq0osTD3zji3DA1WsyzTm5UYRmTrJNbFXN2xy/6uq/ustwqecx6zsSsVUvprytHetQAZ92xyYbc9wmMtQMco/C1deCo9N2fDVRnpcxmvovexwk8SWIDz9YJQ8cXj2z3TqjiATAMM9y0xrye7FQ8SMXBWjgESLEebesZBWVdXk/woKf8uW21ZkCNathWO6hcGuv0JQN9OY9hXgUTL3/e7RZ1Rc4g8bpN5io9msowgg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(83380400001)(4326008)(38100700002)(16576012)(2616005)(186003)(82960400001)(6666004)(53546011)(44832011)(508600001)(5660300002)(26005)(6486002)(66556008)(8676002)(31686004)(66946007)(316002)(8936002)(86362001)(956004)(36756003)(31696002)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW5ZT2xpODZzejh3ZnBSYWUyb0d0ait6MTBwVVpsaVpkNkdhS2dXV0tjN25N?= =?utf-8?B?djBvVVg3T3ZEakVwbXRrNk9MVzRNckh6WHpUUCtaU3NQZ2pDcmdaRzV5L1Zz?= =?utf-8?B?UnJ5dGt4L3VVdTRqWC94ODBTT0VzelVlU0VLWTdlNHhWcHd0c0F3NmVWcm0r?= =?utf-8?B?K3B6MzhUZmlhdndDazhBcHJ6ekJLQm9HMFo2YThvY0pNUTJXMTFrWDZNU3Rk?= =?utf-8?B?YTE4TEt6Qm9FeDh2NnhtOVZHZXNZVkgwcDVlemNqVnBZeGl5U3FxTG1uSlpX?= =?utf-8?B?ZjNjSXc0NS96bnRtZ3FQencwa1VwYzFjN3dEVjFYMnB4SXg3K3ErVVZMZStX?= =?utf-8?B?NE8zeGZBOExEeHliaGRoU0tKOUdxLzdpYmUrQStvQ1VPaU1ZQ2JhdSt0TGg0?= =?utf-8?B?bGlSNE5iREczYTlJczRDRUJzTkN5bW9CN1U3bHd2bFhnbGJJeHl5VzMwVW9m?= =?utf-8?B?cGlBUVBWSEF2a3RsdW5paDhHcHlTZ0ZuSzNVQWF5OFluQlRIaG9lMzZSQkg3?= =?utf-8?B?di9hRk1JVGlPV3BNbzVLQWtUM1hNc3M0VmtpZjduZ21JcXQxdDJ4N0lQWlRH?= =?utf-8?B?TDNmVTByK3p5VmxxemVmaVN2clVwYTNBOExKQ1I1K1drY1ZrWGhWM3NGUXk0?= =?utf-8?B?dXVIR25mdEIxVmRKc3RTYldxWXoyZkthR1duNjhFTXNTUDNvWDZGU2owemNW?= =?utf-8?B?NjNVbWNzdm5BR2pVb1BHQjZUWlJ2M1l5YU1PWGlaTThLWEpZUGRvWjB5M3Y5?= =?utf-8?B?akxoMUhzdE9hWmNQZ1NoZmEzZFJoMWxCY0hyQ29KV3E3Y05HSXA0L2ZnTndF?= =?utf-8?B?R0hxWURMUU9iZklFa1RnT1hPamV2WWxBWHZHRWlJZnVRUTg4Z0dvK3JTaUVW?= =?utf-8?B?RmlyS2xlVVpySmlxdE1YWmNmMmVaZ1dXMXQzbjhtN2tpVW1xMkp2K2tmcmcx?= =?utf-8?B?eEhwVWtFejJuQkNSaEg3cERQVkptTlF5NXBpUURpaHdpSXFiWUtNMldJbkdW?= =?utf-8?B?dkhTbk14VmpuUmZrUjl5c1V5UVpKblZNZlltWmRYWW9qalFwNS8reVFISWpY?= =?utf-8?B?TFU3NmZWZ3R3MEZCVjF5RVBWcjdlWnlaVnN4eHUvSGU4U1p3dGE4Kzg2blVy?= =?utf-8?B?V3pNeXIrY2plQ1pMK1k3NjlMS2gzdnFrME01aFdrOWNrSUVOUk9tQVhCNmtV?= =?utf-8?B?V09UQnpQcEpCTk4yYlNhQy9nTjhKL1JIVEwxTldTbzZ6ZTk1aFNCWDBqVGJj?= =?utf-8?B?MTVTUk9lRllCVTN0Wk1RM3ZXR1c5d1VFWWwvRHoxTEFhTkQybGpDNTdGeHlh?= =?utf-8?B?OUxNSVNaa3ZxWW52YXF0L2lEUWpHQWFEY09sMEcwSUNFZmczMnBPMTJYTEhr?= =?utf-8?B?ay8yQVdQa0ErV3pHc0hkb3AwMjdGNWM2dzlMQVBWNk9oejlGRUFZYW10RzhW?= =?utf-8?B?MVc0c3hnMXpzR045SXdjQ0RFZjc0cHIyMkNhQ2FpZzFRWVpHbndkNE9JZ0JP?= =?utf-8?B?bGI4bTVCSWZLU3h0K3oyNHMxYU9vVnp5M0pEWHYyR0V3OUJVWWEzR3Q2dkZO?= =?utf-8?B?ZE1XYVgyL0cyaW1GU0swTCtnYnRoT2VHQUNpL3QxaHdwQ1htT2pQa25TbW5W?= =?utf-8?B?VTRVclE2eHZZdkJCL1dwVWtvT1Jjdk40c3YybVdSMHZOWXYxeTQ5TWQ2OUQz?= =?utf-8?B?YmVzNmRkSEVnenBrNVphSHdsbzNNcmlLdW1pY0ZVcXc2MDIzWWtxanB3NXBj?= =?utf-8?B?M3dKWW54UHUyazIwN3RRbDlWTGdaamJocSs4bEg2cTBPNDNGRlp1WkVJZjdG?= =?utf-8?B?RDVzbUNLKzZZWjY1MDRJUXpha29qL1hCUlg0UTFSVGhFN3YvQ0xESTdVT0p1?= =?utf-8?B?ZGgzSDIyaDMyZHRqSjF5ZmxBN2tDYW9tKzBUZ3RZeW5UN0ZZZG9oWXQ0VWxO?= =?utf-8?Q?H8ziobuiw780uUzo4ClYb7VD+P50Qfok?= X-MS-Exchange-CrossTenant-Network-Message-Id: 33e23418-dae7-46e4-34b3-08d994b41885 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 16:59:07.8482 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/18/2021 3:16 PM, Miao Li wrote: > This patch implements rte_power_monitor API in virtio PMD to reduce > power consumption when no packet come in. According to current semantics > of power monitor, this commit adds a callback function to decide whether > aborts the sleep by checking current value against the expected value and > virtio_get_monitor_addr to provide address to monitor. When no packet come > in, the value of address will not be changed and the running core will > sleep. Once packets arrive, the value of address will be changed and the > running core will wakeup. > A minor comment but instead of patch title mentioning what is implemented, better to describe what feature is added, like: net/virtio: support power monitor > Signed-off-by: Miao Li > Reviewed-by: Chenbo Xia > --- > doc/guides/rel_notes/release_21_11.rst | 4 ++ > drivers/net/virtio/virtio_ethdev.c | 56 ++++++++++++++++++++++++++ > 2 files changed, 60 insertions(+) > > diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst > index d5435a64aa..c298844898 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -80,6 +80,10 @@ New Features > Added macros ETH_RSS_IPV4_CHKSUM and ETH_RSS_L4_CHKSUM, now IPv4 and > TCP/UDP/SCTP header checksum field can be used as input set for RSS. > > +* **Updated virtio PMD.** > + > + Implement rte_power_monitor API in virtio PMD. > + The release note updates are grouped as described in the documents section comment, and in a group it is sorted alphabetically, can you please re-arrange the update accordingly. And similar comment, instead of documenting what API implemented, you can mention what support is added. Same comment for other patches in the set.