From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97A7142586; Wed, 13 Sep 2023 11:23:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B81E40395; Wed, 13 Sep 2023 11:23:57 +0200 (CEST) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id 77C2040608 for ; Wed, 13 Sep 2023 11:23:55 +0200 (CEST) Received: from loongson.cn (unknown [10.20.42.144]) by gateway (Coremail) with SMTP id _____8DxRvGpfwFlylEmAA--.8948S3; Wed, 13 Sep 2023 17:23:53 +0800 (CST) Received: from [10.20.42.144] (unknown [10.20.42.144]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxjNyofwFl4HACAA--.4320S3; Wed, 13 Sep 2023 17:23:52 +0800 (CST) Subject: Re: [PATCH 1/1] test/hash: fix error log output To: Stephen Hemminger Cc: yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, vladimir.medvedkin@intel.com, pablo.de.lara.guarch@intel.com, dev@dpdk.org References: <20230912115239.861800-1-zhoumin@loongson.cn> <20230913003057.5f22f687@fedora> From: zhoumin Message-ID: <47c9ab42-44b6-e6a6-1396-4b7db9ee78f3@loongson.cn> Date: Wed, 13 Sep 2023 17:23:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20230913003057.5f22f687@fedora> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf8DxjNyofwFl4HACAA--.4320S3 X-CM-SenderInfo: 52kr3ztlq6z05rqj20fqof0/1tbiAQANAWUBHCIEHQAEsK X-Coremail-Antispam: 1Uk129KBj9xXoWrKF1kKF1UJrW8Aw4xWryfuFX_yoWfArbE9F 17Arn7Jw1DA3WUG3W7ur4vy3y5tr429F1kGw4v9r1fJrySq343Cr18XFs5Gas3WryYyFWa kasYvrn8Zw4YvosvyTuYvTs0mTUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbI8YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_JrI_Jryl8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8C rVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtw CIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x02 67AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr 0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU25Ef UUUUU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 13, 2023 at 3:30PM, Stephen Hemminger wrote: > On Tue, 12 Sep 2023 19:52:39 +0800 > Min Zhou wrote: > >> diff --git a/app/test/test_hash_readwrite.c >> b/app/test/test_hash_readwrite.c index 74ca13912f..4997a01249 100644 >> --- a/app/test/test_hash_readwrite.c >> +++ b/app/test/test_hash_readwrite.c >> @@ -162,7 +162,7 @@ init_params(int use_ext, int use_htm, int rw_lf, >> int use_jhash) >> handle = rte_hash_create(&hash_params); >> if (handle == NULL) { >> - printf("hash creation failed"); >> + printf("hash creation failed\n"); > Errors should be writen to stderr, not stdout? > It looks like the hash test doesn't do that anywhere though. Agree! The errors should go to stderr. However, there are many such cases in app/test that errors were written to stderr.  It requires huge effort to fix them. Regards, Min