From: Luca Boccassi <bluca@debian.org>
To: Gaetan Rivet <grive@u256.net>, dev@dpdk.org
Cc: stephen@networkplumber.org,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming
Date: Mon, 16 Nov 2020 11:56:39 +0000 [thread overview]
Message-ID: <47d4b124b922a3f4f290ca7614570e8ccd5e7e99.camel@debian.org> (raw)
In-Reply-To: <20201116101212.405300-1-grive@u256.net>
On Mon, 2020-11-16 at 11:12 +0100, Gaetan Rivet wrote:
> The original triple negative was hard to read and the attempt
> to improve the formulation was commendable, unfortunately the new
> comment is the inverse of correct.
>
> Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")
> Cc: stephen@networkplumber.org
> Signed-off-by: Gaetan Rivet <grive@u256.net>
> ---
>
> No Cc:stable as it was not yet released.
>
> drivers/bus/pci/pci_common.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
> index b24c069713..d55e5a38cf 100644
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev)
> devargs = pci_devargs_lookup(&dev->addr);
> dev->device.devargs = devargs;
>
> - /* If the device is blocked, no rte_devargs exists for it. */
> + /* When using a block-list, only blocked devices will have
> + * an rte_devargs. Allowed devices won't have one.
> + */
> if (devargs != NULL)
> /* If an rte_devargs exists, the generic rte_device uses the
> * given name as its name.
Acked-by: Luca Boccassi <bluca@debian.org>
Thanks for fixing my mistake - at least it became readable enough to
understand it was the other way around :-)
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2020-11-16 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 10:12 Gaetan Rivet
2020-11-16 11:56 ` Luca Boccassi [this message]
2020-11-18 10:46 ` David Marchand
2020-11-20 9:02 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d4b124b922a3f4f290ca7614570e8ccd5e7e99.camel@debian.org \
--to=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=hemant.agrawal@nxp.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).