From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 768FEA04B5; Mon, 16 Nov 2020 12:56:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7198CC8B0; Mon, 16 Nov 2020 12:56:44 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 930DDF94 for ; Mon, 16 Nov 2020 12:56:41 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id o15so18385146wru.6 for ; Mon, 16 Nov 2020 03:56:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=yV5gVT0K0ANTArpSgAxPN2v8xjE+p0mbAee744qbuUc=; b=nuTbhj18zP/3ISE1GhLkVJTwc3KFZXMkLKH5pFzSfoTkJ1KFEm2rS6eI43sVn9mZP6 EBcNFJGpp/Z+T/aYVHPppsFf6WKXzS0i53biX/+ur5LhhOBi1YvKV/vblP3OmbN9SjvA nVXCpLDeCQU+sJHyQtgP9LjIgKBS4+vhmYPUgHph7L40QuNcDpx1KQyQB3LX8ribmFtO GbArav7srTUytA3x1OrIbUDwqQrh4gOdNl/iZxafDAECISH9KLN8xEEl1xYc8mtg0RXS //nP6oE1xR2wwJaRR5GoL127daxVI+QQ2Is0JGeRLPbFUri9nh4ZwTbfNUwQohGtlISx 7Elg== X-Gm-Message-State: AOAM533UDXN1yBBwZFP9aD68sbRkHJeEjywzrBba0kIH9WRhStCk/nwy cDbbC8iuYHsFlOBZMyX6Ra8= X-Google-Smtp-Source: ABdhPJzYnsTrUuWcrvtkpJeKc7j3n+mlcUrwYvccDV2HGt95ZFepaPk6wLZPkm7iNp62k2C2wPnMxA== X-Received: by 2002:adf:b78b:: with SMTP id s11mr18737842wre.42.1605527801313; Mon, 16 Nov 2020 03:56:41 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id u203sm20172969wme.32.2020.11.16.03.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 03:56:40 -0800 (PST) Message-ID: <47d4b124b922a3f4f290ca7614570e8ccd5e7e99.camel@debian.org> From: Luca Boccassi To: Gaetan Rivet , dev@dpdk.org Cc: stephen@networkplumber.org, Hemant Agrawal , Thomas Monjalon Date: Mon, 16 Nov 2020 11:56:39 +0000 In-Reply-To: <20201116101212.405300-1-grive@u256.net> References: <20201116101212.405300-1-grive@u256.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 2020-11-16 at 11:12 +0100, Gaetan Rivet wrote: > The original triple negative was hard to read and the attempt > to improve the formulation was commendable, unfortunately the new > comment is the inverse of correct. >=20 > Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums"= ) > Cc: stephen@networkplumber.org > Signed-off-by: Gaetan Rivet > --- >=20 > No Cc:stable as it was not yet released. >=20 > drivers/bus/pci/pci_common.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index b24c069713..d55e5a38cf 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev) > devargs =3D pci_devargs_lookup(&dev->addr); > dev->device.devargs =3D devargs; > =20 > - /* If the device is blocked, no rte_devargs exists for it. */ > + /* When using a block-list, only blocked devices will have > + * an rte_devargs. Allowed devices won't have one. > + */ > if (devargs !=3D NULL) > /* If an rte_devargs exists, the generic rte_device uses the > * given name as its name. Acked-by: Luca Boccassi Thanks for fixing my mistake - at least it became readable enough to understand it was the other way around :-) --=20 Kind regards, Luca Boccassi