From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAF26A0093; Tue, 7 Dec 2021 14:45:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62F984114F; Tue, 7 Dec 2021 14:45:26 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id B8D7A4114A; Tue, 7 Dec 2021 14:45:23 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10190"; a="224444488" X-IronPort-AV: E=Sophos;i="5.87,293,1631602800"; d="scan'208";a="224444488" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2021 05:45:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,293,1631602800"; d="scan'208";a="679445567" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 07 Dec 2021 05:45:04 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 7 Dec 2021 05:45:03 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 7 Dec 2021 05:45:03 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 7 Dec 2021 05:45:03 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 7 Dec 2021 05:45:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PxJLumjt7EMJmnDXWk6TwHP4heqd3Dd9fInJaFzhDLg7TWgCAyxwxvDy4Gk3q4A8qqq25iwLJ1JRfOi61+Fn/2vQghUL99IERGZRGQML989eWgWrxeKoK9oLlg0ypTtUkygtC2NH/onM1Lb9hZeoqRyA5U+vV+B2vnhN9Asd2q8z7gLGzlQSFfYP8HPd/MBaE4xwx19R1+Hu0ItTCSR/WtV/eL6kuGkBbfvP7OQyX1HnKYB8vfjl3zWKm6T8lbDl31YRpNgl4UHok3VdaPQtBddKXojuXLQtQ3R5GV04lJvlOZwV1nKBGtD4idXVpUL5PmpZiBVIXoUiJ5qMYKu5kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tVahI3QS6piMPYGgA5BR60Q/XR/wbW73rRyRz9Nimzs=; b=mxQd62C6VAinAR8sSPGiQMUUGB88z7VYM4KXMnc6nrVoNxa/DLyGEfFIS+e6OWIDOi1VHYwCeiY5D3j3WGWDGq8kuPneJrtlaF4UYXvTZbeQJ3tmFKyRG8dbDM1xI0kQJylYmIsfht7UfPh/NOM+sUQqY0PP8vb0oItFwayY6m80rKy79jpxEIshJVPFJ8rsiujX4XF2ay8vo/QrpQVS+1tvhpJErkVDGaRFtnOx8GikdVH4SKp+dajP6BBRB/uaqNF3hlkDMBA8hbIFaez4f70NaQK5c5JUtcfxDUeq9FVl7h1ZKvZ1rSzZzMAlg8u/RDF/Hp/UidktfbpY3/Z9xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tVahI3QS6piMPYGgA5BR60Q/XR/wbW73rRyRz9Nimzs=; b=myhsOzF/i6PboEe8Mz+6JeW3Aw6JT6MLgrpKX/2Wzlb1nupi6yDn3cuVj+2FVXdlqMo3uA+S1tqsvpSVG/khsR9KikpcYcnbcnUw/zTCmcK4/kJTA797SMt8Kryo5lKTfvCtz07hwErp5QKGrK7yM0BGwi6TNjjFvDiDsfay7Jo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by BYAPR11MB3349.namprd11.prod.outlook.com (2603:10b6:a03:1c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec 2021 13:45:00 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::d10a:71ec:458d:2dfd]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::d10a:71ec:458d:2dfd%8]) with mapi id 15.20.4755.021; Tue, 7 Dec 2021 13:45:00 +0000 Message-ID: <47e72a82-6c86-526a-f6d9-4a1c1fa9a977@intel.com> Date: Tue, 7 Dec 2021 13:44:53 +0000 Content-Language: en-US To: Viacheslav Ovsiienko , CC: , , References: <20211129123252.19408-1-viacheslavo@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH] net/mlx5: fix metadata endianness in modify field action X-User: ferruhy In-Reply-To: <20211129123252.19408-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0183.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::8) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0183.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20 via Frontend Transport; Tue, 7 Dec 2021 13:44:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45053bda-2340-47d8-1bb8-08d9b987c369 X-MS-TrafficTypeDiagnostic: BYAPR11MB3349:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SCdGrxoMTJy/O85y3M+Z58Kzdes5j/jSEXXw5QwmaXeaZVZmUCLcmJ1n3vYMo92PiceivQebmz3r/SQxZkXSPOr0H6qqGIsJ54/4/VI2oQRlxcUIxbjaGRgzkpCRPDqSam6uyniWq9IyuNdJLOnPgYnMeq2HKOSU6JO43nu9I4N9EMSa3/31TSOfCI9IhdjL4wl8hkIUrK5EJXT6BWv5EGSzWJohbCnE7ivJdzk4vfp/qcpRFE31EoUDvUztF39dgBZaGPSH4j0/sB3oaK8lbBw/XY5S2EEGnOaN+GFk4TwtqYDri2WRwhpeL4Yb6bfAlDs5FzGr2sOfY4+6I/w9GhPHRvmrJykCqSKQ+X+AKWcTnYcVl6puBgozsU3xGDd1XGB1PaLga06NFYktV70yK5jucaCtX0dUtrgsshJk1cKR4iEt80Ri1L2Cynn5rPMEUrCQ4iNZXGKrFGd/FHWfFkCXw16hUGDEl4XNfbFKDKSLw6Mol2MX0SuZuUEcvjZCIJA725bzSd0jSaIZqbYmxT1fR4H2KUV0y7BBoQ9dTpZYqzpTxXPswcJb/lucwxYebrtjEtczeZlwx+67OipMtdebZ89mlEsDwfmWxD1BmwO2KgaexjRqNCuw25TJzPXci2u+/mQQo7GWFi4vOvbMWS9GuqvyAtE6spYjjXSTXjRMQGoaSWOZn9vUqLigx8sWFLHPB33k1NCYFYZ+8PzYvg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(16576012)(316002)(66556008)(186003)(8676002)(36756003)(44832011)(2906002)(6666004)(38100700002)(83380400001)(31696002)(6486002)(2616005)(956004)(4326008)(31686004)(5660300002)(82960400001)(26005)(8936002)(508600001)(66476007)(66946007)(53546011)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXpFYTdWeFA4bDVDc3cvVVNhNHMySEN2VU1WNWhnUzU5S0NHaXVHdEcxU0kx?= =?utf-8?B?MXR2Qlk1MHNNdHNuaTRRc3RObjJKajBwYXhaYnJYYlZ4ZnpQMWtkbnF5STVP?= =?utf-8?B?RTg2MUt6Z3pCTituMi82ZXNFQms5WkdXakNnUGg1OVhLa0RXelVRSHB1K2s1?= =?utf-8?B?bXpnQzNaWXVhaS95MFBndkRDNzc2QnJzb0liRW9xQnZEZm5BanpDYVlGZXgz?= =?utf-8?B?UXdTbXJ0K0gwZEU1NU5oWmlqNjBRaklqOGpNeVk4bTRoZUM5VTlQRklJSmFS?= =?utf-8?B?ZHR5R3haajdLdXpvUlRjZmxxQ0NHUlJZQmxnUVMxV3NIOE1zVzJEMERpVlhr?= =?utf-8?B?T2JEcnVUcGhPYk9HYUhpRmdHWmpRcENCbnEyK21aNTlLYS8wZzFtVlFtY0xJ?= =?utf-8?B?SE5pZmgwcldIMXY4dERXRHJzUzZ6eVFnWUdMLzlYemdITE1ZMFIybkRLcElU?= =?utf-8?B?SmhocVd4ZE1lZU5xUFVMbWc0NWwybkVpTzkxa3ByUUlqL3RiRm05aDVaNWhi?= =?utf-8?B?R1VmejF0anoxVXJMbi95QWJtazIwT0VpaXlIRTFlL1IxY1grOW95T2FtT3BW?= =?utf-8?B?eWZ2V3dld0VIUGtmVHIvWU9vTEx4Qzd6czA1d0dSb3Y4Q2Q2OGcxWXZKQ1Nw?= =?utf-8?B?dTZYVXEwVlU2a1VhcnNWa2RmZFNnelU3MXU5Q0xHZkM5YWtodmhiRmlJaHFO?= =?utf-8?B?dHNCWTZmQm0zU3VTRTJQRnd2bk5XQjFMcFM4N0t5dHlqSjFOdGozVnNSRWtZ?= =?utf-8?B?U0F2QXIvTFRBcGFtNGExNi9ST3Z3b1F3Tk5rWHdGTlFjeHJ0Wm1udUNhV0t1?= =?utf-8?B?MUhZSnBWRGhBQWNzUFk0em5hazc0d0VZZzJhUTBHWlFYUWxPU3JhcFBEMTJk?= =?utf-8?B?ZGZqditmNjAwaGZoV2djTVNjbjJYMmoyM2xUWlpEOXpKd1l5UmNaUFpHeFdI?= =?utf-8?B?MGl3RzhENGZrZW9sU3p3Q2FaVUtKMVgzclYwRmRvL2FoOWEwS3R1UVlOeVlC?= =?utf-8?B?YWkxVXFITGtEYmRNS0p6UmlNKy8vYzB5eW5VZTBSdzRZL2l5ZnRKNUJDWkYy?= =?utf-8?B?YkpOVG1LNHFMd0RPbkQ0MnZtOXhxdUl1UDhaNjRta255WHNHbVV1VW9Ob1lP?= =?utf-8?B?Mm5PUFB1aVdLYldIY1c4UDhEdXVxQlFSdWhTQ2lJd2hNSXlJU3NZZ2VycnRo?= =?utf-8?B?OEY3b2F1RE9MTUFxc2pEYjR2VVRheE5oYlFJd0xEeFFVZURaVW1oZ3BvZ2sz?= =?utf-8?B?cXhkVkM1T3EzZDl6WFR2c1RzUmdpSnErRW9PL0w3b1NlNVp0aDZSNnd6bDQ3?= =?utf-8?B?dGEwYnpFZndrcUsrOGZhN0JHUlF6TWF3bHlQS1gveG9CaUg5UWwwcENQVi9i?= =?utf-8?B?NWJVY1ZCK1pyVXBlYVVwMnBaWHdscW1RL2FOM3J3OS9ZM1JmZllSbDhjSWpT?= =?utf-8?B?M3JwL3c1bkNFeFFnTVpEVTd6QlFWQ3dvZHMyWnNEVVZjOCtpOWYyZXh1d2E4?= =?utf-8?B?NUJ3YXlUaWZwQTBvbXBPV01NOWkyMjNpdENydUFMSjIzblJLb0x1T2wvbmtZ?= =?utf-8?B?RTBqdmFsWkVkWU5ETGY0VE1pNTA0bU1GVGJQdS9yTUFZZjFFNjE0TVFueC9t?= =?utf-8?B?TjhhM2RvRWdXWXlRS3JLYVd1dVk3dm5NbFNKbFQ0MVJrWWl0ZUlkNUpWYmQ0?= =?utf-8?B?eENqTjRGeWdML2tpRjFPNXdZRTVrMlkzVEZPYWVwVzUxdDhxbDZXK0dLRitk?= =?utf-8?B?WEhncG9qMkRqeCtFZWY0VkZMU2lhbTJWN2FiK1lnYXVPSDdpb1lZb0xCYU1I?= =?utf-8?B?QndpTlQySUJxa0hWTHFwT3dXOGgxT2xtY3BTL0YxY05zUTRUblo2aDM4bUFR?= =?utf-8?B?a3NOdUZsMlFHUERDamFyWDdKcjJTUVp6Tmpzb2xhb1FvYzNUblZlYmFFTWxL?= =?utf-8?B?UEplb1Ntc0JyeUdpRnNqWEVpNmRMNElOMTYzejJ4WTFobmpocWY5eUIvTUxT?= =?utf-8?B?WHNhNENMaGhJK00xSVhRS242M3VvdTlhYjc1ZTVsV25UbFk1M3hvUVRXdEYx?= =?utf-8?B?UlNxZlZhZ1d6QmVXenB0NzlXeFVHeURLU0kvWXp4cGFvREx3cHpnMXNkWFc3?= =?utf-8?B?ME8vSEFZelZyMWtVVFNyS1RRaW9ZQVpacW1xOGo1U25rQ3VvVXJCNWlCWW1m?= =?utf-8?Q?4mEwhrNiUji8mpa+6D68wVY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 45053bda-2340-47d8-1bb8-08d9b987c369 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 13:45:00.2383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pxhpIfr3SZ6OAtmb1oBVKo0Lnv5SBveBD45KAjyUMxA9qeH2uwm9Tj8iIkHy6fsct6WhGwVaaNYmd/KYcuUZ7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3349 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/29/2021 12:32 PM, Viacheslav Ovsiienko wrote: > As modify field action immediate source parameter the metadata > should follow the CPU endianness (according to SET_META action > structure format), and mlx5 PMD wrongly handled the immediate > parameter metadata buffer as big-endian, resulting in wrong > metadata set action with incorrect endianness. > > Fixes: 40c8fb1fd3b3 ("net/mlx5: update modify field action") > Cc: stable@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c > index 4834c752d9..1c6cae8779 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1465,7 +1465,7 @@ static void > mlx5_flow_field_id_to_modify_info > (const struct rte_flow_action_modify_data *data, > struct field_modify_info *info, uint32_t *mask, > - uint32_t width, uint32_t *shift, struct rte_eth_dev *dev, > + uint32_t width, struct rte_eth_dev *dev, Hi Viacheslav, Is removing (unused) 'shift' variable related to the problem mentioned in the commit log? Only below "meta = rte_cpu_to_be_32(meta);" change block seems fixing the issue and rest is cleanup, if that is the case can you please split the patch?