From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2D87A0546; Fri, 30 Apr 2021 11:22:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E9F94014F; Fri, 30 Apr 2021 11:22:10 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 948644013F for ; Fri, 30 Apr 2021 11:22:07 +0200 (CEST) IronPort-SDR: dpIx2kM5SDG524l1RSj6WeiA/0InN1oLrUtOMQxE/5XFYlnBie0sXXlOgV3wcLvX9JgxwHvKml V9GRrXBxUkgg== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="196794082" X-IronPort-AV: E=Sophos;i="5.82,262,1613462400"; d="scan'208";a="196794082" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 02:22:06 -0700 IronPort-SDR: qGaJoE8o1+jqpQz2xPyuO4yl+DIew8PBa7KuJ+92HOV6rdYUttmPeMI2zSGVzGg1IPDhXCkoEW fnf14gQWl8Kg== X-IronPort-AV: E=Sophos;i="5.82,262,1613462400"; d="scan'208";a="404530723" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.242.68]) ([10.213.242.68]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 02:22:04 -0700 To: Slava Ovsiienko , "dev@dpdk.org" , Andrew Rybchenko Cc: Raslan Darawsheh , Matan Azrad , Michael Baum , NBU-Contact-Thomas Monjalon References: <20210426124250.42771-1-michaelba@nvidia.com> <20210429095542.7800-1-viacheslavo@nvidia.com> <20210429095542.7800-2-viacheslavo@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <47e789a4-3ad3-e119-5a3c-581b7a3a0eb4@intel.com> Date: Fri, 30 Apr 2021 10:22:00 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/mlx5: support flow count action handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/30/2021 10:01 AM, Slava Ovsiienko wrote: > Hi, Ferruh > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, April 30, 2021 11:35 >> To: Slava Ovsiienko ; dev@dpdk.org; Andrew >> Rybchenko >> Cc: Raslan Darawsheh ; Matan Azrad >> ; Michael Baum ; NBU- >> Contact-Thomas Monjalon >> Subject: Re: [PATCH v2 1/5] net/mlx5: support flow count action handle >> >> On 4/29/2021 10:55 AM, Viacheslav Ovsiienko wrote: >>> From: Michael Baum >>> >>> Existing API supports counter action to count traffic of a single flow. >>> The user can share the count action among different flows using the >>> shared flag and the same counter ID in the count action configuration. >>> >>> Recent patch [1] introduced the indirect action API. >>> Using this API, an action can be created as indirect, unattached to >>> any flow rule. >>> Multiple flows can then be created using the same indirect action. >>> The new API also supports query operation of an indirect action. >>> >>> The new API is more efficient because the driver gets it's own handler >>> for the count action instead of managing a mapping between the user ID >>> to the driver handle. >>> >>> Support create, query and destroy indirect action operations for flow >>> count action. >>> >>> Application will use the indirect action query operation to query this >>> count action. >>> >>> In the meantime the old sharing mechanism (with the sharing flag) >>> continues to be supported, and the user can choose the way he wants to >>> share the counter. >>> The new indirect action API is only supported in DevX, so sharing >>> counter action in Verbs can only be done through the old mechanism. >>> >> >> There is already a deprecation note to remove the 'shared' flag from counter >> action [2] in favor of 'shared actions'. >> >> Shared action become "indirect actions" [3] which this patch implements >> >> Is it a good time to remove the old sharing mechanism from driver since >> touching on it? > > As I can see: > - it is planned to 21.11 as deprecation note says Yes, deprecation is for 21.11, but I though it might be easier for you to remove it now while it is under rework, but I can see you prefer to keep it. > - now there Is no support for new "indirect actions" with Verbs (not sure > we will provide), so shared counters API might be still useful > - our CI did not migrate to the new counter approach yet (even DPDK patch is not merged yet 😊) > - hence, l would prefer keep shared counter support (by id and flag) in 21.05 > (and very likely in 21.08), just to maintain maximal backward compatibility as long > as possible > OK > With best regards, > Slava > >> >> >> [2] >> https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst?h=v2 >> 1.05-rc1#n95 >> >> [3] >> https://git.dpdk.org/dpdk/commit/?h=v21.05-rc1&id=4b61b8774be9 >> >> >>> [1] https://mails.dpdk.org/archives/dev/2020-July/174110.html >>> >>> Signed-off-by: Michael Baum >>> Acked-by: Matan Azrad >> >> <...>