From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B6C601B450 for ; Thu, 27 Sep 2018 14:24:14 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A05D86674; Thu, 27 Sep 2018 12:24:14 +0000 (UTC) Received: from [10.36.112.65] (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1DBEE600CC; Thu, 27 Sep 2018 12:24:11 +0000 (UTC) To: Jiayu Hu , dev@dpdk.org Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, Gavin.Hu@arm.com References: <1536305094-126439-1-git-send-email-jiayu.hu@intel.com> <1537156482-46428-1-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin Message-ID: <47f35e9f-a211-5eb5-b2e9-23145f44d1bc@redhat.com> Date: Thu, 27 Sep 2018 14:24:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537156482-46428-1-git-send-email-jiayu.hu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 27 Sep 2018 12:24:14 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 12:24:15 -0000 On 09/17/2018 05:54 AM, Jiayu Hu wrote: > When perform enqueue operations on the split and packed ring, s/perform/performing/ s/ring/rings/ > if the reserved buffer length from the descriptor table execeeds > 65535, the returned length by fill_vec_buf_split/_packed() is > overflowed. This patch is to avoid this corner case. s/overflowed/overflows/ > > Fixes: f689586b ("vhost: shadow used ring update") > Fixes: fd68b473 ("vhost: use buffer vectors in dequeue path") > Fixes: 2f3225a7 ("vhost: add vector filling support for packed ring") > Fixes: 37f5e79a ("vhost: add shadow used ring support for packed rings") > Fixes: a922401f ("vhost: add Rx support for packed ring") > Fixes: ae999ce4 ("vhost: add Tx support for packed ring") > > Signed-off-by: Jiayu Hu > --- > lib/librte_vhost/virtio_net.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > Other than that, the patch looks good to me. Thanks for fixing it. Reviewed-by: Maxime Coquelin Maxime