From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ali Alnubani <alialnu@nvidia.com>, dev@dpdk.org
Subject: Re: [PATCH] vhost: fix build with gcc 4.8
Date: Thu, 6 Jul 2023 11:05:54 +0200 [thread overview]
Message-ID: <47f78a64-ac63-fe8e-6192-1110f1315824@redhat.com> (raw)
In-Reply-To: <20230703082153.504569-1-alialnu@nvidia.com>
On 7/3/23 10:21, Ali Alnubani wrote:
> Adds braces around initializer to resolve the following
> false-positive build error with gcc 4.8.5 on CentOS:
> lib/vhost/vduse.c:441:9: error: missing braces around initializer
> [-Werror=missing-braces]
>
> Fixes: 653327e191f0 ("vhost: add multiqueue support to VDUSE")
> Cc: maxime.coquelin@redhat.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
> lib/vhost/vduse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c
> index a509daf80c..aa5f1f564d 100644
> --- a/lib/vhost/vduse.c
> +++ b/lib/vhost/vduse.c
> @@ -438,7 +438,7 @@ vduse_device_create(const char *path)
> pthread_t fdset_tid;
> uint32_t i, max_queue_pairs, total_queues;
> struct virtio_net *dev;
> - struct virtio_net_config vnet_config = { 0 };
> + struct virtio_net_config vnet_config = {{ 0 }};
> uint64_t ver = VHOST_VDUSE_API_VERSION;
> uint64_t features = VDUSE_NET_SUPPORTED_FEATURES;
> struct vduse_dev_config *dev_config = NULL;
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
prev parent reply other threads:[~2023-07-06 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 8:21 Ali Alnubani
2023-07-03 8:29 ` Maxime Coquelin
2023-07-06 9:05 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f78a64-ac63-fe8e-6192-1110f1315824@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=alialnu@nvidia.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).