From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6846342DE6; Thu, 6 Jul 2023 11:06:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB50740F16; Thu, 6 Jul 2023 11:06:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 81C1240A79 for ; Thu, 6 Jul 2023 11:06:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688634360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iWG9bOEFqcPp5LjShkIba4renk0pG1wcb6a7XASA0Uk=; b=MzwwVsIBu+yq3DlX8XYgmm03CcwjbwKZyFxFf8hF2odQxgd84A6tkh6hLx5h6ElmqnkA6W k0ecYBj8UoXOSYhRLciIwCEV8A+mEKvUsdby3Sr73bW5xTsJJOGq4nvAKRraHE8X0oED0x jhQS51LngmMxdKBaymsBUvxwCZOig0Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-81-TgnxFyi8OUCXmN3JExgVNg-1; Thu, 06 Jul 2023 05:05:56 -0400 X-MC-Unique: TgnxFyi8OUCXmN3JExgVNg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 291A33C01BA4; Thu, 6 Jul 2023 09:05:56 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 981822014F87; Thu, 6 Jul 2023 09:05:55 +0000 (UTC) Message-ID: <47f78a64-ac63-fe8e-6192-1110f1315824@redhat.com> Date: Thu, 6 Jul 2023 11:05:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] vhost: fix build with gcc 4.8 To: Ali Alnubani , dev@dpdk.org References: <20230703082153.504569-1-alialnu@nvidia.com> From: Maxime Coquelin In-Reply-To: <20230703082153.504569-1-alialnu@nvidia.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/3/23 10:21, Ali Alnubani wrote: > Adds braces around initializer to resolve the following > false-positive build error with gcc 4.8.5 on CentOS: > lib/vhost/vduse.c:441:9: error: missing braces around initializer > [-Werror=missing-braces] > > Fixes: 653327e191f0 ("vhost: add multiqueue support to VDUSE") > Cc: maxime.coquelin@redhat.com > > Signed-off-by: Ali Alnubani > --- > lib/vhost/vduse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c > index a509daf80c..aa5f1f564d 100644 > --- a/lib/vhost/vduse.c > +++ b/lib/vhost/vduse.c > @@ -438,7 +438,7 @@ vduse_device_create(const char *path) > pthread_t fdset_tid; > uint32_t i, max_queue_pairs, total_queues; > struct virtio_net *dev; > - struct virtio_net_config vnet_config = { 0 }; > + struct virtio_net_config vnet_config = {{ 0 }}; > uint64_t ver = VHOST_VDUSE_API_VERSION; > uint64_t features = VDUSE_NET_SUPPORTED_FEATURES; > struct vduse_dev_config *dev_config = NULL; Applied to dpdk-next-virtio/main. Thanks, Maxime