* [PATCH 1/3] vdpa/ifc: fix log info mismatch
@ 2021-12-13 4:29 Andy Pei
2021-12-13 6:36 ` [PATCH v2] " Andy Pei
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Andy Pei @ 2021-12-13 4:29 UTC (permalink / raw)
To: dev; +Cc: andy.pei, chenbo.xia, xiao.w.wang
fix log info mismatch.
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c
index 721cb1d..d10c1fd 100644
--- a/drivers/vdpa/ifc/base/ifcvf.c
+++ b/drivers/vdpa/ifc/base/ifcvf.c
@@ -94,12 +94,14 @@
return -1;
}
- DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
- "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
- "multiplier: %u\n",
- hw->common_cfg, hw->dev_cfg,
- hw->isr, hw->notify_base,
- hw->notify_off_multiplier);
+ DEBUGOUT("capability mapping:\n"
+ "common cfg: %p\n"
+ "notify base: %p\n"
+ "isr cfg: %p\n"
+ "device cfg: %p\n"
+ "multiplier: %u\n",
+ hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+ hw->notify_off_multiplier);
return 0;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2] vdpa/ifc: fix log info mismatch 2021-12-13 4:29 [PATCH 1/3] vdpa/ifc: fix log info mismatch Andy Pei @ 2021-12-13 6:36 ` Andy Pei 2021-12-13 7:29 ` Wang, Xiao W 2021-12-13 6:54 ` [PATCH 1/3] " Wang, Xiao W 2021-12-13 7:00 ` [PATCH v3] " Andy Pei 2 siblings, 1 reply; 9+ messages in thread From: Andy Pei @ 2021-12-13 6:36 UTC (permalink / raw) To: dev; +Cc: chenbo.xia, xiao.w.wang fix log info mismatch. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Cc: xiao.w.wang@intel.com Signed-off-by: Andy Pei <andy.pei@intel.com> --- drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c index 721cb1d..d10c1fd 100644 --- a/drivers/vdpa/ifc/base/ifcvf.c +++ b/drivers/vdpa/ifc/base/ifcvf.c @@ -94,12 +94,14 @@ return -1; } - DEBUGOUT("capability mapping:\ncommon cfg: %p\n" - "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n" - "multiplier: %u\n", - hw->common_cfg, hw->dev_cfg, - hw->isr, hw->notify_base, - hw->notify_off_multiplier); + DEBUGOUT("capability mapping:\n" + "common cfg: %p\n" + "notify base: %p\n" + "isr cfg: %p\n" + "device cfg: %p\n" + "multiplier: %u\n", + hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg, + hw->notify_off_multiplier); return 0; } -- 1.8.3.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] vdpa/ifc: fix log info mismatch 2021-12-13 6:36 ` [PATCH v2] " Andy Pei @ 2021-12-13 7:29 ` Wang, Xiao W 2021-12-13 7:36 ` Pei, Andy 0 siblings, 1 reply; 9+ messages in thread From: Wang, Xiao W @ 2021-12-13 7:29 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: Xia, Chenbo Hi Andy, BRs, Xiao > -----Original Message----- > From: Pei, Andy <andy.pei@intel.com> > Sent: Monday, December 13, 2021 2:36 PM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo.xia@intel.com>; Wang, Xiao W > <xiao.w.wang@intel.com> > Subject: [PATCH v2] vdpa/ifc: fix log info mismatch > > fix log info mismatch. Use "Fix". > > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > Cc: xiao.w.wang@intel.com For fix patch, you need to Cc "stable@dpdk.org", not me. > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c > index 721cb1d..d10c1fd 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -94,12 +94,14 @@ > return -1; > } > > - DEBUGOUT("capability mapping:\ncommon cfg: %p\n" > - "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n" > - "multiplier: %u\n", > - hw->common_cfg, hw->dev_cfg, > - hw->isr, hw->notify_base, > - hw->notify_off_multiplier); > + DEBUGOUT("capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device cfg: %p\n" > + "multiplier: %u\n", > + hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg, > + hw->notify_off_multiplier); > > return 0; > } > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] vdpa/ifc: fix log info mismatch 2021-12-13 7:29 ` Wang, Xiao W @ 2021-12-13 7:36 ` Pei, Andy 0 siblings, 0 replies; 9+ messages in thread From: Pei, Andy @ 2021-12-13 7:36 UTC (permalink / raw) To: Wang, Xiao W, dev; +Cc: Xia, Chenbo Hi Xiao, Thanks for your reply. I will send a V3 patch to address this. -----Original Message----- From: Wang, Xiao W <xiao.w.wang@intel.com> Sent: Monday, December 13, 2021 3:30 PM To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org Cc: Xia, Chenbo <chenbo.xia@intel.com> Subject: RE: [PATCH v2] vdpa/ifc: fix log info mismatch Hi Andy, BRs, Xiao > -----Original Message----- > From: Pei, Andy <andy.pei@intel.com> > Sent: Monday, December 13, 2021 2:36 PM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo.xia@intel.com>; Wang, Xiao W > <xiao.w.wang@intel.com> > Subject: [PATCH v2] vdpa/ifc: fix log info mismatch > > fix log info mismatch. Use "Fix". > > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > Cc: xiao.w.wang@intel.com For fix patch, you need to Cc "stable@dpdk.org", not me. > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > b/drivers/vdpa/ifc/base/ifcvf.c index 721cb1d..d10c1fd 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -94,12 +94,14 @@ > return -1; > } > > - DEBUGOUT("capability mapping:\ncommon cfg: %p\n" > - "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n" > - "multiplier: %u\n", > - hw->common_cfg, hw->dev_cfg, > - hw->isr, hw->notify_base, > - hw->notify_off_multiplier); > + DEBUGOUT("capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device cfg: %p\n" > + "multiplier: %u\n", > + hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg, > + hw->notify_off_multiplier); > > return 0; > } > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 1/3] vdpa/ifc: fix log info mismatch 2021-12-13 4:29 [PATCH 1/3] vdpa/ifc: fix log info mismatch Andy Pei 2021-12-13 6:36 ` [PATCH v2] " Andy Pei @ 2021-12-13 6:54 ` Wang, Xiao W 2021-12-13 7:26 ` Pei, Andy 2021-12-13 7:00 ` [PATCH v3] " Andy Pei 2 siblings, 1 reply; 9+ messages in thread From: Wang, Xiao W @ 2021-12-13 6:54 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: Xia, Chenbo Hi Andy, Thanks for the patch. You need to add the "Fixes: " line. BRs, Xiao > -----Original Message----- > From: Pei, Andy <andy.pei@intel.com> > Sent: Monday, December 13, 2021 12:29 PM > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>; > Wang, Xiao W <xiao.w.wang@intel.com> > Subject: [PATCH 1/3] vdpa/ifc: fix log info mismatch > > fix log info mismatch. > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c > index 721cb1d..d10c1fd 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -94,12 +94,14 @@ > return -1; > } > > - DEBUGOUT("capability mapping:\ncommon cfg: %p\n" > - "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n" > - "multiplier: %u\n", > - hw->common_cfg, hw->dev_cfg, > - hw->isr, hw->notify_base, > - hw->notify_off_multiplier); > + DEBUGOUT("capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device cfg: %p\n" > + "multiplier: %u\n", > + hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg, > + hw->notify_off_multiplier); > > return 0; > } > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 1/3] vdpa/ifc: fix log info mismatch 2021-12-13 6:54 ` [PATCH 1/3] " Wang, Xiao W @ 2021-12-13 7:26 ` Pei, Andy 0 siblings, 0 replies; 9+ messages in thread From: Pei, Andy @ 2021-12-13 7:26 UTC (permalink / raw) To: Wang, Xiao W, dev; +Cc: Xia, Chenbo Hi Xiao, "Fixes: " line will be added in V2. Thanks for reply. -----Original Message----- From: Wang, Xiao W <xiao.w.wang@intel.com> Sent: Monday, December 13, 2021 2:55 PM To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org Cc: Xia, Chenbo <chenbo.xia@intel.com> Subject: RE: [PATCH 1/3] vdpa/ifc: fix log info mismatch Hi Andy, Thanks for the patch. You need to add the "Fixes: " line. BRs, Xiao > -----Original Message----- > From: Pei, Andy <andy.pei@intel.com> > Sent: Monday, December 13, 2021 12:29 PM > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xia, Chenbo > <chenbo.xia@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com> > Subject: [PATCH 1/3] vdpa/ifc: fix log info mismatch > > fix log info mismatch. > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c > b/drivers/vdpa/ifc/base/ifcvf.c index 721cb1d..d10c1fd 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -94,12 +94,14 @@ > return -1; > } > > - DEBUGOUT("capability mapping:\ncommon cfg: %p\n" > - "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n" > - "multiplier: %u\n", > - hw->common_cfg, hw->dev_cfg, > - hw->isr, hw->notify_base, > - hw->notify_off_multiplier); > + DEBUGOUT("capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device cfg: %p\n" > + "multiplier: %u\n", > + hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg, > + hw->notify_off_multiplier); > > return 0; > } > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] vdpa/ifc: fix log info mismatch 2021-12-13 4:29 [PATCH 1/3] vdpa/ifc: fix log info mismatch Andy Pei 2021-12-13 6:36 ` [PATCH v2] " Andy Pei 2021-12-13 6:54 ` [PATCH 1/3] " Wang, Xiao W @ 2021-12-13 7:00 ` Andy Pei 2022-01-14 7:22 ` Xia, Chenbo 2022-01-27 5:14 ` Xia, Chenbo 2 siblings, 2 replies; 9+ messages in thread From: Andy Pei @ 2021-12-13 7:00 UTC (permalink / raw) To: dev; +Cc: chenbo.xia, stable Fix log info mismatch. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Cc: stable@dpdk.org Signed-off-by: Andy Pei <andy.pei@intel.com> --- drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c index 721cb1d..d10c1fd 100644 --- a/drivers/vdpa/ifc/base/ifcvf.c +++ b/drivers/vdpa/ifc/base/ifcvf.c @@ -94,12 +94,14 @@ return -1; } - DEBUGOUT("capability mapping:\ncommon cfg: %p\n" - "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n" - "multiplier: %u\n", - hw->common_cfg, hw->dev_cfg, - hw->isr, hw->notify_base, - hw->notify_off_multiplier); + DEBUGOUT("capability mapping:\n" + "common cfg: %p\n" + "notify base: %p\n" + "isr cfg: %p\n" + "device cfg: %p\n" + "multiplier: %u\n", + hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg, + hw->notify_off_multiplier); return 0; } -- 1.8.3.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v3] vdpa/ifc: fix log info mismatch 2021-12-13 7:00 ` [PATCH v3] " Andy Pei @ 2022-01-14 7:22 ` Xia, Chenbo 2022-01-27 5:14 ` Xia, Chenbo 1 sibling, 0 replies; 9+ messages in thread From: Xia, Chenbo @ 2022-01-14 7:22 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: stable > -----Original Message----- > From: Pei, Andy <andy.pei@intel.com> > Sent: Monday, December 13, 2021 3:01 PM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo.xia@intel.com>; stable@dpdk.org > Subject: [PATCH v3] vdpa/ifc: fix log info mismatch > > Fix log info mismatch. > > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c > index 721cb1d..d10c1fd 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -94,12 +94,14 @@ > return -1; > } > > - DEBUGOUT("capability mapping:\ncommon cfg: %p\n" > - "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n" > - "multiplier: %u\n", > - hw->common_cfg, hw->dev_cfg, > - hw->isr, hw->notify_base, > - hw->notify_off_multiplier); > + DEBUGOUT("capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device cfg: %p\n" > + "multiplier: %u\n", > + hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg, > + hw->notify_off_multiplier); > > return 0; > } > -- > 1.8.3.1 Reviewed-by: Chenbo Xia <chenbo.xia@intel.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v3] vdpa/ifc: fix log info mismatch 2021-12-13 7:00 ` [PATCH v3] " Andy Pei 2022-01-14 7:22 ` Xia, Chenbo @ 2022-01-27 5:14 ` Xia, Chenbo 1 sibling, 0 replies; 9+ messages in thread From: Xia, Chenbo @ 2022-01-27 5:14 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: stable > -----Original Message----- > From: Pei, Andy <andy.pei@intel.com> > Sent: Monday, December 13, 2021 3:01 PM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo.xia@intel.com>; stable@dpdk.org > Subject: [PATCH v3] vdpa/ifc: fix log info mismatch > > Fix log info mismatch. > > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c > index 721cb1d..d10c1fd 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -94,12 +94,14 @@ > return -1; > } > > - DEBUGOUT("capability mapping:\ncommon cfg: %p\n" > - "notify base: %p\nisr cfg: %p\ndevice cfg: %p\n" > - "multiplier: %u\n", > - hw->common_cfg, hw->dev_cfg, > - hw->isr, hw->notify_base, > - hw->notify_off_multiplier); > + DEBUGOUT("capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device cfg: %p\n" > + "multiplier: %u\n", > + hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg, > + hw->notify_off_multiplier); > > return 0; > } > -- > 1.8.3.1 Applied to next-virtio/main, thanks ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-01-27 5:14 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-12-13 4:29 [PATCH 1/3] vdpa/ifc: fix log info mismatch Andy Pei 2021-12-13 6:36 ` [PATCH v2] " Andy Pei 2021-12-13 7:29 ` Wang, Xiao W 2021-12-13 7:36 ` Pei, Andy 2021-12-13 6:54 ` [PATCH 1/3] " Wang, Xiao W 2021-12-13 7:26 ` Pei, Andy 2021-12-13 7:00 ` [PATCH v3] " Andy Pei 2022-01-14 7:22 ` Xia, Chenbo 2022-01-27 5:14 ` Xia, Chenbo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).