From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Harish Patil <harish.patil@qlogic.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 0/4] bnx2x: poll mode driver
Date: Mon, 27 Jul 2015 04:09:01 +0200 [thread overview]
Message-ID: <4802193.YkiD4yNaLb@xps13> (raw)
In-Reply-To: <D1D5DCEA.A5E3E%harish.patil@qlogic.com>
> >Stephen Hemminger (4):
> > eal: provide functions to access PCI config
> > bnx2x: driver core
> > bnx2x: driver support routines
> > bnx2x: enable PMD build
>
> Acked-by: Harish Patil <harish.patil@qlogic.com>
This driver is too big, its style do not comply with the DPDK coding style,
there is no git history (drop all in 2 patches), there is no documentation,
no BSD support and it has no maintainer.
However, any new driver is welcome and can get a chance to live in the DPDK
repository. That's why it has been applied.
But next changes must be clean, even if it implies a big refactoring.
In case its maintenance cause problems and no declared maintainer can help,
it will be dropped.
It has not been tested with all supported compilers. Please be prepare to
fix the compilation shortly.
prev parent reply other threads:[~2015-07-27 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 16:33 Stephen Hemminger
2015-07-20 16:33 ` [dpdk-dev] [PATCH v5 1/4] eal: provide functions to access PCI config Stephen Hemminger
2015-07-20 16:33 ` [dpdk-dev] [PATCH v5 2/4] bnx2x: driver core Stephen Hemminger
2015-07-20 16:33 ` [dpdk-dev] [PATCH v5 3/4] bnx2x: driver support routines Stephen Hemminger
2015-07-20 16:33 ` [dpdk-dev] [PATCH v5 4/4] bnx2x: enable PMD build Stephen Hemminger
2015-07-27 9:42 ` Iremonger, Bernard
2015-07-27 13:29 ` Thomas Monjalon
[not found] ` <D1D5DCEA.A5E3E%harish.patil@qlogic.com>
2015-07-27 2:09 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4802193.YkiD4yNaLb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).