From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id E5601C4BC for ; Mon, 27 Jul 2015 04:10:22 +0200 (CEST) Received: by wicgb10 with SMTP id gb10so91945145wic.1 for ; Sun, 26 Jul 2015 19:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ymeanOJy9KkNA+ij1Dzu68zJUizMSMjmBKWisTMJmbU=; b=cCcvRBZSm8mi+NBFM4+VFVsAMUEQyAEH1C9uwoLTObWBlU2SN2PHapPETK6a381JEu gdd9lZ6RHI+x5ixyMDvUdr+spB5qkic8BePZh+zF5+0cQFDCega7FfQa7espsWYqcrXM qGY+w1J7io3p/HZla4Bx88CwEtedVP7yE0qV0WbWYF7mnfXFxjrwzzJ6rtdl9IrXfPqO DcvylhdFYzn3TzWEvLScaWXtGkdIc9MPo5yn+9jRhH5FqcsTPP+68fM+4K/7FRXIgZzu oDov5l1tQWMhnm151UDzAcsZUND3jxa/o/X6FZwZx1QdAoMZsxPuYNIKKABvdTO9ovpE uF/g== X-Gm-Message-State: ALoCoQlkCHHX8tUEIgfsN6kx8s2nhsN+e+jVokGJ5ndX/FZ0wtqYnkJIkoKU2/ySZIOHB4nZqGk7 X-Received: by 10.180.88.8 with SMTP id bc8mr18969715wib.19.1437963022778; Sun, 26 Jul 2015 19:10:22 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id i6sm25195643wje.33.2015.07.26.19.10.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jul 2015 19:10:21 -0700 (PDT) From: Thomas Monjalon To: Harish Patil , Stephen Hemminger Date: Mon, 27 Jul 2015 04:09:01 +0200 Message-ID: <4802193.YkiD4yNaLb@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1437410000-15907-1-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 0/4] bnx2x: poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 02:10:23 -0000 > >Stephen Hemminger (4): > > eal: provide functions to access PCI config > > bnx2x: driver core > > bnx2x: driver support routines > > bnx2x: enable PMD build > > Acked-by: Harish Patil This driver is too big, its style do not comply with the DPDK coding style, there is no git history (drop all in 2 patches), there is no documentation, no BSD support and it has no maintainer. However, any new driver is welcome and can get a chance to live in the DPDK repository. That's why it has been applied. But next changes must be clean, even if it implies a big refactoring. In case its maintenance cause problems and no declared maintainer can help, it will be dropped. It has not been tested with all supported compilers. Please be prepare to fix the compilation shortly.