From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com
 [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id E444168D9
 for <dev@dpdk.org>; Mon, 24 Mar 2014 21:59:34 +0100 (CET)
Received: by mail-wi0-f179.google.com with SMTP id f8so2837109wiw.12
 for <dev@dpdk.org>; Mon, 24 Mar 2014 14:01:07 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Wy8mwx8QPupIyvQL5soyDb5cBwD8KG74IZ9MklLSO7w=;
 b=VBSpDmqKBuh+pPy7fplLELk04H421u/N83i8G+3lP07B92X57u2Gb60ppgNNgy3T02
 HRlyHkIMlgu4HK4sSnFfjYrlPJsCzkGO7bSNzcflVFGPXqEcog9/RW09hLUYZmmmSp/Z
 0OzydBN/BjKcMtTpgZzLCkclUqEZMBSRN86OOuYKZBzUG6I1KW7jJExSiFBvhitaATuG
 Hd+7QzF5rCIPp9uluCRz7X2+QnOtPM1XbqVYY2CHTJ9r8ovmIBqWQUlh30r0vlDCVCmy
 8Snkh81B0lr3mphT1GbTXJHKFb5JzfOSqpv1h356vq59ov321s23+QDcHdMV149KF0eW
 aRPA==
X-Gm-Message-State: ALoCoQkY+5vzknXgcoUiXO/ffbNZwllrmALWpuGF/te81PGbTXgQmN7exgolEhmHPOJfhTYghulm
X-Received: by 10.180.9.42 with SMTP id w10mr17601097wia.20.1395694867648;
 Mon, 24 Mar 2014 14:01:07 -0700 (PDT)
Received: from xps13.localnet (abo-213-55-68.mts.modulonet.fr. [85.68.55.213])
 by mx.google.com with ESMTPSA id
 n3sm42921838wix.10.2014.03.24.14.01.05 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Mon, 24 Mar 2014 14:01:06 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 24 Mar 2014 22:01:05 +0100
Message-ID: <4807409.VkCA9iV8rJ@xps13>
Organization: 6WIND
User-Agent: KMail/4.12.3 (Linux/3.13.6-1-ARCH; KDE/4.12.3; x86_64; ; )
In-Reply-To: <20140307181430.240987691@vyatta.com>
References: <20140307181335.024904493@vyatta.com>
 <20140307181430.240987691@vyatta.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 5/6] xen: dont create dependency on cmdline
	library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Mar 2014 20:59:35 -0000

07/03/2014 10:13, Stephen Hemminger:
> The driver should not introduce an unnecessary dependency on the cmdline
> code. We don't build that code since it is not used in our product.

Your product is not the concern but I agree this dependency is unnecessary.
I'd just remove the comment about your product.

> +/* defined in <netinet/ether.h> but that has conflicts with rte_ethdev.h */
> +extern struct ether_addr *ether_aton(const char *);

It seems we should fix this conflict first.
I think the problem is about libc redefinitions in rte_ether.h.
Patches are welcome.

-- 
Thomas