From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ADB3A1B1A0 for ; Fri, 6 Oct 2017 01:34:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 281F720BBB; Thu, 5 Oct 2017 19:34:10 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 05 Oct 2017 19:34:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=LTToXBFKWB0qvt/ Nb835kkYEbkS9IDobpuYhKeZBEGg=; b=BEdioO16lW2Nf5Yw0oZ3uQKfzK9X/jv G2dwCmetsKvAvROSVFgWOrWCD7qj0PnLnqTeOkWdp24V+3C6rov59PWxgnnO8KF+ G8dromS4Dt9RhQFt5tJ7B4D7ZnuCBT4hhZl/y5H8IRq4K8f9XEtJvGgWgM+quENh vfyJ1Ezx62Wk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=LTToXBFKWB0qvt/Nb835kkYEbkS9IDobpuYhKeZBEGg=; b=cksubQjY Lb9gmBoeRXslreKQ8OxY5H9eKl5Z5pSdsYuri7ERwciLj4DUnZESXwc1hyVq+3Vi Whd3O/e63cv4VEaj6HA3pm63v9AGffwwdAPxbZFQXFazxIkAJULZQ/Cykj9gvfpS nbR15Z0eeJNvbdoV+mwU1Hl8BqZw3cVu0OND8Uw648QLGfp4tuY2YEBYH9p88mjt fIqXADbBCGFtgJ8y4qn58otzY4tpAERDtHpgNfxhCPM9OzvQStyqtLyD5aL+s8Im a1jvXBDBo8+lDWqJ5xPNpI7unGHPjESu39r3Ja6QH3sJEQEubgsmUria1yGsNUqE EMg3LF4I12l6Yw== X-ME-Sender: X-Sasl-enc: wiqKoFNMUI/p740um8lgJZPZysVr+0NtSXVh1GN5uFbi 1507246449 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CA13724009; Thu, 5 Oct 2017 19:34:09 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal , shreyansh.jain@nxp.com Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Fri, 06 Oct 2017 01:34:09 +0200 Message-ID: <4808052.LEHOq8oruM@xps> In-Reply-To: <1505558149-28884-2-git-send-email-hemant.agrawal@nxp.com> References: <1505558149-28884-1-git-send-email-hemant.agrawal@nxp.com> <1505558149-28884-2-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: update MC to 10.3.x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 23:34:10 -0000 > Signed-off-by: Shreyansh Jain > Signed-off-by: Hemant Agrawal This is a huge patch without any comment! It will be hard to find bugs in it when debugging in future. And it will be also pointless to reference it in future fixes. >>From a quality point of view, it is bad. As it is touching only to dpaa2 stuff, it is accepted. I do not want to be the one digging in it. Please avoid such patch in future. Applied