From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 056D5683A for ; Tue, 16 Dec 2014 11:16:57 +0100 (CET) Received: by mail-wi0-f175.google.com with SMTP id l15so11732635wiw.8 for ; Tue, 16 Dec 2014 02:16:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=K6CF1EQ4JRojww7lFzDuj8J/o4y6nijvb5vAgGHTTO4=; b=OFJI/oS0+nZV9W1vyctlFlLAgnaqxey8iyp2ZGzfSIfooNxup3r6VIzUa1h81ZUQD3 61AN9cZgBmeLV8i+O8d6KDjuAP8CVmWyGxKlVnBoxb6jXTsb1MHvNKYoURHuK70hx7tI x92Ps36VwJO/cQe/xveAJHMxWBT+U5aGMccipEYy02lFEEkAsEFqQ967O601pUt6iTuA u5o7qtYOXZEAC/qlLnd0lPRRAdfbT62SiPalag11qciuUdWSK0GSjfQJqNIDh/GErsBr q8dsby9KTmOJ28pO6a/8p+5RkpfnmomqGLiN4f0KQLivDaS7qbPaOXD2W01v9s5xIHlK r4hg== X-Gm-Message-State: ALoCoQm36mYCEvDrNA8SXuZL4DazwMQbl29NKDZmkuJ94RokeDeE2aqROWwV3Gyd8h7m2AwGtKwi X-Received: by 10.194.190.19 with SMTP id gm19mr60621655wjc.51.1418725016796; Tue, 16 Dec 2014 02:16:56 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ck7sm533816wjb.13.2014.12.16.02.16.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Dec 2014 02:16:56 -0800 (PST) From: Thomas Monjalon To: "Sujith Sankar (ssujith)" Date: Tue, 16 Dec 2014 11:16:31 +0100 Message-ID: <4809836.L3g8ubUa2y@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1418372303-31565-1-git-send-email-ssujith@cisco.com> <533710CFB86FA344BFBF2D6802E60286CA02DA@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 10:16:57 -0000 2014-12-16 10:00, Sujith Sankar: > On 16/12/14 1:21 pm, "Qiu, Michael" wrote: > >On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote: > >> On 16/12/14 4:54 am, "Thomas Monjalon" wrote: > >>> 2014-12-12 13:48, Sujith Sankar: > >>>> This patch corrects the usage of the flag VFIO_PRESENT in enic driver. > >>> > >>> Please, could you explain why the flag VFIO_PRESENT was not well used? > >> > >> Without including eal_vfio.h, VFIO_PRESENT is not available in enic. > >> Hence VFIO specific code in enic was not getting compiled and some errors > >> were generated during run-time. > >> > >>>> This has uncovered a few warnings, and this patch corrects those too. > >>> [...] > >>>> --- a/lib/librte_pmd_enic/enic_main.c > >>>> +++ b/lib/librte_pmd_enic/enic_main.c > >>>> @@ -39,6 +39,7 @@ > >>>> #include > >>>> #include > >>>> #include > >>>> +#include > >>>> > >>>> #include > >>>> #include > >>>> @@ -46,6 +47,7 @@ > >>>> #include > >>>> #include > >>>> #include > >>>> +#include > >>> > >>> This header was not designed to be included by PMDs. > >>> It will break compilation on BSD. > >> > >> Is there an alternative to make VFIO_PRESENT available in enic? Please > >> advise. > > > >You can remove VFIO_PRESENT check, it all been done in eal, you can > >check other nic pmds for reference. > >And seems you done the interrupt logic all by your self? > > > >Thanks, > >Michael > > Thanks for the comment, Michael. > > Without the code under VFIO_PRESENT flag, I was getting false notification > of interrupt at the beginning (cat /proc/interrupts showed all 0s). > Let me try to root cause it. I shall get back after some debugging and > testing. > > There was one more reason behind doing interrupt logic in enic. No matter > how many interrupts the user configures, enic pmd needs only one. > There is no way to communicate that to the EAL. I thought doing interrupt > login in enic could avoid registering that many interrupts. If you think something is wrong or could be improved in EAL, it's really better to patch it instead of workarounding in the PMD. Thanks -- Thomas