From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C31A5A00C2; Thu, 10 Feb 2022 13:32:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64F21411AE; Thu, 10 Feb 2022 13:32:40 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B0FDE4013F for ; Thu, 10 Feb 2022 13:32:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644496358; x=1676032358; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=i+3nP1uMPNRPw7TyqzNBNP+9eZJ6YbyJKOsiC+La7bI=; b=WpndAIpdRcLVC1Hx/qb6Rq3ChCG1UzHflf5zx5q61HuV4znXiVAjF+uz tdsyV2PYX5kdsbMzfOFVwikEgWDIC8fZUPMqBNTEQZY2MDb1uHkAwbWxW J1SXMHhn3gLJB/8MQDhi73O+3IQc3XPUmIwsAkKqNFnKVwkyGj8l8Z2Ni yTYS697BX6ln1vzPaWj9cHD1/M3NAsh7YEfMRWn3kVpi/t0Z4cvEJz9z7 Dr6WhpvkE0K18LRs6IXWWxTgRpKjdUL8T/+K7mGa1kZmc9C/owEDq1YvZ xQ6EUPSTOXv3LtOmzF2DpIC0kXPFN2SLIb6QkpPF0yC1er24W7wJOM9Eh A==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="230125241" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="230125241" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 04:32:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="622664112" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2022 04:32:33 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 04:32:33 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 04:32:32 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 04:32:32 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 04:32:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lusxlw2JlPaDcP5g1ALUYkn0foj5kWyZ0g2ZFOVyo32EYPpwjBpj/hEzMNsVSBTHA9oao6XCnPv2JO4ZmqbaX5txiH18ek7uUPKPipFp0G5R4tG9bhHNehtzoUme5N6RMkCqYOfdRiHOpPAkylTEdodfAeorrPqlx0RqPiYUCLgZ0dLjlzYYNLdRO3GzN193ZRQS5F+UMtwdWZPV0+WjTgG+fhd5wKf7PzbG9qzwmwqHXRQx9Soh3aU5+ACStbWM32nh0Gb/IbciNC938KG0dDD+frgR8IAWP44JpL9gWyby3OpXOwJs1a1Ri93A02ZD9hWjEYsN1ypuQBvGeUqc7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YAWeAOk3nUFfbirqK/QRbcPq+BEkIXwYw46wu/vbcvE=; b=VdtUQ3diVgN6e47+lIgRQX2Xi9Q9bQy+rU/sJoyBofydF5m3O7Ze+cpuMMxvFoOCL+ks/Tzqu6aLSwAmWQb54p8oyDyG6RPvqG7zjw7+bTtvWpZ0gq0Ja7qAw5RVrMwPekGx+tnEcW2YQafoF9vCxo5Tmk0dirmcnOR+rzO0BcPz/wEI99wQ17lmnXJC90oyhXiKI+YQLGcDzkI9XtdOb6V43TCDOjYlosA/0ud0BRB8L27YrbddB2RktAi2m1ZS86o5wsYoN5MAZX2aiIIpIz96IQ4fblNX7MLpIAHUFqJAGYTn+X63ldim9nQG2/Z2CIg2z+Io+/SKQ+bD/Bne7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SA2PR11MB4892.namprd11.prod.outlook.com (2603:10b6:806:f9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 12:32:31 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 12:32:31 +0000 Message-ID: <480b7433-2d7b-be1f-ec52-40ab25006627@intel.com> Date: Thu, 10 Feb 2022 12:32:25 +0000 Content-Language: en-US To: "Min Hu (Connor)" , CC: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Ray Kinsella , Ajit Khaparde , Thomas Monjalon , Andrew Rybchenko References: <20220111115437.32855-1-humin29@huawei.com> <20220209012106.23404-1-humin29@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH v3] ethdev: introduce dump API X-User: ferruhy In-Reply-To: <20220209012106.23404-1-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0069.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 421b0e29-ff1c-449b-fd53-08d9ec91681f X-MS-TrafficTypeDiagnostic: SA2PR11MB4892:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NrWdpOyonzhoJ9G1zXz6mp4zlZRJxW6/6bms10NR40/78qre0MiLA9/FP1vRD8AMg7BKgpG0sPtpUhEL6QI1rfZlYrrFjG6r25NJo1bzFrx862cNsX2lqLBNo7KCdh3LIggkDlb8BSKJS6EdGvfl8H7quxDwgcQh5QOZ9Dt+VhtP+YisL3fKt324ViB7uPHIzxKU/x21fv7ICxWso4mcaHadCym/Eu0WajuPhbqxLT06Sd0nlEP0trZEJw7nOJcqkzbGJ7WknnEzMsyWStR1mQL1WaLZEMggRtbv3uymTtB2DBWKpvolarZ34UF6FPCyktvbJ1y8KRxfWTldErk1tc9fJFYz77GJwX53ytjmOUjaP5nyT3i6i90erJvcovogE0L/FaHgM6GoDJ3a1/AnL4lSoaL2In6H8qmstExqZw5BhHqiY0cTSQ6wO6cpL1oidZ/+OKkAcaaRTSNNtFoC9bGDfm37RU8LsZQmoZriKCcQVGpQab1Q9tUthmw5id34j1sUI6HrwHVIkv3koVOGdE29+gPETK9wcHXrI8miDRYCZsHZjV3X9N0EMGLP9t5uFR1kay3dkbSadc1Fd1JPpcTZNWNTfixhSyIX4WG42CT3CdeDa4xEDeoyKCUYdKTP62R2Oqnfb4MS3szTEzK1CBRpPEkQ+PdxLgnGDNFCIiRXRoCUA5VHCLw7S5qOY5+m/YPH6c2Tf+cXS2CMIGYksg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(44832011)(54906003)(2906002)(36756003)(8936002)(508600001)(5660300002)(316002)(31686004)(6486002)(6512007)(6506007)(6666004)(2616005)(53546011)(55236004)(38100700002)(66574015)(26005)(83380400001)(4326008)(8676002)(66946007)(66556008)(66476007)(82960400001)(86362001)(31696002)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEJyWW1XbmIzamRPamNncHAwa0g3c01rUDF5aWVCTERzbEFVMkZWaUpIYTg3?= =?utf-8?B?alUrOFc2enplc0tmUjJ2ZjJqOE9CWTVJSFdiZEJWL0RobVdYVTZ6MFRVOWo1?= =?utf-8?B?aU1lWGpSbHg1V1daNk5hcW9ZWG1QK3RKeGh5WVdBZmVQaFB4MUVLYktSVHhh?= =?utf-8?B?akRZQmV2RGRIVVk1dklqUlNsRHFPYTlJNGI0MHNybTEzWThCN1lZbjl0WS93?= =?utf-8?B?Um1UY2FGblh3dkdEN3BJRnVnZHJpRjUwTzBqL0RxSTF1QjJkSDlERXREcXRa?= =?utf-8?B?cXcySDhBQkNPcW83RkFaRHBEeVEwNCtpNmJlc1ZyRjdhSEg3SUVnZE03anNO?= =?utf-8?B?bHpaMElxQThBd3JTQXZod3FCUHBHaHowdEY4UU9MODRDMGRja0pBRUQ4SkpG?= =?utf-8?B?enI5bTkzaXloaWFTUHpDemRobHkzWGFDazFRWDV1aHZrY282Vk5MSWhoL0w1?= =?utf-8?B?VkFWZTBzMVpIcFcrQ20wTVdXYjZBNklvd0J5OGM0U2swTU5aU0NudlVzd2JO?= =?utf-8?B?ZTA2ZUx3UVFYZVU5U1Bra3BncFY4dHRWWTR1NnFVanhucmhwNWMzYkJrS25H?= =?utf-8?B?WVZpa2RqZkVUYXNuSkd6eWkvdDdPOHVCaHVCbUpxVDB1czF0eFMzYVhCQnFz?= =?utf-8?B?WGFQaGlNdVVMelVyYmVyUmNGak44bGNSeE9zUmRwQWNrWDBBRGp5SWhvTllM?= =?utf-8?B?dzNpcFQ3VHNKUnBKSXIzK0pEYldqMUZ0aExlV1FvNjV6R3MvbGdiZ0ZYSkhW?= =?utf-8?B?cmxFL1lnY1gxek03QUpaYWtNTUZMaW1UMTZ5VmVJK1dvOHRXclR4MEx3aGNC?= =?utf-8?B?Qjc2NHFVdTdvZS8wcmdMblYvenR4dCtxMTRQa1JzQnhSOHE4bUlmRUhmV2xL?= =?utf-8?B?V295NWhicElNUER0WWtqakdxeENaVUlQZnpTV2MzZEdzQzZXT0kzdXRBOUJ2?= =?utf-8?B?eE9NY1pvUWhyTkdVVm13UDV4bGMrczl4cWpLTXdxa2RPN3RXWDliNko2VlNa?= =?utf-8?B?dVJsMFFCbTZ0dmJoa3kvR0s4RklEaTUrV0N5aDlsYXEydC9zSlZZd29iTVVI?= =?utf-8?B?dHpzMm1aYmdFZFcyci9WbGhaRFJRU3JjcnVidGZRcHJYcFFoYW5nVVhoNUpz?= =?utf-8?B?SVN3QkZ4cGhTYjNRZGgvQTliQXJEdGFYWHBwYlowS0ltc2d1NjUxUWN1UHJx?= =?utf-8?B?NGRXYlFUdmNWY3VvSTgrQUl5OVFKYUViNllhNjk3bGFlMS9jWVBnQW0zUllv?= =?utf-8?B?QzZXL2NtUXZDY3d6RVJYc2VjWk5zL3crZ0tGS203NVlPTnlGZkM0TjJwcStL?= =?utf-8?B?Nkp2YlVma0tVdGFjWTVFTFpadWtxK1VVUkRwRUpjQzdzdUxPTzgydWk2Sll6?= =?utf-8?B?TW5EbEJVUEIrbDU0bVhFYzBLb3orVTMxMWZHbXpKNFpaZVhxVjA4K1FJRUNI?= =?utf-8?B?cjV1eHhzNXN3L1pPUmF3eDJBNDlxVkY1WGxhU0Fvd2c3aGRTSHpzaDF3aW52?= =?utf-8?B?NGR0NFR4V1VCVmhnQ3dEakxVUlowZDUxd1o0anFYcTZPaEV5NlRCWHBzK2or?= =?utf-8?B?MThYMzFUWkd2R3M2RkdNS0JsMXBpb0pRdGQ2NnhiUFJEc29jVzJKRTdYYk9z?= =?utf-8?B?UHpxQUZYMCtlWkZOTndVcXVTVWRPdUZEb2c4b1dOaStmNkRLMllEMnNDSXIv?= =?utf-8?B?OVkzRzdtQk5QeEZsRkNPSDlwcVJRa1RIT2ZUUXF0WjlsZUV4THVhU1BBQjVY?= =?utf-8?B?T2tjMGxTYWM0YUh0OUdManUyQ1FtZHo2c00wY3JJb3RLSDd3YThMczlXdFpP?= =?utf-8?B?SFZlSXVWb1BEZ05nYS9Cai9ZQ0FHRVpjQmJzR0xCUUE4Zmh6NFZ5UGhEL1JQ?= =?utf-8?B?VXZWa2FoNlJmSGRNcDJjN0IwNVBwbCtGTnFWVkdCM2hpMW9wRXdGOUxOMDE1?= =?utf-8?B?OGl6ZWNXYng0MG9rbW44VExHRlE5Q2t1MnlXUDJ6ME1TNVZoNk1WNHhoTDVk?= =?utf-8?B?WDFhWFpQVGZOejdwaGRQNGVrRXliRnlOYWl1VytrbDJYTjRTbUREQTZLOXcr?= =?utf-8?B?TkMzRUtXMm95aWZ2SGd0UEtDREhoRjE4cFdQdXNrQWYxbDZyT3dSM05KdVdK?= =?utf-8?B?WHZvVUZqdkNtRWtiejdBaHZRT1BjUW13ZUVST2FYRm9pZnhhc2ZieGRXMjVM?= =?utf-8?Q?OYNuF3ahzX4pHGC7598JpN0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 421b0e29-ff1c-449b-fd53-08d9ec91681f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 12:32:31.3944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vdbLur8LNL/SEihiTWzKGJmPSeT1L/yjrwNehAB7tiJarXQtozdqOf063ZSfiod86a5Z1UGfN3pdiwW+SGMdEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4892 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2022 1:21 AM, Min Hu (Connor) wrote: > Added the ethdev dump API which provides querying private info from ethdev. > There exists many private properties in different PMD drivers, such as > adapter state, Rx/Tx func algorithm in hns3 PMD. The information of these > properties is important for debug. As the information is private, the new > API is introduced. > > Signed-off-by: Min Hu (Connor) > Acked-by: Morten Brørup > Acked-by: Ray Kinsella > Acked-by: Ajit Khaparde > --- > v3: > * change 'ethdev' to 'device' > v2: > * fixed comments from Ferruh. > --- > doc/guides/rel_notes/release_22_03.rst | 7 +++++++ > lib/ethdev/ethdev_driver.h | 23 +++++++++++++++++++++++ > lib/ethdev/rte_ethdev.c | 17 +++++++++++++++++ > lib/ethdev/rte_ethdev.h | 20 ++++++++++++++++++++ > lib/ethdev/version.map | 3 +++ > 5 files changed, 70 insertions(+) > > diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst > index b20716c521..0e3d3ae365 100644 > --- a/doc/guides/rel_notes/release_22_03.rst > +++ b/doc/guides/rel_notes/release_22_03.rst > @@ -64,6 +64,13 @@ New Features > - ``rte_ipv6_udptcp_cksum_mbuf()`` > - ``rte_ipv6_udptcp_cksum_mbuf_verify()`` > > +* **Added the private dump API, for query private info from device.** > + > + Added the private dump API which provides querying private info from device. > + There exists many private properties in different PMD drivers. The > + information of these properties is important for debug. As the information > + is private, the new API is introduced. > + > * **Updated AF_XDP PMD** > > * Added support for libxdp >=v1.2.2. > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > index 7d27781f7d..a0bd066ab3 100644 > --- a/lib/ethdev/ethdev_driver.h > +++ b/lib/ethdev/ethdev_driver.h > @@ -990,6 +990,26 @@ typedef int (*eth_representor_info_get_t)(struct rte_eth_dev *dev, > typedef int (*eth_rx_metadata_negotiate_t)(struct rte_eth_dev *dev, > uint64_t *features); > > +/** > + * @internal > + * Dump private info from device to a file. > + * > + * @param dev > + * Port (ethdev) handle. > + * @param file > + * A pointer to a file for output. > + * > + * @retval 0 > + * Success > + * @retval -EINVAL > + * Invalid file > + * @retval -ENOTSUP > + * Not supported > + * @retval -ENODEV > + * Invalid port_id For dev_ops (eth_dev_priv_dump_t), I don't think '-ENOTSUP' and '-ENODEV' are valid errors, those cases covered by API before dev_ops called. Also '@return' is missing. What about below: * * @return * Negative value on error, 0 on success. * * @retval 0 * Success * @retval -EINVAL * Invalid file */ > + */ > +typedef int (*eth_dev_priv_dump_t)(struct rte_eth_dev *dev, FILE *file); > + > /** > * @internal A structure containing the functions exported by an Ethernet driver. > */ > @@ -1186,6 +1206,9 @@ struct eth_dev_ops { > * kinds of metadata to the PMD > */ > eth_rx_metadata_negotiate_t rx_metadata_negotiate; > + > + /** Dump private info from device */ > + eth_dev_priv_dump_t eth_dev_priv_dump; > }; > > /** > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index 917a320afa..5ee316a3c0 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -6485,6 +6485,23 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id, uint64_t *features) > (*dev->dev_ops->rx_metadata_negotiate)(dev, features)); > } > > +int > +rte_eth_dev_priv_dump(uint16_t port_id, FILE *file) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + > + if (file == NULL) { > + RTE_ETHDEV_LOG(ERR, "Invalid file (NULL)\n"); > + return -EINVAL; > + } > + > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->eth_dev_priv_dump, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->eth_dev_priv_dump)(dev, file)); > +} > + Can you please move the function up in the file? Bottom of the file is for static inline functions, APIs are above the "#include " line, can you move the function above that? > RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO); > > RTE_INIT(ethdev_init_telemetry) > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 147cc1ced3..e6ea294402 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -5902,6 +5902,26 @@ rte_eth_tx_buffer(uint16_t port_id, uint16_t queue_id, > return rte_eth_tx_buffer_flush(port_id, queue_id, buffer); > } > > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Dump private info from device to a file. Provided data and the order depends > + * on the PMD. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param file > + * A pointer to a file for output. > + * @return > + * - (-ENODEV) if *port_id* is invalid. > + * - (-EINVAL) if null file. > + * - (-ENOTSUP) if the device does not support this function. > + * - (0) on success Can you please list "(0) on success" to be consistent with (most :( of the) other comments? Also need to add "(-EIO) if device is removed." too, which can be returned by 'eth_err()'. > + */ > +__rte_experimental > +int rte_eth_dev_priv_dump(uint16_t port_id, FILE *file); > + > #ifdef __cplusplus > } > #endif > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map > index 1f7359c846..376ea139aa 100644 > --- a/lib/ethdev/version.map > +++ b/lib/ethdev/version.map > @@ -256,6 +256,9 @@ EXPERIMENTAL { > rte_flow_flex_item_create; > rte_flow_flex_item_release; > rte_flow_pick_transfer_proxy; > + > + # added in 22.03 > + rte_eth_dev_priv_dump; next version needs to be rebased on top of next-net, because of other APIs merged, fyi > }; > > INTERNAL {