From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1E34A0597; Fri, 17 Apr 2020 19:23:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3393B1EADA; Fri, 17 Apr 2020 19:23:48 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0CE8C1EAB9 for ; Fri, 17 Apr 2020 19:23:46 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6DF445C010C; Fri, 17 Apr 2020 13:23:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 17 Apr 2020 13:23:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=v08BwRKLv7NjMxRhD6Wm4E/gFHrrrs7heFAjTY2nTLk=; b=oL2TQS+KEOg6 bIvIpIqKtaOj9OhgjMh3vczGjXF8dlEsjesGwnnVJXhJowp5so4HQ13k75wOXU7E HL2WIh9wctmeb8ZROqePXU0SK2ol8SRACiGdBWv5I6540Tuy1ddIzeKcTPRT5Iro 63zNEdnz8tgdKh0PaoR4CNmG5+xVwVs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=v08BwRKLv7NjMxRhD6Wm4E/gFHrrrs7heFAjTY2nT Lk=; b=26wxnXAuYDD/rBhy8DsUwyjv61bOF93DjueUmX12WxctlXdYwbQe0+2RJ Yl8tj5/ubBHSEq/6DuYCmRw0sR3nWLdIb4mEOn/ex0sRDJkZ4Gjf+vu5OtFzIY4q uVh+9yDh7vGrBKiN4kAd0b8lGeD69URn+sskcEXKOQ0Qsz0L7m351u1ns4at20f8 2mcMh+2KevDPkSm8208Z3WLPX/c5AdWSdOMQ+yW4UK9InvrNnDtf+L+KgOIL6J8S FWwaQoV2qdZnnw5zWafKwBVTpfph/DCZhjDMUaSh3mWOp9+9cvCOVGo9Uf0S9Hpi DYK5zUGepjKk+wH/creoeeEoMMMvw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeejgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehfihhrvggvhigvrdgtohhmpdguphgukhdrohhrghenucfkphepjeejrddu feegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C85E3060065; Fri, 17 Apr 2020 13:23:43 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Ivan Dyukov , mb@smartsharesystems.com, arybchenko@solarflare.com, Maxime Coquelin Cc: dev@dpdk.org, v.kuramshin@samsung.com, amorenoz@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com Date: Fri, 17 Apr 2020 19:23:42 +0200 Message-ID: <4816966.qqrk5fENW1@thomas> In-Reply-To: <173e946b-0886-46ce-6d73-8fbb6a5a4232@redhat.com> References: <20191212085012.9170-1-i.dyukov@samsung.com> <173e946b-0886-46ce-6d73-8fbb6a5a4232@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 1/7] ethdev: added UNKNOWN speed value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/04/2020 17:54, Maxime Coquelin: > Hi Ferruh, >=20 > On 4/17/20 5:44 PM, Ferruh Yigit wrote: > > On 4/17/2020 4:14 PM, Maxime Coquelin wrote: > >> Hi Ferruh & Andrew, > >> > >> On 4/17/20 8:40 AM, Ivan Dyukov wrote: > >>> Hello Everyone, > >>> > >>> Ook. I can take care about examples updates. link_speed could be prin= ted=20 > >>> in following way: > >>> ("link speed %u%s", link_speed, link_speed=20 > >>> =3D=3DETH_SPEED_NUM_UNKNOWN?"(UNKNOWN)":"") > >>> > >>> Please let me know if you have any objections. > >>> > >>> There are about 47 cases. > >>> > >>> $ grep -rn link_speed examples/ app/ doc/ | wc -l > >>> 47 > >>> > >>> Thanks, > >>> Ivan > >>> 17.04.2020 01:14, Thomas Monjalon =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >>>> Hi, > >>>> > >>>> Please look at an update below from ethdev co-maintainers. > >>>> > >>>> 16/04/2020 14:42, Ivan Dyukov: > >>>>> UNKNOWN speed equals to 0xffffffff > >>>> [...] > >>>>> +#define ETH_SPEED_NUM_UNKNOWN 0xffffffff /**< Unknown */ > >>>> This approach is being rejected in another thread: > >>>> https://protect2.fireeye.com/url?k=3Ded2d2a70-b0fe73ce-ed2ca13f-0cc4= 7a31ba82-80584d32127c24cd&q=3D1&u=3Dhttp%3A%2F%2Finbox.dpdk.org%2Fdev%2F42d= e4bd1-0a6c-6591-cd27-67ce692fabc9%40intel.com%2F > >> > >> Would that work for you? > >> I would need your ACK before applying the series (which I planned to do > >> for -rc1). > >=20 > > Hi Maxime, > >=20 > > There is another patch from Thomas that targets this change only [1], a= nd it is > > waiting for change request, because the scope of the change is larger t= han just > > defining a new macro, documentation & sample/test applications should b= e aware > > of this new speed definition. > >=20 > > Instead of this patch, this patchset can wait [1] as dependency. > >=20 > > Or if this patchset is urgent, perhaps this patch can go in as it as an= d Thomas' > > patch can replace it later with full implementation, if Thomas agrees. > >=20 > > And not sure if it is good idea, but perhaps this "unknown speed' can b= e used > > local to virtio until [1] becomes ready, though I am for having this as= last option. >=20 > I was replying to my mail after discussing with Thomas. >=20 > I agree Thomas's series is better, and now understand this is an API > change that was not announced. >=20 > What I propose it basically to apply Ivan's v8 with a few fixes on top > that he did. It means that if no value is set in the NIC or not value > defined as devargs, then 10G will be picked as default. >=20 > Note that the 10G value is the one currently displayyed, without Ivan's > series, so it seems a reasonable temporary solution. I am OK with the suggested solution for virtio in 20.05. Any help to implement and document unknown speed is welcome. I won't work on it during the next 2 weeks, so feel free to take over my patch and make it complete for 20.08.