From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78B7FA0524; Thu, 4 Feb 2021 21:25:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D5382407EC; Thu, 4 Feb 2021 21:25:38 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 3D3E42407DE for ; Thu, 4 Feb 2021 21:25:37 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id q72so2361472pjq.2 for ; Thu, 04 Feb 2021 12:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yMGwiyo2/sQLqcE1869bfJsFU9kOkiTpymmO0lnHFdQ=; b=wsshjz7yUs68md0tQY+Jpeyv6n6jZAsyjrg0Vwrej6tmG/zWQR7UJsYPWTbIZrGFrN 7h6I2hDT+XYWODY+z0Bvo+VUKW0Qcpu8eTT2QbMstHDVn35lCXfrCIpdCzI3vGJWD9Bh sSQMlEdLMgOK2sdjbHcrgnsW/Fsxvqt224KuqHl73mE4BzrP+V4Ai9cAngMk5iVHaj7d xYlq5dApZ+RsYUkOFvtwaGEHVUHf/e57VtOjRJKYfDvGTY55FHH4WJCn8Jo9cxpY2w1w y4E+Lq/vJFzOQcUo7uasJd8HUv85fNtOOHoKlhbQWuFP7zxGCTMSsrdhwrudnqvz2Bcp QFQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yMGwiyo2/sQLqcE1869bfJsFU9kOkiTpymmO0lnHFdQ=; b=S4kbX9RBbu4M9EwK9Yu+f/aWkgg7m7hyuxDOzB5d9oeGwX3e++GPk1GJpEMQTx6Nv4 kMtHhTOEp8KP70jYKaFUlyHtW2j+fyC1D8u6twunrlpL1Y4Dywua94+fyPdLDPkPyUPx B3F4TeQpF8Xx8DZTI00b5kLs4cX/q73EzTssXaSaRm51JqH32A54kIRrhCLA23UcwJtv u+u6UYd63UsMerxe/GWbyfWM+dKJ3xuk05lkAU0CtK8ysK7SSRf5nyUZOW+dPIaRPrQ6 blFb+lWojLLBpN00wjZc8kkRDq+ogf9nNn6rfg/P9aPCcZi3yJW8ac8NQlm/oavnv+kG TFXQ== X-Gm-Message-State: AOAM530bo0xQFaCf4bKXeMF2p1N2hs0WUxVW8oy1Sx2Xi3KJXLVQg60F eSrAowcc9JH3ICgCLUuaNTTTYcWQt/UWTw== X-Google-Smtp-Source: ABdhPJxxaRQKVOeIVqPNlfAwob6g+v29I/q7EuYHoqcrfY4y5g7cjYMMSz6yTwlaipRJH53iNsBJdA== X-Received: by 2002:a17:90a:6048:: with SMTP id h8mr702683pjm.139.1612470336072; Thu, 04 Feb 2021 12:25:36 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:c526:ddbc:d170:fa03? ([2600:1700:6b0:fde0:c526:ddbc:d170:fa03]) by smtp.gmail.com with ESMTPSA id z2sm6980628pfa.121.2021.02.04.12.25.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Feb 2021 12:25:35 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: <20210204195853.13411-1-aboyer@pensando.io> Date: Thu, 4 Feb 2021 15:25:33 -0500 Cc: Alfredo Cardigliano Content-Transfer-Encoding: quoted-printable Message-Id: <48184F23-AF1F-48C4-9C5B-02FBD862FC16@pensando.io> References: <20210204195853.13411-1-aboyer@pensando.io> To: dev@dpdk.org X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH 00/14] net/ionic: struct optimizations, fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Feb 4, 2021, at 2:58 PM, Andrew Boyer wrote: >=20 > This patch series reorganizes the main datastructure for each > queue, struct ionic_qcq. Its constituent struct ionic_queue and > struct ionic_cq are stripped down first. Then the generic struct > ionic_qcq is stripped down, and a unique struct is created for > each queue type. >=20 > The adminq code is consolidated into ionic_main.c as part of the > cleanup. >=20 > Next comes some minor performance fixups related to queue posting > and doorbells. >=20 > Finally, two minor fixes to Tx packet prep and LIF init. >=20 > Signed-off-by: Andrew Boyer >=20 > Andrew Boyer (14): > net/ionic: cut down completion queue structure > net/ionic: consolidate adminq code > net/ionic: convert info array to generic pointers > net/ionic: remove unused field from queue structure > net/ionic: remove unused interrupt free function > net/ionic: cut down queue structure > net/ionic: split up queue-completion queue structure > net/ionic: use the socket id passed in for Rx and Tx queues > net/ionic: log queue counters when tearing down > net/ionic: break up queue post function > net/ionic: ring doorbell once at the end of each burst > net/ionic: send as many packets as possible > net/ionic: fix Tx fragment limit check > net/ionic: fix code around lif init devcmd >=20 > drivers/net/ionic/ionic.h | 13 ++ > drivers/net/ionic/ionic_dev.c | 132 +------------- > drivers/net/ionic/ionic_dev.h | 81 +++------ > drivers/net/ionic/ionic_lif.c | 242 +++++++++++++------------ > drivers/net/ionic/ionic_lif.h | 77 +++++--- > drivers/net/ionic/ionic_main.c | 93 +++++++++- > drivers/net/ionic/ionic_rx_filter.c | 1 + > drivers/net/ionic/ionic_rxtx.c | 265 ++++++++++++++++------------ > 8 files changed, 458 insertions(+), 446 deletions(-) >=20 > --=20 > 2.17.1 >=20 Looks like I missed the boat on this release. I will re-send 13/14 as a = standalone. -Andrew=