From: "Xueming(Steven) Li" <xuemingl@nvidia.com> To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>, "nick.connolly@mayadata.io" <nick.connolly@mayadata.io> Cc: "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "stable@dpdk.org" <stable@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v2] windows: build warnings with clang Date: Sun, 12 Dec 2021 12:06:06 +0000 Message-ID: <481aac504fe39354af57c028514a99121bc631a8.camel@nvidia.com> (raw) In-Reply-To: <607f92b6-18dd-c240-75bc-691b7851f50d@mayadata.io> On Wed, 2020-12-09 at 09:30 +0000, Nick Connolly wrote: > Copying stable@dpdk.org - given that 20.11 has now been released I > assume this needs to be applied there as well. This patch was ignored due to the backport scanning scripts check commit message from upstream git repo, not mail thread. Remember to add "Cc: stable@dpdk.org" in message body, or a "Fixes" tag. Applied to 20.11.4 now. > > On 07/12/2020 20:34, Thomas Monjalon wrote: > > 03/12/2020 01:02, Dmitry Kozlyuk: > > > On Sun, 29 Nov 2020 16:00:24 +0000, Nick Connolly wrote: > > > > Microsoft CRT defines Windows-specific secure alternatives to > > > > standard library functions and triggers warnings when "insecure" > > > > functions are used [1]. However, calling code already has all > > > > necessary checks around those functions, so these warnings are not > > > > useful for DPDK. MinGW provides its own CRT without this issue. > > > > > > > > [1]: > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fcpp%2Fc-runtime-library%2Fsecurity-features-in-the-crt%3Fview%3Dmsvc-160&data=04%7C01%7Cxuemingl%40nvidia.com%7C93c0adf5be2246c07dcf08d89c2532f5%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637431030883808802%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LJVdh0nUgUEXT9vukPmwPffPugpiDFhe7EWp2rU7DuQ%3D&reserved=0 > > > > > > > > Disable this by defining -D_CRT_SECURE_NO_WARNINGS. > > > > > > > > Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> > > > > --- > > > > v2: > > > > * Adjust commit wording as per Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> > > > > > > > > Note: It is unclear exactly which commit this fixes. It is probably a > > > > consequence of building more libraries for Windows. > > > Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> > > Applied, thanks > > > > >
next prev parent reply other threads:[~2021-12-12 12:06 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-27 11:36 [dpdk-dev] [PATCH] " Nick Connolly 2020-11-29 15:38 ` Dmitry Kozlyuk 2020-11-29 16:00 ` [dpdk-dev] [PATCH v2] " Nick Connolly 2020-12-03 0:02 ` Dmitry Kozlyuk 2020-12-07 20:34 ` Thomas Monjalon 2020-12-09 9:30 ` Nick Connolly 2021-12-12 12:06 ` Xueming(Steven) Li [this message] 2020-12-05 0:46 ` Kadam, Pallavi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=481aac504fe39354af57c028514a99121bc631a8.camel@nvidia.com \ --to=xuemingl@nvidia.com \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=nick.connolly@mayadata.io \ --cc=pallavi.kadam@intel.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git