DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: hemant.agrawal@nxp.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] config: remove useless lines for DPAA2
Date: Tue, 3 Apr 2018 15:13:06 +0530	[thread overview]
Message-ID: <482ae28a-ef73-9bde-ae06-f9983aa2caec@nxp.com> (raw)
In-Reply-To: <3161325.7B0DNJKXUk@xps>

On Tuesday 03 April 2018 12:33 PM, Thomas Monjalon wrote:
> 03/04/2018 08:55, Shreyansh Jain:
>> On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote:
>>> Some comments are not relevant in a config which only overrides
>>> the default config.
>>>
>>> The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled
>>> by default so it can be removed from this file.
>>>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>>    config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 -------
>>>    1 file changed, 7 deletions(-)
>>
>> I think DEBUG_DRIVER should exist in local config so that a developer
>> can easily toggle it without modifying the common_base, which should
>> serves as repository rather than toggle.
> 
> No, the file to be modified is .config in the build directory,
> not the default config.

In my environment I prefer changing the platform config rather than 
local .config as that way I can track changes through git.

> 
>> I do see the problem that having an option in common_base and then
>> having it again in local config without overriding (=n) - is non-intuitive.
>>
>> But, I still feel it is easier to control changes in local config -
>> (make T=<local config>) is easily visible.
> 
> It is not a local config file.
> The local config is .config.

Sorry, allow me to rephrase my previous wordings:

s/local config/platform config/

Anyways, this is just my personal preference - not a big inconvenience.
Thanks for the patch.

Acked-By: Shreyansh Jain <shreyansh.jain@nxp.com>

  reply	other threads:[~2018-04-03  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 22:06 Thomas Monjalon
2018-04-03  6:55 ` Shreyansh Jain
2018-04-03  7:03   ` Thomas Monjalon
2018-04-03  9:43     ` Shreyansh Jain [this message]
2018-04-03 22:04       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482ae28a-ef73-9bde-ae06-f9983aa2caec@nxp.com \
    --to=shreyansh.jain@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).