From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40069.outbound.protection.outlook.com [40.107.4.69]) by dpdk.org (Postfix) with ESMTP id 351A21B690 for ; Tue, 3 Apr 2018 11:28:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NgVk9qe9ka+jopeeV8WaljTNDfx3MMpX7t0c5JSxZFw=; b=NE0S6C+mzvYkRzTtKN9Z2HPQ1xJPwWm2/tBHO7P4FK13MxYGfofR09C1DagoeOcfK0ubnFMXKz5HjMNoUy0VSe0CVAv4ntrrzgQ4qAovUKkXecQUx02bnnBVycOkI3Ll6u231ivA0DiWZ8wkdgZEzs6UzjGAZqWDzjYt4kuNHzU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by DB6PR0402MB2776.eurprd04.prod.outlook.com (2603:10a6:4:96::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Tue, 3 Apr 2018 09:28:04 +0000 To: Thomas Monjalon Cc: hemant.agrawal@nxp.com, dev@dpdk.org References: <20180402220649.662-1-thomas@monjalon.net> <5df8c54e-a750-e576-9adb-50ff863872d3@nxp.com> <3161325.7B0DNJKXUk@xps> From: Shreyansh Jain Message-ID: <482ae28a-ef73-9bde-ae06-f9983aa2caec@nxp.com> Date: Tue, 3 Apr 2018 15:13:06 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <3161325.7B0DNJKXUk@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: KAXPR01CA0030.jpnprd01.prod.outlook.com (2603:1096:402:1a::16) To DB6PR0402MB2776.eurprd04.prod.outlook.com (2603:10a6:4:96::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 92c9a303-43d9-4d1d-b869-08d5994534d9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0402MB2776; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2776; 3:oXrHscZjYoywAy3ZWVugn5IYNJdXGPOAwKEXMnXbWDjMDBHGn+tqwLd3SwCGCr1YtvLrV6dvobEn9vPbLu1nMj8ydejG5vwVCEYSi//7QPXPkN6bJNNdBUa2soFybMHdmbF+h/5K0Yn2cB+vKyvzxV9nZ/Hokmb4i6MNCZ5I5xizTU0sQzeplQ3dRRJ5s+t+Q+GquQgbt82hfhqr48bdQ4LPmgvT0JYkS2n+0gwvDJEPvq7o/qw47fpNUQXnG+H0; 25:iFH6L9B5xRHlAkVP7QkLJj4Hpv7SDVrGjJ62LnEDf+giSc+WEttJUQQvU7jPEpxLuILEzO7rp63LQTESLImVdKZ0nxAdIKsZa5X9EbiZJR1XQAg4S9UCMlW7o+08OtInZLCAEe6a/A5C6lAR3ntDkfjIGxPPXbO9ESAohR6RqjLyzapB9rb3ouFa2K/NHxW7WRgfRnjVkpmYQo4nPLJYxDZGhvUgbwoyIK/CdpXYG4mq+j9hcbFjHIrnchVtjc/THu29FHxYf2mX/eYZG7QZa231Kbvf/kWDMfS0irsu6YtpT0GoJetA1DmKllPJRFm/pUSrmcgV4wMC1QU7cvovLw==; 31:qzDZXGtlRps+uHJelgVTSS6GTLWY4zNAE6jbktfKltJTxnaFv9CjEbm2KLosCBukYosrkDVH8Xntnb00Uoi809iRSOBMYrnGe2BuOQ59R0DWDWQ3pzjdTN5QTC0b/U5guHBi2W2hyukIGoswncdWkgGAgtorO/yxICsEpmLtkWdfGwN19L53eZIeEmeo3r3cZXDY4qenS0TSYElRUrA5MFio4PdDLYk2oUUo1Bwe4aE= X-MS-TrafficTypeDiagnostic: DB6PR0402MB2776: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2776; 20:kjQwn4D4p2VorCXorE/uxnsa7gePSJlTkNRO7mfhKj5cc3txCbuW7+oEyKiUuxaghHPOxa6TGRpACA953ytHj3xodLibqIGEGjLvLmo7lqGccMnJ4LrUemBnzGyDGmUpXvwtCcWoPXT3rzfu4rajj7BIKq59nKnDFuUMq4coWzJKAOM23akqygJQZN69xD2+KAa/X6MO+GvHbGZ6chA9roSd7rOarHgAX8TVi/BKbMQDomsL5J6AunrbJrLlS+ztftKmqx/OMcZrPKxAz3w2l81km0pU61WwSgX2jcNc3olM39RHMnxNlPd3ppEXS6xhL/4HIkmQ1omWSrzMF8iIfTlreTg8BCDAlVDNVnWRI7c2hSDjanUODenlvHGalpp5WZbAx0fq7xgDTh/T7WR0cKaDfMmPHB4eWmwBCo+SXB/HdEozLvprRVq+eaxNQq/246v890l6aow64yIEbrYkKBDcDSXKoCZpmcq/UKz79xCMFHWb4gbyVIaCNpfjW+TJ; 4:Pd5pCXqKp7OLF9dJKenNkBUsrXwB7PyUxaXKLx8fk7jhXlIMrt9SfYJjft0BmY1XQ+ZwKfKzoz4zrkXC/KvrfPxb0ym/hLtMnXGhr2DhB/Y7TVtWz5/FduYDx0eXXmujXhNtWmx4BqkOrPRsZkeZzAuTddY4bjqolL8LRd3344BvbLcZORFnuAVNXGcsWLh7p2hQtlnG/0RvA9MnPk+NXRJbEz4klHXMm4xqMJQ4ox0cAZ9F5y/gSGS2A994hmJVj3rjBFXkc9fVOJTRYCek5aFF9g5bepGWmYdcGMxiiSqMoYn1FD/yC/VloQTPqyJF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DB6PR0402MB2776; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0402MB2776; X-Forefront-PRVS: 0631F0BC3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(366004)(346002)(376002)(396003)(39380400002)(51914003)(199004)(189003)(76176011)(26005)(5660300001)(64126003)(8676002)(105586002)(3846002)(6116002)(50466002)(81156014)(81166006)(36756003)(65826007)(229853002)(77096007)(55236004)(106356001)(31686004)(31696002)(6916009)(58126008)(16526019)(59450400001)(16576012)(186003)(316002)(8936002)(386003)(11346002)(52116002)(7736002)(446003)(305945005)(2616005)(486005)(68736007)(53936002)(97736004)(6486002)(6246003)(486005)(5009440100003)(476003)(956004)(478600001)(66066001)(230700001)(4326008)(65956001)(65806001)(86362001)(47776003)(52146003)(67846002)(23676004)(2486003)(25786009)(2906002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0402MB2776; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA0MDJNQjI3NzY7MjM6RkVXbmppbitqa1NVemhFWU8vc0FkMkl2?= =?utf-8?B?MjVVM3h4QTJsQ3lHdC9FYUtWYWVIM1k3cEZOeVBacndIbEdLOTJxQ3VtZEpW?= =?utf-8?B?QU5hN0ZkNW80cHY3Q1B2Q1R5L3hlcllqbi92VERCWUg2MDRvRHcxU0tnV1pI?= =?utf-8?B?K3ZmWGxxbkNkbW1wMys2dXIwWkJyT29PNUt1cmIwM3FzRHlsNWU1akVmOUpL?= =?utf-8?B?cThIejNEN3ZzOURBdmFFdGt2Mm9Jb2JxVGRBc2ZySWtzaTFLbXJDNWl3OENn?= =?utf-8?B?N1VqT2RUbHhUK1NFOUhnR2lHOXo1V1ZHRXpxaEwwR1k1bjBQOWNsRXZlSlV2?= =?utf-8?B?Q1hnYUIyblRGbDlTQUM5V3Q1V1FMSmJ3WWVVQ092UDdzWTJHS0w1Rm1sbldR?= =?utf-8?B?R1dJaFRvZE1OZSt4SG8yYk1PbzVPenRmNHZSd1dZZEdCV1pmY1ZxeitYS2NS?= =?utf-8?B?WFFvaGsxVlh0Q0NjS2xSUGY2Y3NUcVRjYnRNUzhJZFo4R2Q4WDdyZlhMQ3hj?= =?utf-8?B?VWZqQithNTY2VkNyOHU4c24xbm1XT0JRV1NQa0ExOHdFRFlRdTdrbnd1Uktp?= =?utf-8?B?dWw0MFFjdDdqSm1hQVBwRThtMVhlanhiSTRnQWQzRlBQTVlvUC8zNnNXUUZ0?= =?utf-8?B?WFN4SURyQ2VWRDI4Z2FJbjd4Z3hrU09LL0t1alpBd01ZRGdUcXkxeTdZbmZS?= =?utf-8?B?cTRHZzF2bzFQazNOMjU1WG5jWXdFL2lWelNJaXhQcTVKb2h1ZnRYSGdvbUI3?= =?utf-8?B?c3pPbjdIR0c4VzdiT1VXeEdTT0UrT1U3UVZKNEREcWhpNjBFUE05WmxpSEhT?= =?utf-8?B?engvVTR4UWxZb0N6VVJ5Wnlxa2FzUTcwMTA2WFlQV3dEYUpuOUNTd3VjNDlL?= =?utf-8?B?U0lHd0YyemhVR3RXdEVYK1dnWEFZQlhYWTdmZ0RuY2Z0a3gzaWhycGNMUm1X?= =?utf-8?B?NHEyM0w5S1k0cU1yc29iWUFuUHIrT2syT21WZzduaWp0bWYyQXlzTHVNTitJ?= =?utf-8?B?QnB0T2h4RXNpdGNUN0hhTk5kZlNoa2YvMUxZOVlleWI0Q3ZLMDhIV1hoU3kv?= =?utf-8?B?WTluc0xuT1AvdjBFN1BNd0hzUXkxNWd4WWJUYUpocWZMR0R0QnBlMlVsdHFZ?= =?utf-8?B?VndTcTgwZjVvaDJuMzgzakNVSTYyY2NHcDQrZUtUeGJtbkxieWtrK1ZSMlVX?= =?utf-8?B?WFVZQWlZZ25xUnVJUEhXWXFQTkc1RFdEVU1zZmtUY3I3VklEeXNyT0pjVnpZ?= =?utf-8?B?NXI4QWpCQTlmc053YXlNbCtMYmhoN1QvTlFISzNmc21TQSsvWmp4Z3JZWjhp?= =?utf-8?B?QVlCbHFoSHFMWlRHZzd6QXhiSFFBV25JbVFjeUlLMmUrV0hqdHFzMGRLaTRv?= =?utf-8?B?T2g5TWZxVS9USkFtNUErWGd1REhMdE05SEE5TGMrT3A5ZDBMTlVINDlhcENG?= =?utf-8?B?NDJWek9GOFl0ai8xb0NOdGYxZzhaUW53cW9xeWRpWC8xeVBRYTAyUWx2RldX?= =?utf-8?B?MkNVdUhxaGVBMWNSQ0RtaisrYXovaHlrNEE2d0UvOWJBRCtIVWwzaHUrNHNp?= =?utf-8?B?cnJJZU9KZ3ZOUHJLaGdWc1NWWXdtczNnR2Z0T2xmazkvbzZoV25BZlpTbmZI?= =?utf-8?B?aXV6OGRsRlFyYnhSemRHbVpFREpOUmFKZ1NBMEFNY1VKSGhOaXpLQS9xUGkr?= =?utf-8?B?NG5oTTN1L0xIT2czOVlOdnlqZzhVUE51TGpudHBSeUlDMzAvbk82dStUVm10?= =?utf-8?B?VWthRU80TnVYZmNmaFhpWmlIZEFOcFZGMTZ5QzlzUzUyZklXRE9WQzFzM1BQ?= =?utf-8?B?cE1qdm1JZitBalRpd3dRWDZ1a0FQbUwyY0lsN2VkTk8vNy95eXF1dnY2M1BI?= =?utf-8?B?OGRwWEFIdUQ2eTdRWVluTXZuTm1FZ2hGMXpyaE8rUmNXQnBXWHlDMm9oY2Rq?= =?utf-8?B?UXRVbDZpbFNFb2pkSGk5aFNDay9SVzR2SVFPbzA3bWtZc25rN2pzQjNxb2pK?= =?utf-8?B?YmF0MUF1OE5mS2U2RmkxWnFyRUhjQnVxMEVxeEdzTlp3ZEFlUjQ0ZGVTd1Mx?= =?utf-8?Q?hw1l8bZCgyBwMbS6D+RFkDndI/w?= X-Microsoft-Antispam-Message-Info: JgBnhBBNnzE1hhXozqbYwj3BQ7ZF2AVfGCDFhAJ48grk18j8lUaTZoaysSyCA/i3Bd71/+VTTOyGuHBpdijqYnX44QwZNXXB7QR1+MlhuYaE5+RKGTBwMpkLCPdBCyngSxlnkwazaK1s/fJTd7m+bvmC63BekUseMC/00L38iEyJMG4N0c9GRTX496R7Cmo8 X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2776; 6:BLViQhyWHAbdtqb34DyMSUc3P7FNXHjGTcU8Vjzmm0AeCb26CsfoByRK/Wwk7iqNuVtTvBXOj/n+iy5nRg2+dredO3u6OEwGj3Y8/etciFjNVB+++j4hcgqTkta2Np6bM3uu29T/pdivIrcNYnTLGVkarBeGw4Bdkhmx5nODZyb1zQGxZ+zcPrPTOe6+TY1pY2Z5dLoZZodHIh6sINO47TtxeZVTj0nRIIfxF2ouB5VeAWx5PNjHXmv+ycpPq61sBN5hqxrS9s28BI7SS+ulcgBPJHaMQdq4Md9LJL6UGHb2VRl9Sx6CASXlbKE2STeq0Xqe7NQjiIzjPL9yXTSOhui0qBTVHiuumAa/LRHsRUJ5FGMQbIviPy5SfO7Gl2BG/imE16+E9nc5rsquAeC1kLCMovat4uXpK5rbJ7MRGHDJmOtA8OE+F0jmraWSZVDjG3KBEtf9r7wmL3JgmANZ/w==; 5:fDP59eVnuZzxLdj0E2sadkx1dDdSWYCgSya2QJC+YOagy612dEi1hqwRgJN7bsB1yqVbWEmerNCfwrurCMpi/Mc/qXCit3kf130Z8IQ6geV23/cn1sBy6I0T/Grk/mejooxPVlIH+1g/rO/r3Ia6LjdW2bZvlahHYqj1oxAbbQg=; 24:W3Uv0Ls3kGvRH+agzcYlfwE1hjjQQ0EGsHC1WEV+RFzSPSHnUNbLRrs1nUyM6dhH1uW8yu8BnrI/IyWy0HZNwqmNiCTakoUjktUjZ0BEB6g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2776; 7:HaTYm8byHxwUmMI04eca6heSPlCfoMRl+pWFOWD1JJBVRWJjXedHaTjXBUhx9xwC7ajUnKtgYxAlKAVFQgdghdHH8i0ClppHogRejrKJIVqY4yPLppdy6wipq01HIDGhfgMod3UZBNFkKtPqYz8DhLI0rU4VYe9KYBf72A56K8Fkv3AEMVFTNMvhRJmGf/ubI02Tw8IfyBAzPBJ4o4rXP6LcGCInYniOaXOTT7FZgMV4hxBwlTnqyYq5zJkRwQOf X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2018 09:28:04.1269 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92c9a303-43d9-4d1d-b869-08d5994534d9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2776 Subject: Re: [dpdk-dev] [PATCH] config: remove useless lines for DPAA2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 09:28:07 -0000 On Tuesday 03 April 2018 12:33 PM, Thomas Monjalon wrote: > 03/04/2018 08:55, Shreyansh Jain: >> On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote: >>> Some comments are not relevant in a config which only overrides >>> the default config. >>> >>> The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled >>> by default so it can be removed from this file. >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>> config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 ------- >>> 1 file changed, 7 deletions(-) >> >> I think DEBUG_DRIVER should exist in local config so that a developer >> can easily toggle it without modifying the common_base, which should >> serves as repository rather than toggle. > > No, the file to be modified is .config in the build directory, > not the default config. In my environment I prefer changing the platform config rather than local .config as that way I can track changes through git. > >> I do see the problem that having an option in common_base and then >> having it again in local config without overriding (=n) - is non-intuitive. >> >> But, I still feel it is easier to control changes in local config - >> (make T=) is easily visible. > > It is not a local config file. > The local config is .config. Sorry, allow me to rephrase my previous wordings: s/local config/platform config/ Anyways, this is just my personal preference - not a big inconvenience. Thanks for the patch. Acked-By: Shreyansh Jain