* [dpdk-dev] [PATCH] ethdev: fix flow expansion matching types
@ 2018-07-11 6:49 Nelio Laranjeiro
2018-07-11 7:16 ` Adrien Mazarguil
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2018-07-11 6:49 UTC (permalink / raw)
To: dev, Adrien Mazarguil
Node RSS types are generally covering more RSS kind than the user is
requesting, it should accept to expand even if only a single bit is
remains after masking. Setting the correct RSS kind for the rule
remains the driver job.
Fixes: 959823ce4c47 ("ethdev: add flow API to expand RSS flows")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
lib/librte_ethdev/rte_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index 2b13efca7..e06cc2193 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -585,7 +585,7 @@ rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
node = next_node ? &graph[*next_node] : NULL;
while (node) {
flow_items[stack_pos].type = node->type;
- if ((node->rss_types & types) == node->rss_types) {
+ if (node->rss_types & types) {
/*
* compute the number of items to copy from the
* expansion and copy it.
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix flow expansion matching types
2018-07-11 6:49 [dpdk-dev] [PATCH] ethdev: fix flow expansion matching types Nelio Laranjeiro
@ 2018-07-11 7:16 ` Adrien Mazarguil
2018-07-12 21:28 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2018-07-11 7:16 UTC (permalink / raw)
To: Nelio Laranjeiro; +Cc: dev
On Wed, Jul 11, 2018 at 08:49:35AM +0200, Nelio Laranjeiro wrote:
> Node RSS types are generally covering more RSS kind than the user is
> requesting, it should accept to expand even if only a single bit is
> remains after masking. Setting the correct RSS kind for the rule
> remains the driver job.
>
> Fixes: 959823ce4c47 ("ethdev: add flow API to expand RSS flows")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix flow expansion matching types
2018-07-11 7:16 ` Adrien Mazarguil
@ 2018-07-12 21:28 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-07-12 21:28 UTC (permalink / raw)
To: Nelio Laranjeiro; +Cc: dev, Adrien Mazarguil
11/07/2018 09:16, Adrien Mazarguil:
> On Wed, Jul 11, 2018 at 08:49:35AM +0200, Nelio Laranjeiro wrote:
> > Node RSS types are generally covering more RSS kind than the user is
> > requesting, it should accept to expand even if only a single bit is
> > remains after masking. Setting the correct RSS kind for the rule
> > remains the driver job.
> >
> > Fixes: 959823ce4c47 ("ethdev: add flow API to expand RSS flows")
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-12 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 6:49 [dpdk-dev] [PATCH] ethdev: fix flow expansion matching types Nelio Laranjeiro
2018-07-11 7:16 ` Adrien Mazarguil
2018-07-12 21:28 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).