DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v2] config/arm: add PHYTIUM ft2000plus
@ 2022-06-21  6:24 luzhipeng
  2022-07-05 13:30 ` [PATCH v3] config/arm: add Phytium FT-2000+ Thomas Monjalon
  0 siblings, 1 reply; 11+ messages in thread
From: luzhipeng @ 2022-06-21  6:24 UTC (permalink / raw)
  To: dev; +Cc: Jan Viktorin, Ruifeng Wang, Bruce Richardson, luzhipeng

Here adds configs for PHYTIUM server.

Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
---
 config/arm/arm64_ft2000plus_linux_gcc | 16 ++++++++++++++++
 config/arm/meson.build                | 26 +++++++++++++++++++++++++-
 2 files changed, 41 insertions(+), 1 deletion(-)
 create mode 100644 config/arm/arm64_ft2000plus_linux_gcc
 
 v2: add ccache support

diff --git a/config/arm/arm64_ft2000plus_linux_gcc b/config/arm/arm64_ft2000plus_linux_gcc
new file mode 100644
index 0000000000..f02b492ba2
--- /dev/null
+++ b/config/arm/arm64_ft2000plus_linux_gcc
@@ -0,0 +1,16 @@
+[binaries]
+c = [ 'ccache', 'aarch64-linux-gnu-gcc']
+cpp = [ 'ccache', 'aarch64-linux-gnu-cpp']
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+platform = 'ft2000plus'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index aa12eb76f4..48e5f6af5b 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -218,6 +218,20 @@ implementer_qualcomm = {
     }
 }
 
+implementer_phytium = {
+    'description': 'PHYTIUM',
+    'flags': [
+        ['RTE_MACHINE', '"armv8a"'],
+        ['RTE_USE_C11_MEM_MODEL', true],
+        ['RTE_CACHE_LINE_SIZE', 64],
+        ['RTE_MAX_LCORE', 64],
+        ['RTE_MAX_NUMA_NODES', 8]
+    ],
+    'part_number_config': {
+        '0x662': {'machine_args':  ['-march=armv8-a+crc']}
+    }
+}
+
 ## Arm implementers (ID from MIDR in Arm Architecture Reference Manual)
 implementers = {
     'generic': implementer_generic,
@@ -225,7 +239,8 @@ implementers = {
     '0x43': implementer_cavium,
     '0x48': implementer_hisilicon,
     '0x50': implementer_ampere,
-    '0x51': implementer_qualcomm
+    '0x51': implementer_qualcomm,
+    '0x70': implementer_phytium
 }
 
 # SoC specific armv8 flags have the highest priority
@@ -378,6 +393,13 @@ soc_thunderxt83 = {
     'part_number': '0xa3'
 }
 
+soc_ft2000plus = {
+    'description': 'PHYTIUM ft2000plus',
+    'implementer': '0x70',
+    'part_number': '0x662',
+    'numa': true
+}
+
 '''
 Start of SoCs list
 generic:         Generic un-optimized build for armv8 aarch64 execution mode.
@@ -398,6 +420,7 @@ stingray:        Broadcom Stingray
 thunderx2:       Marvell ThunderX2 T99
 thunderxt88:     Marvell ThunderX T88
 thunderxt83:     Marvell ThunderX T83
+ft2000plus:  PHYTIUM ft2000plus
 End of SoCs list
 '''
 # The string above is included in the documentation, keep it in sync with the
@@ -421,6 +444,7 @@ socs = {
     'thunderx2': soc_thunderx2,
     'thunderxt88': soc_thunderxt88,
     'thunderxt83': soc_thunderxt83,
+    'ft2000plus': soc_ft2000plus,
 }
 
 dpdk_conf.set('RTE_ARCH_ARM', 1)
-- 
2.27.0




^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v3] config/arm: add Phytium FT-2000+
  2022-06-21  6:24 [PATCH v2] config/arm: add PHYTIUM ft2000plus luzhipeng
@ 2022-07-05 13:30 ` Thomas Monjalon
  2022-07-05 13:50   ` Ruifeng Wang
                     ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Thomas Monjalon @ 2022-07-05 13:30 UTC (permalink / raw)
  To: dev; +Cc: luzhipeng, Ruifeng Wang, Jan Viktorin, Bruce Richardson

From: luzhipeng <luzhipeng@cestc.cn>

Here adds configs for Phytium server.

Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
---
I did some changes in this v3:
- PHYTIUM -> Phytium (as on the website)
- ft2000plus -> FT-2000+ (as found online)
- alphabetical ordering
- extra commas for future extensions
- g++ as cpp Meson command

Please tell how to write your name with spaces and capitals
in the order [first name] [family name], thanks.
---
 config/arm/arm64_ft2000plus_linux_gcc | 16 +++++++++++++++
 config/arm/meson.build                | 28 +++++++++++++++++++++++++--
 2 files changed, 42 insertions(+), 2 deletions(-)
 create mode 100644 config/arm/arm64_ft2000plus_linux_gcc

diff --git a/config/arm/arm64_ft2000plus_linux_gcc b/config/arm/arm64_ft2000plus_linux_gcc
new file mode 100644
index 0000000000..ae9f779056
--- /dev/null
+++ b/config/arm/arm64_ft2000plus_linux_gcc
@@ -0,0 +1,16 @@
+[binaries]
+c = ['ccache', 'aarch64-linux-gnu-gcc']
+cpp = ['ccache', 'aarch64-linux-gnu-g++']
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+platform = 'ft2000plus'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index aa12eb76f4..5291c036d6 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -197,6 +197,20 @@ implementer_hisilicon = {
     }
 }
 
+implementer_phytium = {
+    'description': 'Phytium',
+    'flags': [
+        ['RTE_MACHINE', '"armv8a"'],
+        ['RTE_USE_C11_MEM_MODEL', true],
+        ['RTE_CACHE_LINE_SIZE', 64],
+        ['RTE_MAX_LCORE', 64],
+        ['RTE_MAX_NUMA_NODES', 8]
+    ],
+    'part_number_config': {
+        '0x662': {'machine_args':  ['-march=armv8-a+crc']}
+    }
+}
+
 implementer_qualcomm = {
     'description': 'Qualcomm',
     'flags': [
@@ -214,7 +228,7 @@ implementer_qualcomm = {
         '0xc00': {
             'march': 'armv8-a',
             'march_features': ['crc']
-        }
+        },
     }
 }
 
@@ -225,7 +239,8 @@ implementers = {
     '0x43': implementer_cavium,
     '0x48': implementer_hisilicon,
     '0x50': implementer_ampere,
-    '0x51': implementer_qualcomm
+    '0x51': implementer_qualcomm,
+    '0x70': implementer_phytium,
 }
 
 # SoC specific armv8 flags have the highest priority
@@ -304,6 +319,13 @@ soc_emag = {
     'part_number': '0x0'
 }
 
+soc_ft2000plus = {
+    'description': 'Phytium FT-2000+',
+    'implementer': '0x70',
+    'part_number': '0x662',
+    'numa': true
+}
+
 soc_graviton2 = {
     'description': 'AWS Graviton2',
     'implementer': '0x41',
@@ -389,6 +411,7 @@ cn9k:            Marvell OCTEON 9
 cn10k:           Marvell OCTEON 10
 dpaa:            NXP DPAA
 emag:            Ampere eMAG
+ft2000plus:      Phytium FT-2000+
 graviton2:       AWS Graviton2
 kunpeng920:      HiSilicon Kunpeng 920
 kunpeng930:      HiSilicon Kunpeng 930
@@ -412,6 +435,7 @@ socs = {
     'cn10k' : soc_cn10k,
     'dpaa': soc_dpaa,
     'emag': soc_emag,
+    'ft2000plus': soc_ft2000plus,
     'graviton2': soc_graviton2,
     'kunpeng920': soc_kunpeng920,
     'kunpeng930': soc_kunpeng930,
-- 
2.36.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-05 13:30 ` [PATCH v3] config/arm: add Phytium FT-2000+ Thomas Monjalon
@ 2022-07-05 13:50   ` Ruifeng Wang
  2022-07-05 13:57     ` Thomas Monjalon
  2022-07-08 12:44     ` Thomas Monjalon
  2022-07-05 14:25   ` Morten Brørup
  2022-07-05 14:31   ` Morten Brørup
  2 siblings, 2 replies; 11+ messages in thread
From: Ruifeng Wang @ 2022-07-05 13:50 UTC (permalink / raw)
  To: thomas, dev; +Cc: luzhipeng, Jan Viktorin, Bruce Richardson, nd

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, July 5, 2022 9:31 PM
> To: dev@dpdk.org
> Cc: luzhipeng <luzhipeng@cestc.cn>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Jan Viktorin <viktorin@rehivetech.com>; Bruce
> Richardson <bruce.richardson@intel.com>
> Subject: [PATCH v3] config/arm: add Phytium FT-2000+
> 
> From: luzhipeng <luzhipeng@cestc.cn>
> 
> Here adds configs for Phytium server.
> 
> Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> I did some changes in this v3:
> - PHYTIUM -> Phytium (as on the website)
> - ft2000plus -> FT-2000+ (as found online)
> - alphabetical ordering
> - extra commas for future extensions
> - g++ as cpp Meson command
> 
> Please tell how to write your name with spaces and capitals in the order [first
> name] [family name], thanks.
> ---

<snip>

>  implementer_qualcomm = {
>      'description': 'Qualcomm',
>      'flags': [
> @@ -214,7 +228,7 @@ implementer_qualcomm = {
>          '0xc00': {
>              'march': 'armv8-a',
>              'march_features': ['crc']
> -        }
> +        },

Unintentional change?
The change is valid, but not related to this patch.

Otherwise looks good to me.
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

>      }
>  }
> 
> @@ -225,7 +239,8 @@ implementers = {
>      '0x43': implementer_cavium,
>      '0x48': implementer_hisilicon,
>      '0x50': implementer_ampere,
> -    '0x51': implementer_qualcomm
> +    '0x51': implementer_qualcomm,
> +    '0x70': implementer_phytium,
>  }
> 
>  # SoC specific armv8 flags have the highest priority @@ -304,6 +319,13 @@
> soc_emag = {
>      'part_number': '0x0'
>  }
> 
> +soc_ft2000plus = {
> +    'description': 'Phytium FT-2000+',
> +    'implementer': '0x70',
> +    'part_number': '0x662',
> +    'numa': true
> +}
> +
>  soc_graviton2 = {
>      'description': 'AWS Graviton2',
>      'implementer': '0x41',
> @@ -389,6 +411,7 @@ cn9k:            Marvell OCTEON 9
>  cn10k:           Marvell OCTEON 10
>  dpaa:            NXP DPAA
>  emag:            Ampere eMAG
> +ft2000plus:      Phytium FT-2000+
>  graviton2:       AWS Graviton2
>  kunpeng920:      HiSilicon Kunpeng 920
>  kunpeng930:      HiSilicon Kunpeng 930
> @@ -412,6 +435,7 @@ socs = {
>      'cn10k' : soc_cn10k,
>      'dpaa': soc_dpaa,
>      'emag': soc_emag,
> +    'ft2000plus': soc_ft2000plus,
>      'graviton2': soc_graviton2,
>      'kunpeng920': soc_kunpeng920,
>      'kunpeng930': soc_kunpeng930,
> --
> 2.36.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-05 13:50   ` Ruifeng Wang
@ 2022-07-05 13:57     ` Thomas Monjalon
  2022-07-08 12:44     ` Thomas Monjalon
  1 sibling, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2022-07-05 13:57 UTC (permalink / raw)
  To: Ruifeng Wang; +Cc: dev, luzhipeng, Jan Viktorin, Bruce Richardson, nd

05/07/2022 15:50, Ruifeng Wang:
> From: Thomas Monjalon <thomas@monjalon.net>
> > @@ -214,7 +228,7 @@ implementer_qualcomm = {
> >          '0xc00': {
> >              'march': 'armv8-a',
> >              'march_features': ['crc']
> > -        }
> > +        },
> 
> Unintentional change?
> The change is valid, but not related to this patch.

Yes you're right, it is unintentional.




^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-05 13:30 ` [PATCH v3] config/arm: add Phytium FT-2000+ Thomas Monjalon
  2022-07-05 13:50   ` Ruifeng Wang
@ 2022-07-05 14:25   ` Morten Brørup
  2022-07-05 14:31   ` Morten Brørup
  2 siblings, 0 replies; 11+ messages in thread
From: Morten Brørup @ 2022-07-05 14:25 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: luzhipeng, Ruifeng Wang, Jan Viktorin, Bruce Richardson

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, 5 July 2022 15.31
> 
> From: luzhipeng <luzhipeng@cestc.cn>
> 
> Here adds configs for Phytium server.
> 
> Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> I did some changes in this v3:
> - PHYTIUM -> Phytium (as on the website)
> - ft2000plus -> FT-2000+ (as found online)
> - alphabetical ordering
> - extra commas for future extensions
> - g++ as cpp Meson command
> 
> Please tell how to write your name with spaces and capitals
> in the order [first name] [family name], thanks.

Thomas means: [given name] [family name].

E.g. my parents chose to give me the name "Morten", and they gave my brother the name "Søren". And we inherited the family name "Brørup".

Med venlig hilsen / Kind regards,
-Morten Brørup


^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-05 13:30 ` [PATCH v3] config/arm: add Phytium FT-2000+ Thomas Monjalon
  2022-07-05 13:50   ` Ruifeng Wang
  2022-07-05 14:25   ` Morten Brørup
@ 2022-07-05 14:31   ` Morten Brørup
  2022-07-06  1:02     ` luzhipeng
  2022-07-06  1:28     ` luzhipeng
  2 siblings, 2 replies; 11+ messages in thread
From: Morten Brørup @ 2022-07-05 14:31 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: luzhipeng, Ruifeng Wang, Jan Viktorin, Bruce Richardson

> From: Morten Brørup
> Sent: Tuesday, 5 July 2022 16.25
> 
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Tuesday, 5 July 2022 15.31
> >
> > From: luzhipeng <luzhipeng@cestc.cn>
> >
> > Here adds configs for Phytium server.
> >
> > Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> > Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > I did some changes in this v3:
> > - PHYTIUM -> Phytium (as on the website)
> > - ft2000plus -> FT-2000+ (as found online)
> > - alphabetical ordering
> > - extra commas for future extensions
> > - g++ as cpp Meson command
> >
> > Please tell how to write your name with spaces and capitals
> > in the order [first name] [family name], thanks.
> 
> Thomas means: [given name] [family name].
> 
> E.g. my parents chose to give me the name "Morten", and they gave my
> brother the name "Søren". And we inherited the family name "Brørup".
> 
> Med venlig hilsen / Kind regards,
> -Morten Brørup

Come to think of it... I hope this explanation is not politically incorrect in regions where you choose your own name. :-/

And I guess the "given name" would be "chosen name" in such regions.

I'm certainly not a master of political correctness, so just slap me with a wet baguette if I managed to step on your toes! :-)


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-05 14:31   ` Morten Brørup
@ 2022-07-06  1:02     ` luzhipeng
  2022-07-06  1:28     ` luzhipeng
  1 sibling, 0 replies; 11+ messages in thread
From: luzhipeng @ 2022-07-06  1:02 UTC (permalink / raw)
  To: Morten Brørup, Thomas Monjalon, dev
  Cc: Ruifeng Wang, Jan Viktorin, Bruce Richardson

my name: zhipeng Lu
thanks.

在 2022/7/5 22:31, Morten Brørup 写道:
>> From: Morten Brørup
>> Sent: Tuesday, 5 July 2022 16.25
>>
>>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>>> Sent: Tuesday, 5 July 2022 15.31
>>>
>>> From: luzhipeng <luzhipeng@cestc.cn>
>>>
>>> Here adds configs for Phytium server.
>>>
>>> Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
>>> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>> I did some changes in this v3:
>>> - PHYTIUM -> Phytium (as on the website)
>>> - ft2000plus -> FT-2000+ (as found online)
>>> - alphabetical ordering
>>> - extra commas for future extensions
>>> - g++ as cpp Meson command
>>>
>>> Please tell how to write your name with spaces and capitals
>>> in the order [first name] [family name], thanks.
>>
>> Thomas means: [given name] [family name].
>>
>> E.g. my parents chose to give me the name "Morten", and they gave my
>> brother the name "Søren". And we inherited the family name "Brørup".
>>
>> Med venlig hilsen / Kind regards,
>> -Morten Brørup
> 
> Come to think of it... I hope this explanation is not politically incorrect in regions where you choose your own name. :-/
> 
> And I guess the "given name" would be "chosen name" in such regions.
> 
> I'm certainly not a master of political correctness, so just slap me with a wet baguette if I managed to step on your toes! :-)
> 
> 
> 



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-05 14:31   ` Morten Brørup
  2022-07-06  1:02     ` luzhipeng
@ 2022-07-06  1:28     ` luzhipeng
  2022-07-06  6:59       ` Thomas Monjalon
  1 sibling, 1 reply; 11+ messages in thread
From: luzhipeng @ 2022-07-06  1:28 UTC (permalink / raw)
  To: Morten Brørup, Thomas Monjalon, dev
  Cc: Ruifeng Wang, Jan Viktorin, Bruce Richardson

My name: zhipeng Lu

Thanks.

在 2022/7/5 22:31, Morten Brørup 写道:
>> From: Morten Brørup
>> Sent: Tuesday, 5 July 2022 16.25
>>
>>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>>> Sent: Tuesday, 5 July 2022 15.31
>>>
>>> From: luzhipeng <luzhipeng@cestc.cn>
>>>
>>> Here adds configs for Phytium server.
>>>
>>> Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
>>> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>> I did some changes in this v3:
>>> - PHYTIUM -> Phytium (as on the website)
>>> - ft2000plus -> FT-2000+ (as found online)
>>> - alphabetical ordering
>>> - extra commas for future extensions
>>> - g++ as cpp Meson command
>>>
>>> Please tell how to write your name with spaces and capitals
>>> in the order [first name] [family name], thanks.
>>
>> Thomas means: [given name] [family name].
>>
>> E.g. my parents chose to give me the name "Morten", and they gave my
>> brother the name "Søren". And we inherited the family name "Brørup".
>>
>> Med venlig hilsen / Kind regards,
>> -Morten Brørup
> 
> Come to think of it... I hope this explanation is not politically incorrect in regions where you choose your own name. :-/
> 
> And I guess the "given name" would be "chosen name" in such regions.
> 
> I'm certainly not a master of political correctness, so just slap me with a wet baguette if I managed to step on your toes! :-)
> 
> 
> 



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-06  1:28     ` luzhipeng
@ 2022-07-06  6:59       ` Thomas Monjalon
  2022-07-06  7:00         ` luzhipeng
  0 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2022-07-06  6:59 UTC (permalink / raw)
  To: luzhipeng
  Cc: Morten Brørup, dev, Ruifeng Wang, Jan Viktorin, Bruce Richardson

06/07/2022 03:28, luzhipeng:
> My name: zhipeng Lu

OK I will change it to Zhipeng Lu (with capital letters).
Are you OK with this v3?

> >>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >>> I did some changes in this v3:
> >>> - PHYTIUM -> Phytium (as on the website)
> >>> - ft2000plus -> FT-2000+ (as found online)
> >>> - alphabetical ordering
> >>> - extra commas for future extensions
> >>> - g++ as cpp Meson command
> >>>
> >>> Please tell how to write your name with spaces and capitals
> >>> in the order [first name] [family name], thanks.




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-06  6:59       ` Thomas Monjalon
@ 2022-07-06  7:00         ` luzhipeng
  0 siblings, 0 replies; 11+ messages in thread
From: luzhipeng @ 2022-07-06  7:00 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: Morten Brørup, dev, Ruifeng Wang, Jan Viktorin, Bruce Richardson



在 2022/7/6 14:59, Thomas Monjalon 写道:
> 06/07/2022 03:28, luzhipeng:
>> My name: zhipeng Lu
> 
> OK I will change it to Zhipeng Lu (with capital letters).
> Are you OK with this v3?
> 
OK

>>>>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>>>>> I did some changes in this v3:
>>>>> - PHYTIUM -> Phytium (as on the website)
>>>>> - ft2000plus -> FT-2000+ (as found online)
>>>>> - alphabetical ordering
>>>>> - extra commas for future extensions
>>>>> - g++ as cpp Meson command
>>>>>
>>>>> Please tell how to write your name with spaces and capitals
>>>>> in the order [first name] [family name], thanks.
> 
> 
> 
> 
> 



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3] config/arm: add Phytium FT-2000+
  2022-07-05 13:50   ` Ruifeng Wang
  2022-07-05 13:57     ` Thomas Monjalon
@ 2022-07-08 12:44     ` Thomas Monjalon
  1 sibling, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2022-07-08 12:44 UTC (permalink / raw)
  To: luzhipeng; +Cc: dev, Jan Viktorin, Bruce Richardson, nd, Ruifeng Wang

05/07/2022 15:50, Ruifeng Wang:
> > From: luzhipeng <luzhipeng@cestc.cn>
> > 
> > Here adds configs for Phytium server.
> > 
> > Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> > Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > I did some changes in this v3:
> > - PHYTIUM -> Phytium (as on the website)
> > - ft2000plus -> FT-2000+ (as found online)
> > - alphabetical ordering
> > - extra commas for future extensions
> > - g++ as cpp Meson command
> > 
> > Please tell how to write your name with spaces and capitals in the order [first
> > name] [family name], thanks.
> > ---
> 
> <snip>
> 
> >  implementer_qualcomm = {
> >      'description': 'Qualcomm',
> >      'flags': [
> > @@ -214,7 +228,7 @@ implementer_qualcomm = {
> >          '0xc00': {
> >              'march': 'armv8-a',
> >              'march_features': ['crc']
> > -        }
> > +        },
> 
> Unintentional change?
> The change is valid, but not related to this patch.
> 
> Otherwise looks good to me.
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

Applied (without above unintentional change), thanks.



^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-07-08 12:44 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21  6:24 [PATCH v2] config/arm: add PHYTIUM ft2000plus luzhipeng
2022-07-05 13:30 ` [PATCH v3] config/arm: add Phytium FT-2000+ Thomas Monjalon
2022-07-05 13:50   ` Ruifeng Wang
2022-07-05 13:57     ` Thomas Monjalon
2022-07-08 12:44     ` Thomas Monjalon
2022-07-05 14:25   ` Morten Brørup
2022-07-05 14:31   ` Morten Brørup
2022-07-06  1:02     ` luzhipeng
2022-07-06  1:28     ` luzhipeng
2022-07-06  6:59       ` Thomas Monjalon
2022-07-06  7:00         ` luzhipeng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).