From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A93D7568B for ; Wed, 9 Dec 2015 09:35:31 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 09 Dec 2015 00:35:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,402,1444719600"; d="scan'208";a="837437707" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga001.jf.intel.com with ESMTP; 09 Dec 2015 00:35:14 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Dec 2015 08:35:13 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.251]) by IRSMSX156.ger.corp.intel.com ([169.254.3.110]) with mapi id 14.03.0248.002; Wed, 9 Dec 2015 08:35:13 +0000 From: "Azarewicz, PiotrX T" To: "Mcnamara, John" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue Thread-Index: AQHRMcLwMOzp2YnIzUivoe/FD5Tk3J7BKy8AgAAk54CAAQSpMA== Date: Wed, 9 Dec 2015 08:35:12 +0000 Message-ID: <4837007523CC9A4B9414D20C13DE6E641363D33A@IRSMSX102.ger.corp.intel.com> References: <1449584208-24987-1-git-send-email-piotrx.t.azarewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 08:35:32 -0000 > -----Original Message----- > From: Mcnamara, John > Sent: Tuesday, December 8, 2015 6:00 PM > To: Mcnamara, John ; Azarewicz, PiotrX T > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy > issue >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John > > Sent: Tuesday, December 8, 2015 2:47 PM > > To: Azarewicz, PiotrX T; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy > > issue > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz > > > Sent: Tuesday, December 8, 2015 2:17 PM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy > > > issue > > > > > > The cmds and thread_cmds both are the arrays of cmdline_parse_ctx_t. > > > So the goal is to copy elements size of cmdline_parse_ctx_t not > > > cmdline_parse_ctx_t*. > > > > > > Coverity issue: 120412 > > > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread > > > binding > > > dynamically") > > > > > > Signed-off-by: Piotr Azarewicz > > > > Acked-by: John McNamara >=20 > Hi Piotr, >=20 > This issue occurs copy and pasted in two other locations as well: >=20 > examples/ip_pipeline/pipeline/pipeline_common_fe.c > 1295: n_cmds * sizeof(cmdline_parse_ctx_t *)); >=20 > examples/ip_pipeline/thread_fe.c > 340: n_cmds * sizeof(cmdline_parse_ctx_t *)); >=20 > examples/ip_pipeline/init.c > 1475: n_cmds * sizeof(cmdline_parse_ctx_t *)); >=20 > Perhaps you could fix those in the same patch. >=20 > Thanks, >=20 > John >=20 >=20 Yes, you are right, thanks. I will send v2. Piotr