From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <piotrx.t.azarewicz@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id BA9E695DC
 for <dev@dpdk.org>; Wed,  8 Jun 2016 09:46:48 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP; 08 Jun 2016 00:46:36 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,438,1459839600"; d="scan'208";a="715726793"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by FMSMGA003.fm.intel.com with ESMTP; 08 Jun 2016 00:46:34 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.10]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.193]) with mapi id 14.03.0248.002;
 Wed, 8 Jun 2016 08:46:33 +0100
From: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Doherty, Declan"
 <declan.doherty@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve
 random key generator
Thread-Index: AQHRtol9K2YV+Bz2iEC1l58UrjKfw5/eeQiAgADD00A=
Date: Wed, 8 Jun 2016 07:46:33 +0000
Message-ID: <4837007523CC9A4B9414D20C13DE6E64136D27B2@IRSMSX102.ger.corp.intel.com>
References: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <21237364.CLn9ZV8ln9@xps13>
In-Reply-To: <21237364.CLn9ZV8ln9@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random
 key generator
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2016 07:46:49 -0000

> 2016-05-25 15:34, Piotr Azarewicz:
> > This patch improve generate_random_key() function by replacing rand()
> > function with reading from /dev/urandom.
> >
> > CID 120136 : Calling risky function (DC.WEAK_CRYPTO)
> > dont_call: rand should not be used for security related applications,
> > as linear congruential algorithms are too easy to break
> >
> > Coverity issue: 120136
> >
> > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> > ---
> >  examples/l2fwd-crypto/main.c |   18 +++++++++++++-----
>=20
> Is it relevant for this example?

Maybe not. But it don't break anything, and in the end make Coverity tool h=
appy.

Declan, please share your opinion.