From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id B5A663F9
 for <dev@dpdk.org>; Fri, 23 Oct 2015 22:28:38 +0200 (CEST)
Received: by wikq8 with SMTP id q8so92126833wik.1
 for <dev@dpdk.org>; Fri, 23 Oct 2015 13:28:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=w/qfgRx4mUePLrWxrAB5U3I0k/eXo0PjzLrVgVcINHE=;
 b=gdZHCFrVU/nsBy/AsM6M0mD8Pk1A/V6deidB6/ZbalPmNzV8ZWdZd85pmZufi+3wpy
 22HJIJALUM8qPR+xY0yMi05XiW7HVu6QNqEYDxCTo8ld8C7NNDoeTwZW7GeKMQDtfk34
 C1FmpquPL7t9yZBk1nGR7a6s73/nRqYskfz69Ny4XhjMe2CzgV3ukAHNRzHzErjsLDKi
 TuJgtfezPaxRGCqwqj/PMwibnysxIoMccT791o9tO2sMh0MSdl1VTm4rQWHbAoDr6UDH
 tNuQAhMbVNDh0Ob2SKq0dZ/iSCZrT17MRuTeCRL49kFGEw3f13hy940iY92K8zWiMI31
 Fmmg==
X-Gm-Message-State: ALoCoQke3JJ8o++bDDvLxy4m7N5bthEf4PfOXNX0ybCN2hK6iAOyLTjT/JlzOLI5u2vodpWpOrHa
X-Received: by 10.180.75.47 with SMTP id z15mr6096112wiv.36.1445632118504;
 Fri, 23 Oct 2015 13:28:38 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id p2sm24450317wjb.21.2015.10.23.13.28.37
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 23 Oct 2015 13:28:38 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 23 Oct 2015 22:27:32 +0200
Message-ID: <4846214.yzCNZhmeXD@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20151023095842.5249bdee@xeon-e3>
References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com>
 <4288301.N0F7Gaqfh8@xps13> <20151023095842.5249bdee@xeon-e3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2015 20:28:38 -0000

2015-10-23 09:58, Stephen Hemminger:
> On Fri, 23 Oct 2015 18:34:23 +0200
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 
> > >   LINUX_VERSION_CODE  
> > 
> > It is used for out-of-tree modules.
> 
> Actually for the kernel modules, all flags should be enabled.
> It is kernel code and it should follow the kernel style conventions.

No, version macros are needed in out of tree modules but forbidden
upstream.