DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Harman Kalra <hkalra@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: register dynamic mbuf timestamp field
Date: Tue, 03 Nov 2020 15:24:38 +0100	[thread overview]
Message-ID: <4848304.ISYM4h8o7B@thomas> (raw)
In-Reply-To: <20201103141640.174043-1-hkalra@marvell.com>

03/11/2020 15:16, Harman Kalra:
> A crash is observed if dynamic mbuf timestamp field is
> registered in dev_start, as in most of the applications
> rte_eth_timesync_enable is called after dev_start due
> to which timestamp field did not get registered.

So you are not reading your emails?

I was waiting for you, so I looked at the ugly code of octeontx2
with Olivier and David, and we fixed it already.

Not reading emails is wasting time of everybody.
On the contrary, being available on IRC can speed up work.

> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -2219,16 +2219,6 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev)
>  	else
>  		otx2_nix_timesync_disable(eth_dev);
> -	if (dev->rx_offload_flags & NIX_RX_OFFLOAD_TSTAMP_F) {
> -		rc = rte_mbuf_dyn_rx_timestamp_register(
> -				&dev->tstamp.tstamp_dynfield_offset,
> -				&dev->tstamp.rx_tstamp_dynflag);
> -		if (rc != 0) {
> -			otx2_err("Failed to register Rx timestamp field/flag");
> -			return -rte_errno;
> -		}
> -	}
> -

This is wrong, you still need to register for the case
of DEV_RX_OFFLOAD_TIMESTAMP without timesync.

In my v5, it is moved below after VF special config.

>  	/* Update VF about data off shifted by 8 bytes if PTP already
>  	 * enabled in PF owning this VF
>  	 */

  reply	other threads:[~2020-11-03 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 14:16 Harman Kalra
2020-11-03 14:24 ` Thomas Monjalon [this message]
2020-11-03 14:26   ` Thomas Monjalon
2020-11-03 14:48     ` [dpdk-dev] [EXT] " Harman Kalra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4848304.ISYM4h8o7B@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).