From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 217BEA0521; Tue, 3 Nov 2020 15:24:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 091FBCB0A; Tue, 3 Nov 2020 15:24:45 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 97ED6CB01 for ; Tue, 3 Nov 2020 15:24:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 692D8D25; Tue, 3 Nov 2020 09:24:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 09:24:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= d5/AazWTYPYuNlHYwrOsdKi2rFkczpVfNfkY8Zvifng=; b=vnKZ6FqnA7ybfPwy hWVnwZLHYlucLdSKfgdGj/fE1FUdABG7gvDOUiaREZC0WWAXPmj4wkoH1apvssb1 Cs3k5fMvz+gURuR2NmZhY09lbhfmGg1CqnjuUzyiRuITVP6x5KzE3eYgypp8zHFU F+wPp0Jv9/JE68HCn7Is6Bg41nNmNz69DppFL5yAf5VxyvEVWE6DiF/WnRAcVfCa FyqxrkVbdXi6QMmgmsMycKLhO/hkERhC06RAa7Mg5G2p5epA4wvRbFa7JLolmUaw knt84H1ZEEvuBKgwWtokGHw1ygqNsSRg/cbYQM7dJzo7iXTt1Vi330gndelhMnck VVZwsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=d5/AazWTYPYuNlHYwrOsdKi2rFkczpVfNfkY8Zvif ng=; b=DJPvRpy4ZsUJsChitPn2+y8dlzTsEjLdKBfpshP13fV2tfNzCs9aRmKuK 5m5olGRKnsF7NDvkrQllYmONb8NKXFmErBFM7Q4NUJY456Y8TeYWnwp6xQ2OONNe Gx1VkXxY/poolP9vVDmEHcDsZFFUx1MNiffZww3x7Ip4MvfPBZnnbyWGchQDuJnj nupevP0DGIGq7q2FXRJUeZJUkD1QyP52LQdCRQvJDGtTtzVGqV5JMsSkvgjdknK4 HAR8tR66uEpobir4dJEhWkyWa9zBlNqD2o86PZAjo8r63HDw7t+iC0InJCWeDK8P VioeIVdl7HOyqHK11b8CpOa9V8tLQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 07681328005D; Tue, 3 Nov 2020 09:24:39 -0500 (EST) From: Thomas Monjalon To: Harman Kalra Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , dev@dpdk.org Date: Tue, 03 Nov 2020 15:24:38 +0100 Message-ID: <4848304.ISYM4h8o7B@thomas> In-Reply-To: <20201103141640.174043-1-hkalra@marvell.com> References: <20201103141640.174043-1-hkalra@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: register dynamic mbuf timestamp field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2020 15:16, Harman Kalra: > A crash is observed if dynamic mbuf timestamp field is > registered in dev_start, as in most of the applications > rte_eth_timesync_enable is called after dev_start due > to which timestamp field did not get registered. So you are not reading your emails? I was waiting for you, so I looked at the ugly code of octeontx2 with Olivier and David, and we fixed it already. Not reading emails is wasting time of everybody. On the contrary, being available on IRC can speed up work. > Signed-off-by: Harman Kalra > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -2219,16 +2219,6 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev) > else > otx2_nix_timesync_disable(eth_dev); > > - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_TSTAMP_F) { > - rc = rte_mbuf_dyn_rx_timestamp_register( > - &dev->tstamp.tstamp_dynfield_offset, > - &dev->tstamp.rx_tstamp_dynflag); > - if (rc != 0) { > - otx2_err("Failed to register Rx timestamp field/flag"); > - return -rte_errno; > - } > - } > - This is wrong, you still need to register for the case of DEV_RX_OFFLOAD_TIMESTAMP without timesync. In my v5, it is moved below after VF special config. > /* Update VF about data off shifted by 8 bytes if PTP already > * enabled in PF owning this VF > */