From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 03CBB25D9 for ; Thu, 26 Jul 2018 20:07:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6CB7021AEC; Thu, 26 Jul 2018 14:07:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 14:07:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5881QJJIFY7NEcoxetf6vR0BzH FblqxKQ6gF7yLJHVs=; b=AL7r91AU3QpJeN/q6amKoxBIXeQQGEMVvWCALjY6qk KXICBJ6k4Q1+0haDtpbgXpgSTrbTgvlNDJD3p6lwtpRt0pe+VG3cyiVBAo3s594J S+J/TmDQ7FcOKWI/OYv09t0ED60eKNRim8IyBpMp4m1T7mEtG2Q8mVw7DPc+rJFw k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5881QJ JIFY7NEcoxetf6vR0BzHFblqxKQ6gF7yLJHVs=; b=PkAsoB7EcNuOk778vcF85+ S+0Kn6rnRsa5pn+IbO231APQwLJOZgoVqGzycFciGI6BgH9zPJZTcVE7okgzSi+R nMdQJ426PVuzSGh9yCUOMgIUcaOapZ3o9VMXUtOAMm0EaASSdwiEBJK9/1GHnqgm gpAUDybAWowfTyeGJBYd1yoNT3XLoo8czY/QKftV5NMmja4CKgxjgf+QDnvBHdhQ 7Bxev5uavmhIrFg0anHjySDDkcfPTK+FWbYbKIh6S0TsdPllnPlz5gEQ4qPTz3QO n2Pop9zcKeo8DZIPQ1K5Rcc3In0Iq/pfd7RnddySrx280cqYncexQolhAoGtwIMw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 87F5BE4636; Thu, 26 Jul 2018 14:07:07 -0400 (EDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org, Ferruh Yigit Date: Thu, 26 Jul 2018 20:07:03 +0200 Message-ID: <4850918.9fX15AOWJ3@xps> In-Reply-To: <2d0db3f0-3eeb-99bd-33bb-731965d2228f@intel.com> References: <20180712104948.3113-1-remy.horton@intel.com> <2d0db3f0-3eeb-99bd-33bb-731965d2228f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] lib/bitratestats: add NULL sanity checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 18:07:09 -0000 20/07/2018 17:31, Ferruh Yigit: > On 7/12/2018 11:49 AM, Remy Horton wrote: > > If rte_stats_bitrate_reg() or rte_stats_bitrate_calc() are > > passed NULL as the parameter for the stats structure, the > > result is a crash. Fixed by adding a sanity check that makes > > sure the passed-in pointer is not NULL. > > > > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") > > > > Signed-off-by: Remy Horton > > Acked-by: Ferruh Yigit Applied, thanks