From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6088A137C for ; Mon, 28 Aug 2017 13:00:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1544920D06; Mon, 28 Aug 2017 07:00:26 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 28 Aug 2017 07:00:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=+UPKkE3Ik0m9hd8 vlBPjsyF1R6l5urc8Bpj6zxHptN0=; b=e9G0B1byoyS32gfBfqji6z1f+FNldHf 6ueeB8rPl9OA9rw+DPFnMjCTVXLzV+7KV9faUonOJW6H+4HnjUCBjJjDDV3/FbzH tVmF4Kf52CsJ7WwtZFEsZ02tou0V/Cgi4nw2lQI73THjMSBFvDJEtFcRU0YRB/j9 RHdrNgMhQqXo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=+UPKkE3Ik0m9hd8vlBPjsyF1R6l5urc8Bpj6zxHptN0=; b=YzFleGnT 5/d7NKzWcebT9HMbgCq0ILdGjKx4ZK3BnD7GAoa/qCwWAxaiWgg1kRFsp+q7+Ira xNrT4lIqTd2+4BwxwAlkFDRUb0JmNXne6t7c7i5FuLXxS7LP0NQKksGeHs2Il+db 679WmzTtBDJul4HFC2iQnAyrqTGLgDiqG9dPMU9F5zUOtVia0GfBrF4J8LnP2B2C VUX8PeSwoV+N33CF+NXn+GsElDwwuFjQeriGrGTxE1lYK+Wy3OE5vWcQ7pgdZXCV at6KPV5chZomgJWC1rkN2ax38fLcO66lVE9ymvz0wlnpyHseLuuRb0teOYudjgnQ H18aOJsJpGn7tA== X-ME-Sender: X-Sasl-enc: A5WAdW6W+0e9GumpaG7FyKpYuOlgY6oYaJea3/fnwXkZ 1503918025 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B1AEB7E2EA; Mon, 28 Aug 2017 07:00:25 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Raslan Darawsheh , jingjing.wu@intel.com, salehals@mellanox.com Date: Mon, 28 Aug 2017 13:00:24 +0200 Message-ID: <48531686.15frCTT1P0@xps> In-Reply-To: <2200a72f-92bb-c4e6-db9d-b00961fc328b@intel.com> References: <1503499024-12480-1-git-send-email-rasland@mellanox.com> <20170828095523.GE8124@bidouze.vm.6wind.com> <2200a72f-92bb-c4e6-db9d-b00961fc328b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 11:00:27 -0000 28/08/2017 12:30, Ferruh Yigit: > On 8/28/2017 10:55 AM, Ga=EBtan Rivet wrote: > > Hi Raslan, > >=20 > > Redoing the review with the remarks from Thomas in mind. > >=20 > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > >> Added hotplug in testpmd, to be able to test hotplug function > >> in the PMD's. > >> > >> Signed-off-by: Raslan Darawsheh > >> --- > >> app/test-pmd/cmdline.c | 44 +++++++++++++++++++++++++++++++++++++++++= +++ > >> app/test-pmd/testpmd.c | 18 ++++++++++++++++++ > >> app/test-pmd/testpmd.h | 1 + > >> 3 files changed, 63 insertions(+) > >> > >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > >> index cd8c358..b32a368 100644 > >> --- a/app/test-pmd/cmdline.c > >> +++ b/app/test-pmd/cmdline.c > >> @@ -716,6 +716,9 @@ static void cmd_help_long_parsed(void *parsed_resu= lt, > >> "port config (port_id|all) l2-tunnel E-tag" > >> " (enable|disable)\n" > >> " Enable/disable the E-tag support.\n\n" > >> + > >> + " device remove (device)\n" > >=20 > > I think (device) might be hard to understand for a user. > > Maybe (device name)? >=20 > I am suspicious on adding new root level command to testpmd, it is > getting bigger, each command looks OK on its own context, but as a whole > app getting more confusing [1]. We can keep the root level "port" if we make clear that the impact is beyond the port. > Since dealing with device is kind of new, it can be OK to create new > command tree, but there are already hotplug commands per port: > "port attach #PCI|#VDEV_NAME" > "port detach #P" >=20 > perhaps it can be good to keep "attach", "detach" keywords for device to > be consistent? Not sure. Anyway ethdev attach and detach should be deprecated. We are moving to a more correct design where hotplug is done at EAL level. > "device attach #name" > "device detach #name" >=20 > Also a show equivalent can be added to work in device level: > "show device info" >=20 >=20 > [1] > http://dpdk.org/ml/archives/dev/2017-August/072764.html